[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-12-01 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16009#discussion_r90577450 --- Diff: docs/ml-features.md --- @@ -1188,7 +1188,9 @@ categorical features. The number of bins is set by the `numBuckets` parameter. I that the number

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16009 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-30 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16009#discussion_r90330019 --- Diff: docs/ml-features.md --- @@ -1188,7 +1188,9 @@ categorical features. The number of bins is set by the `numBuckets` parameter. I that the

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-30 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16009#discussion_r90287240 --- Diff: docs/ml-features.md --- @@ -1188,7 +1188,9 @@ categorical features. The number of bins is set by the `numBuckets` parameter. I that the number

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-29 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/16009#discussion_r90169879 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -49,15 +49,13 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-29 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16009#discussion_r90120095 --- Diff: docs/ml-features.md --- @@ -1188,7 +1188,9 @@ categorical features. The number of bins is set by the `numBuckets` parameter. I that the number

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-29 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16009#discussion_r90088312 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -49,15 +49,13 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-29 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/16009#discussion_r89961575 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -70,17 +70,16 @@ private[feature] trait

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-29 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/16009#discussion_r89961315 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -49,15 +49,13 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16009#discussion_r89868659 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -70,17 +70,16 @@ private[feature] trait QuantileDiscretizerBase

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16009#discussion_r89866977 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -49,15 +49,13 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-26 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/16009#discussion_r89671075 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -49,15 +49,13 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-25 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16009#discussion_r89661577 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -49,15 +49,13 @@ private[feature] trait ChiSqSelectorParams

[GitHub] spark pull request #16009: [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scal...

2016-11-24 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/16009 [SPARK-18318][ML] ML, Graph 2.1 QA: API: New Scala APIs, docs ## What changes were proposed in this pull request? API review for 2.1, except ```LSH``` related classes which are still under