[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16037 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-13 Thread AnthonyTruchet
Github user AnthonyTruchet commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r92150485 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,24 @@ object LBFGS extends Logging {

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-12 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r91975767 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,24 @@ object LBFGS extends Logging { val bcW =

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-12 Thread AnthonyTruchet
Github user AnthonyTruchet commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r91949738 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,24 @@ object LBFGS extends Logging {

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r91948007 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,24 @@ object LBFGS extends Logging { val bcW =

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-08 Thread AnthonyTruchet
Github user AnthonyTruchet commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r91493798 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,24 @@ object LBFGS extends Logging {

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-06 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r91206257 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,24 @@ object LBFGS extends Logging { val bcW =

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-06 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r91061168 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,27 @@ object LBFGS extends Logging { val bcW =

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-06 Thread AnthonyTruchet
Github user AnthonyTruchet commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r91036283 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,27 @@ object LBFGS extends Logging {

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-05 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r91005791 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,27 @@ object LBFGS extends Logging { val bcW =

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-04 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r90773986 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,27 @@ object LBFGS extends Logging { val bcW =

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-04 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r90773915 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,27 @@ object LBFGS extends Logging { val bcW =

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-04 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r90773871 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,27 @@ object LBFGS extends Logging { val bcW =

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-01 Thread AnthonyTruchet
Github user AnthonyTruchet commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r90422375 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,27 @@ object LBFGS extends Logging {

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-12-01 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r90421008 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +241,27 @@ object LBFGS extends Logging { val bcW =

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-11-30 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r90391752 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +239,25 @@ object LBFGS extends Logging { val bcW =

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-11-30 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/16037#discussion_r90388974 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala --- @@ -241,16 +239,25 @@ object LBFGS extends Logging { val bcW =

[GitHub] spark pull request #16037: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...

2016-11-28 Thread AnthonyTruchet
GitHub user AnthonyTruchet opened a pull request: https://github.com/apache/spark/pull/16037 [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vectors of 0 ## What changes were proposed in this pull request? CostFun used to send a dense vector of zeroes as a closure in a