Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16464
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r96144837
--- Diff: R/pkg/inst/tests/testthat/test_mllib_clustering.R ---
@@ -146,12 +146,16 @@ test_that("spark.lda with libsvm", {
topics <- stats$topicTop
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r96125283
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -404,11 +411,14 @@ setMethod("summary", signature(object = "LDAModel"),
vocabSize <- callJMe
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r96103386
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -404,11 +411,14 @@ setMethod("summary", signature(object = "LDAModel"),
vocabSize <- callJMet
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r96049147
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -404,11 +411,14 @@ setMethod("summary", signature(object = "LDAModel"),
vocabSize <- callJMe
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r96049008
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -404,11 +411,14 @@ setMethod("summary", signature(object = "LDAModel"),
vocabSize <- callJMe
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r96047751
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -404,11 +411,14 @@ setMethod("summary", signature(object = "LDAModel"),
vocabSize <- callJMe
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r96035584
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -404,11 +411,14 @@ setMethod("summary", signature(object = "LDAModel"),
vocabSize <- callJMet
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r95954100
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -404,11 +411,14 @@ setMethod("summary", signature(object = "LDAModel"),
vocabSize <- callJMeth
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r95951488
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -404,11 +411,14 @@ setMethod("summary", signature(object = "LDAModel"),
vocabSize <- callJMet
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r95948100
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -404,11 +411,14 @@ setMethod("summary", signature(object = "LDAModel"),
vocabSize <- callJMeth
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r95948289
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -388,6 +388,13 @@ setMethod("spark.lda", signature(data =
"SparkDataFrame"),
#' \item{\code{topic
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r95436115
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala ---
@@ -45,6 +45,11 @@ private[r] class LDAWrapper private (
import LDAWrapp
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r95434408
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala ---
@@ -45,6 +45,11 @@ private[r] class LDAWrapper private (
import LDAWrappe
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r94984564
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala ---
@@ -172,6 +187,8 @@ private[r] object LDAWrapper extends
MLReadable[LDAWrapper
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r94983934
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala ---
@@ -123,6 +126,10 @@ private[r] object LDAWrapper extends
MLReadable[LDAWrappe
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r94905455
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala ---
@@ -172,6 +187,8 @@ private[r] object LDAWrapper extends
MLReadable[LDAWrapper]
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r94905327
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -907,6 +917,8 @@ test_that("spark.lda with text input", {
expect_equal(logPerplexity, stats
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r94905196
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala ---
@@ -123,6 +126,10 @@ private[r] object LDAWrapper extends
MLReadable[LDAWrapper
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r94866311
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala ---
@@ -172,6 +187,8 @@ private[r] object LDAWrapper extends
MLReadable[LDAWrapper
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r94721880
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala ---
@@ -172,6 +187,8 @@ private[r] object LDAWrapper extends
MLReadable[LDAWrapper
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r94716683
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala ---
@@ -172,6 +187,8 @@ private[r] object LDAWrapper extends
MLReadable[LDAWrapper]
GitHub user wangmiao1981 opened a pull request:
https://github.com/apache/spark/pull/16464
[SPARK-19066][SparkR]:SparkR LDA doesn't set optimizer correctly
## What changes were proposed in this pull request?
spark.lda passes the optimizer "em" or "online" as a string to the
23 matches
Mail list logo
