[GitHub] spark pull request #16572: [SPARK-18863][SQL] Output non-aggregate expressio...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16572 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #16572: [SPARK-18863][SQL] Output non-aggregate expressio...

Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/16572#discussion_r97694229 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -223,7 +228,10 @@ class SQLQueryTestSuite extends QueryTest with SharedS

[GitHub] spark pull request #16572: [SPARK-18863][SQL] Output non-aggregate expressio...

Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/16572#discussion_r97694210 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -117,66 +117,72 @@ trait CheckAnalysis extends Predica

[GitHub] spark pull request #16572: [SPARK-18863][SQL] Output non-aggregate expressio...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16572#discussion_r97676523 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -223,7 +228,10 @@ class SQLQueryTestSuite extends QueryTest with Sh

[GitHub] spark pull request #16572: [SPARK-18863][SQL] Output non-aggregate expressio...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16572#discussion_r97676813 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -163,7 +163,12 @@ class SQLQueryTestSuite extends QueryTest with Sh

[GitHub] spark pull request #16572: [SPARK-18863][SQL] Output non-aggregate expressio...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16572#discussion_r97676592 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -117,66 +117,72 @@ trait CheckAnalysis extends Pr

[GitHub] spark pull request #16572: [SPARK-18863][SQL] Output non-aggregate expressio...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16572#discussion_r97675872 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -117,66 +117,72 @@ trait CheckAnalysis extends Pr

[GitHub] spark pull request #16572: [SPARK-18863][SQL] Output non-aggregate expressio...

Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/16572#discussion_r95982097 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -163,7 +163,12 @@ class SQLQueryTestSuite extends QueryTest with SharedS

[GitHub] spark pull request #16572: [SPARK-18863][SQL] Output non-aggregate expressio...

Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/16572#discussion_r95981409 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -117,66 +117,72 @@ trait CheckAnalysis extends Predica

[GitHub] spark pull request #16572: [SPARK-18863][SQL] Output non-aggregate expressio...

GitHub user nsyca opened a pull request: https://github.com/apache/spark/pull/16572 [SPARK-18863][SQL] Output non-aggregate expressions without GROUP BY in a subquery does not yield an error ## What changes were proposed in this pull request? This PR will report proper error me