[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-06-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-06-19 Thread actuaryzhang
Github user actuaryzhang closed the pull request at: https://github.com/apache/spark/pull/18140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-06-19 Thread actuaryzhang
GitHub user actuaryzhang reopened a pull request: https://github.com/apache/spark/pull/18140 [SPARK-20917][ML][SparkR] SparkR supports string encoding consistent with R ## What changes were proposed in this pull request? Add `stringIndexerOrderType` to `spark.glm` and

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-06-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18140#discussion_r122632729 --- Diff: R/pkg/tests/fulltests/test_mllib_regression.R --- @@ -367,6 +367,51 @@ test_that("glm save/load", { unlink(modelPath) })

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-06-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18140#discussion_r122632631 --- Diff: R/pkg/R/mllib_regression.R --- @@ -443,10 +478,14 @@ setMethod("write.ml", signature(object = "IsotonicRegressionModel", path = "char #'

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-06-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18140#discussion_r122632393 --- Diff: R/pkg/R/mllib_regression.R --- @@ -145,7 +163,8 @@ setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"),

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-06-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18140#discussion_r122632556 --- Diff: R/pkg/R/mllib_regression.R --- @@ -182,9 +207,13 @@ setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"), #'

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-05-31 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/18140#discussion_r119438348 --- Diff: R/pkg/R/mllib_regression.R --- @@ -110,7 +125,8 @@ setClass("IsotonicRegressionModel", representation(jobj = "jobj")) #' @seealso

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-05-31 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18140#discussion_r119403261 --- Diff: R/pkg/R/mllib_regression.R --- @@ -110,7 +125,8 @@ setClass("IsotonicRegressionModel", representation(jobj = "jobj")) #' @seealso

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-05-31 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/18140#discussion_r119285081 --- Diff: R/pkg/inst/tests/testthat/test_mllib_regression.R --- @@ -379,6 +379,49 @@ test_that("glm save/load", { unlink(modelPath) })

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-05-30 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/18140#discussion_r119029879 --- Diff: R/pkg/R/mllib_regression.R --- @@ -110,7 +125,8 @@ setClass("IsotonicRegressionModel", representation(jobj = "jobj")) #' @seealso

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-05-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18140#discussion_r119022717 --- Diff: R/pkg/inst/tests/testthat/test_mllib_regression.R --- @@ -379,6 +379,49 @@ test_that("glm save/load", { unlink(modelPath) })

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-05-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18140#discussion_r119022422 --- Diff: R/pkg/R/mllib_regression.R --- @@ -110,7 +125,8 @@ setClass("IsotonicRegressionModel", representation(jobj = "jobj")) #' @seealso

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-05-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18140#discussion_r119021523 --- Diff: R/pkg/R/mllib_regression.R --- @@ -70,6 +70,12 @@ setClass("IsotonicRegressionModel", representation(jobj = "jobj")) #'