[GitHub] spark pull request #18789: SPARK-20433 Bump jackson from 2.6.5 to 2.6.7.1

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/18789


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18789: SPARK-20433 Bump jackson from 2.6.5 to 2.6.7.1

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/18789#discussion_r130815754
  
--- Diff: sql/core/pom.xml ---
@@ -101,7 +101,7 @@
 
   com.fasterxml.jackson.core
   jackson-databind
-  ${fasterxml.jackson.version}
+  ${fasterxml.jackson.databind.version}
--- End diff --

Oh yeah forgot I made that change too. Agree


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18789: SPARK-20433 Bump jackson from 2.6.5 to 2.6.7.1

[zsxwing]

Github user zsxwing commented on a diff in the pull request:

https://github.com/apache/spark/pull/18789#discussion_r130686972
  
--- Diff: sql/core/pom.xml ---
@@ -101,7 +101,7 @@
 
   com.fasterxml.jackson.core
   jackson-databind
-  ${fasterxml.jackson.version}
+  ${fasterxml.jackson.databind.version}
--- End diff --

hm, why do we need a version number here? Could you just remove it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org