[GitHub] spark pull request #18903: [SPARK-21590][SS]Window start time should support...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18903 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18903: [SPARK-21590][SS]Window start time should support...
Github user KevinZwx commented on a diff in the pull request:
https://github.com/apache/spark/pull/18903#discussion_r132821343
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala
---
@@ -77,6 +77,19 @@ class TimeWindowSuite extends SparkFunSuite with
ExpressionEvalHelper with Priva
}
}
+ test("SPARK-21590: Start time works with negative values and return
microseconds") {
--- End diff --
Yeah thanks, I added some tests in `DataFrameTimeWindowingSuite `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18903: [SPARK-21590][SS]Window start time should support...
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/18903#discussion_r132729005
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala
---
@@ -77,6 +77,19 @@ class TimeWindowSuite extends SparkFunSuite with
ExpressionEvalHelper with Priva
}
}
+ test("SPARK-21590: Start time works with negative values and return
microseconds") {
--- End diff --
could you also add a DataFrame test for this with a negative value? then
I'll feel a lot more comfortable that we don't have to have the start offset as
a positive number in the window calculation.
Look for `DataFrameTimeWindowingSuite.scala`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18903: [SPARK-21590][SS]Window start time should support...
GitHub user KevinZwx opened a pull request: https://github.com/apache/spark/pull/18903 [SPARK-21590][SS]Window start time should support negative values ## What changes were proposed in this pull request? Remove the non-negative checks of window start time to make window support negative start time, and add a check to guarantee the absolute value of start time is less than slide duration. ## How was this patch tested? New unit tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/KevinZwx/spark dev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/18903.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18903 commit 2073be263e31ba0a957b7ffa2bec2cafe40011d2 Author: HanShuliang Date: 2017-08-10T06:46:04Z [SPARK-21590][SS]Window start time should support negative values --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
