[GitHub] spark pull request #18931: [SPARK-21717][SQL][WIP] Decouple consume function...

2017-08-13 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/18931 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #18931: [SPARK-21717][SQL][WIP] Decouple consume function...

2017-08-13 Thread viirya
GitHub user viirya reopened a pull request: https://github.com/apache/spark/pull/18931 [SPARK-21717][SQL][WIP] Decouple consume functions of physical operators in whole-stage codegen ## What changes were proposed in this pull request? It has been observed in SPARK-21603 tha

[GitHub] spark pull request #18931: [SPARK-21717][SQL][WIP] Decouple consume function...

2017-08-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18931#discussion_r132837981 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -149,14 +149,65 @@ trait CodegenSupport extends SparkPla

[GitHub] spark pull request #18931: [SPARK-21717][SQL][WIP] Decouple consume function...

2017-08-13 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18931#discussion_r132835926 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -149,14 +149,65 @@ trait CodegenSupport extends SparkPlan

[GitHub] spark pull request #18931: [SPARK-21717][SQL][WIP] Decouple consume function...

2017-08-12 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/18931 [SPARK-21717][SQL][WIP] Decouple consume functions of physical operators in whole-stage codegen ## What changes were proposed in this pull request? It has been observed in SPARK-21603 that