Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19327
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142536858
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -157,11 +164,20 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142533513
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -425,6 +426,10 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142530623
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,222 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142530435
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,222 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142530086
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,222 @@ class StreamingJoinSuite extends
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142442657
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -425,6 +426,10 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142344009
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,283 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142343784
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,283 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142339309
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,283 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142339158
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,283 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142338734
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,283 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142338500
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,283 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142338421
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,283 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142336109
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,283 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142335872
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,283 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142335782
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -470,3 +475,283 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142335578
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
---
@@ -425,6 +426,10 @@ class StreamingJoinSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r142288587
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -233,16 +234,53 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141989504
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -133,242 +134,6 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141987778
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -207,31 +221,108 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141987664
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -207,31 +221,108 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141986897
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -207,31 +221,108 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141986865
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -207,31 +221,108 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141986696
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -413,36 +414,103 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141986708
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -413,36 +414,103 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141986634
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -413,36 +414,103 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141986168
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -413,36 +414,103 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141986227
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -413,36 +414,103 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141985815
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -413,36 +414,103 @@ class
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141984167
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -413,36 +414,103 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141982780
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -233,16 +234,54 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141934283
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -233,16 +234,54 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141934224
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -233,16 +234,54 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141934213
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -233,16 +234,54 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141934201
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -233,16 +234,54 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141698377
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -233,16 +234,46 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141934196
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -233,16 +234,54 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141715025
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -413,36 +414,103 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r141698177
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/StreamingJoinHelper.scala
---
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the
40 matches
Mail list logo
