Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19800
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19800#discussion_r152881639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -149,10 +151,14 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19800#discussion_r152844926
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -149,10 +151,14 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19800#discussion_r152799599
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -72,6 +72,7 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19800#discussion_r152799244
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -72,6 +72,7 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19800#discussion_r152798856
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -72,6 +72,7 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19800#discussion_r152798521
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -72,6 +72,7 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19800#discussion_r152798443
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/OrderingSuite.scala
---
@@ -156,4 +156,13 @@ class OrderingSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19800#discussion_r152794103
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/OrderingSuite.scala
---
@@ -156,4 +156,13 @@ class OrderingSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19800#discussion_r152791909
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/OrderingSuite.scala
---
@@ -156,4 +156,13 @@ class OrderingSuite extends
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19800
[SPARK-22591][SQL] GenerateOrdering shouldn't change
CodegenContext.INPUT_ROW
## What changes were proposed in this pull request?
When I played with codegen in developing another PR, I
11 matches
Mail list logo
