[GitHub] spark pull request #20253: [SPARK-22908][SS] fix continuous Kafka data reade...

2018-01-12 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20253#discussion_r161351849 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala --- @@ -192,11 +194,30 @@ class

[GitHub] spark pull request #20253: [SPARK-22908][SS] fix continuous Kafka data reade...

2018-01-12 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20253#discussion_r161349767 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala --- @@ -192,11 +194,26 @@ class

[GitHub] spark pull request #20253: [SPARK-22908][SS] fix continuous Kafka data reade...

2018-01-12 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/20253#discussion_r161347769 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala --- @@ -192,11 +193,18 @@ class

[GitHub] spark pull request #20253: [SPARK-22908][SS] fix continuous Kafka data reade...

2018-01-12 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/20253#discussion_r161347074 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala --- @@ -192,11 +193,18 @@ class

[GitHub] spark pull request #20253: [SPARK-22908][SS] fix continuous Kafka data reade...

2018-01-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20253#discussion_r161344562 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala --- @@ -192,11 +193,18 @@ class

[GitHub] spark pull request #20253: [SPARK-22908][SS] fix continuous Kafka data reade...

2018-01-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20253#discussion_r161343982 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala --- @@ -192,11 +193,18 @@ class

[GitHub] spark pull request #20253: [SPARK-22908][SS] fix continuous Kafka data reade...

2018-01-12 Thread jose-torres
GitHub user jose-torres opened a pull request: https://github.com/apache/spark/pull/20253 [SPARK-22908][SS] fix continuous Kafka data reader ## What changes were proposed in this pull request? The Kafka reader is now interruptible and can close itself. Note that