Github user echarles closed the pull request at:
https://github.com/apache/spark/pull/20451
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user echarles commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r201781927
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -20,41 +20,65 @@
Github user echarles commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r201778571
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -58,6 +58,8 @@ private[spark] object Config
Github user echarles commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r201778543
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/OptionRequirements.scala
---
@@ -0,0 +1,40 @@
+/*
--- End
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r165513067
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -58,6 +58,8 @@ private[spark] object Config
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r201512105
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -20,41 +20,65
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r165512914
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/OptionRequirements.scala
---
@@ -0,0 +1,40 @@
+/*
---
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r165513254
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -88,6 +103,60 @@
Github user echarles commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r201327022
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -140,13 +140,6 @@
Github user echarles commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r201215612
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -18,43 +18,68 @@
Github user echarles commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r201215439
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -140,13 +140,6 @@
Github user echarles commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r201214812
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -88,6 +103,56 @@
Github user echarles commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r201212364
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -88,6 +103,56 @@
Github user echarles commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r201211050
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/OptionRequirements.scala
---
@@ -0,0 +1,40 @@
+/*
+ *
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r200020286
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -18,43 +18,68 @@
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r199340795
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -140,13 +140,6 @@
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r199340757
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -88,6 +103,56 @@
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r199340748
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -88,6 +103,56 @@
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20451#discussion_r166087229
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/OptionRequirements.scala
---
@@ -0,0 +1,40 @@
+/*
+ *
GitHub user echarles opened a pull request:
https://github.com/apache/spark/pull/20451
[SPARK-23146][WIP] Support client mode for Kubernetes cluster backend
## What changes were proposed in this pull request?
The changes allow to support Kubernetes resource manager in
20 matches
Mail list logo