[GitHub] spark pull request #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeti...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20498 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeti...
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/20498#discussion_r165844408 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalArithmeticOperations.sql --- @@ -74,7 +75,8 @@ select 12345678901234567890.0 * 12345678901234567890.0; select 1e35 / 0.1; -- arithmetic operations causing a precision loss return NULL +select 12345678912345678912345678912.1234567 + 999.12345; --- End diff -- The result is: ``` -- !query 32 select 12345678912345678912345678912.1234567 + 999.12345 -- !query 32 schema struct<(CAST(12345678912345678912345678912.1234567 AS DECIMAL(38,7)) + CAST(999.12345 AS DECIMAL(38,7))):decimal(38,7)> -- !query 32 output NULL -- !query 33 select 123456789123456789.1234567890 * 1.123456789123456789 -- !query 33 schema struct<(CAST(123456789123456789.1234567890 AS DECIMAL(36,18)) * CAST(1.123456789123456789 AS DECIMAL(36,18))):decimal(38,28)> -- !query 33 output NULL -- !query 34 select 12345678912345.123456789123 / 0.00012345678 -- !query 34 schema struct<(CAST(12345678912345.123456789123 AS DECIMAL(29,15)) / CAST(1.2345678E-8 AS DECIMAL(29,15))):decimal(38,18)> -- !query 34 output NULL ``` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeti...
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/20498#discussion_r165844386 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalArithmeticOperations.sql --- @@ -48,8 +48,9 @@ select 12345678901234567890.0 * 12345678901234567890.0; select 1e35 / 0.1; -- arithmetic operations causing a precision loss are truncated +select 12345678912345678912345678912.1234567 + 999.12345; --- End diff -- The result is: ``` -- !query 17 select 12345678912345678912345678912.1234567 + 999.12345 -- !query 17 schema struct<(CAST(12345678912345678912345678912.1234567 AS DECIMAL(38,6)) + CAST(999.12345 AS DECIMAL(38,6))):decimal(38,6)> -- !query 17 output 10012345678912345678912345678911.246907 -- !query 18 select 123456789123456789.1234567890 * 1.123456789123456789 -- !query 18 schema struct<(CAST(123456789123456789.1234567890 AS DECIMAL(36,18)) * CAST(1.123456789123456789 AS DECIMAL(36,18))):decimal(38,18)> -- !query 18 output 138698367904130467.654320988515622621 -- !query 19 select 12345678912345.123456789123 / 0.00012345678 -- !query 19 schema struct<(CAST(12345678912345.123456789123 AS DECIMAL(29,15)) / CAST(1.2345678E-8 AS DECIMAL(29,15))):decimal(38,9)> -- !query 19 output 100073899961059796.725866332 ``` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeti...
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20498#discussion_r165821454 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalArithmeticOperations.sql --- @@ -49,7 +49,7 @@ select 1e35 / 0.1; -- arithmetic operations causing a precision loss are truncated select 123456789123456789.1234567890 * 1.123456789123456789; -select 0.001 / 9876543210987654321098765432109876543.2 +select 0.001 / 9876543210987654321098765432109876543.2; --- End diff -- This is not a good test case. The results and schemas are the same no matter whether we set `spark.sql.decimalOperations.allowPrecisionLoss` to true or false. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeti...
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20498#discussion_r165820795 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalArithmeticOperations.sql --- @@ -49,7 +49,7 @@ select 1e35 / 0.1; -- arithmetic operations causing a precision loss are truncated select 123456789123456789.1234567890 * 1.123456789123456789; -select 0.001 / 9876543210987654321098765432109876543.2 +select 0.001 / 9876543210987654321098765432109876543.2; --- End diff -- ... A good catch! We need to review the PR more carefully. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
