[GitHub] spark pull request #20659: [DNM] Try to update Hive to 2.3.2
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20659#discussion_r172589587 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -2513,9 +2513,9 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils { }.getMessage assert(e.contains("Found duplicate column(s)")) } else { -sql("ALTER TABLE t1 ADD COLUMNS (C1 string)") +sql("ALTER TABLE t1 ADD COLUMNS (C2 string)") assert(spark.table("t1").schema == - new StructType().add("c1", IntegerType).add("C1", StringType)) + new StructType().add("c1", IntegerType).add("C2", StringType)) --- End diff -- You are intentionally removing `case sensitive` test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20659: [DNM] Try to update Hive to 2.3.2
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20659#discussion_r172588801 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala --- @@ -371,7 +371,7 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils { test("correctly handle ALTER VIEW") { withTable("jt2") { withView("testView") { -sql("CREATE VIEW testView AS SELECT id FROM jt") +sql("CREATE VIEW testView AS SELECT 1 as c1 FROM jt") --- End diff -- It is unrelated change and looks wrong. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20659: [DNM] Try to update Hive to 2.3.2
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20659#discussion_r172588393 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java --- @@ -21,6 +21,9 @@ import java.util.stream.IntStream; import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.common.type.HiveDecimal; +import org.apache.hadoop.hive.ql.exec.vector.*; +import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable; --- End diff -- Please revert this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20659: [DNM] Try to update Hive to 2.3.2
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20659#discussion_r172588073 --- Diff: sql/core/pom.xml --- @@ -86,15 +86,17 @@ test + + org.apache.hive + hive-storage-api + org.apache.orc orc-core - ${orc.classifier} --- End diff -- Please don't remove this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20659: [DNM] Try to update Hive to 2.3.2
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20659#discussion_r172587976 --- Diff: sql/core/pom.xml --- @@ -86,15 +86,17 @@ test + + org.apache.hive + hive-storage-api + --- End diff -- BTW, you should not introduce `hive` into `sql/core`. Apache ORC should be used as Apache ORC. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20659: [DNM] Try to update Hive to 2.3.2
GitHub user wangyum reopened a pull request: https://github.com/apache/spark/pull/20659 [DNM] Try to update Hive to 2.3.2 ## What changes were proposed in this pull request? Check if there is any test failed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wangyum/spark hive-2.3.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/20659.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20659 commit 915e68faefcbb5d39ad707937ef95883294c1825 Author: Yuming Wang Date: 2018-02-22T06:55:18Z Update Hive to 2.3.2 * Update Hive to 2.3.2 commit a5bb731985488892ef9bc8ec9bbcff2a218d0130 Author: Yuming Wang Date: 2018-02-22T09:52:10Z replace manifest commit 80fd8a8aa3c3e42cd99f164f80cfcc6f46e2f247 Author: Yuming Wang Date: 2018-02-22T11:10:10Z Fix javaunidoc error commit 1110ede7e43d8638810e4e0f37772443fc91449b Author: Yuming Wang Date: 2018-03-05T13:34:28Z Merge remote-tracking branch 'upstream/master' into hive-2.3.x # Conflicts: # sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala # sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala # sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala # sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala # sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala # sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20659: [DNM] Try to update Hive to 2.3.2
Github user wangyum closed the pull request at: https://github.com/apache/spark/pull/20659 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20659: [DNM] Try to update Hive to 2.3.2
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/20659 [DNM] Try to update Hive to 2.3.2 ## What changes were proposed in this pull request? Check if there is any test failed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wangyum/spark hive-2.3.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/20659.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20659 commit 915e68faefcbb5d39ad707937ef95883294c1825 Author: Yuming Wang Date: 2018-02-22T06:55:18Z Update Hive to 2.3.2 * Update Hive to 2.3.2 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org