[GitHub] spark pull request #21035: [SPARK-23847][FOLLOWUP][PYTHON][SQL] Actually tes...

2018-04-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/21035


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #21035: [SPARK-23847][FOLLOWUP][PYTHON][SQL] Actually tes...

2018-04-10 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request:

https://github.com/apache/spark/pull/21035

[SPARK-23847][FOLLOWUP][PYTHON][SQL] Actually test 
[desc|acs]_nulls_[first|last] functions

## What changes were proposed in this pull request?

There was a mistake in `tests.py` missing `assertEquals`.

## How was this patch tested?

Fixed tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HyukjinKwon/spark SPARK-23847

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/21035.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #21035


commit ffa05dcccdfb4d509741e0ca6b38c17915028eb2
Author: hyukjinkwon 
Date:   2018-04-11T02:18:52Z

Actually test [desc|asc]_nulls_[first|last] functions




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org