[GitHub] spark pull request #21294: [SPARK-24197][SparkR][SQL] Adding array_sort func...

2018-05-18 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/21294#discussion_r189244494 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1497,10 +1496,16 @@ test_that("column functions", { result <- collect(select(df,

[GitHub] spark pull request #21294: [SPARK-24197][SparkR][SQL] Adding array_sort func...

2018-05-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21294#discussion_r189063233 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1497,10 +1496,16 @@ test_that("column functions", { result <- collect(select(df,

[GitHub] spark pull request #21294: [SPARK-24197][SparkR][SQL] Adding array_sort func...

2018-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21294 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21294: [SPARK-24197][SparkR][SQL] Adding array_sort func...

2018-05-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21294#discussion_r187470081 --- Diff: R/pkg/R/functions.R --- @@ -208,6 +208,7 @@ NULL #' head(select(tmp, array_contains(tmp$v1, 21), size(tmp$v1))) #' head(select(tmp,

[GitHub] spark pull request #21294: [SPARK-24197][SparkR][SQL] Adding array_sort func...

2018-05-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21294#discussion_r187404332 --- Diff: R/pkg/R/functions.R --- @@ -3118,8 +3133,9 @@ setMethod("size", }) #' @details -#' \code{sort_array}: Sorts the

[GitHub] spark pull request #21294: [SPARK-24197][SparkR][SQL] Adding array_sort func...

2018-05-10 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/21294#discussion_r187381390 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1497,12 +1496,18 @@ test_that("column functions", { result <- collect(select(df,

[GitHub] spark pull request #21294: [SPARK-24197][SparkR][SQL] Adding array_sort func...

2018-05-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21294#discussion_r187380861 --- Diff: R/pkg/R/functions.R --- @@ -3118,8 +3133,9 @@ setMethod("size", }) #' @details -#' \code{sort_array}: Sorts the

[GitHub] spark pull request #21294: [SPARK-24197][SparkR][SQL] Adding array_sort func...

2018-05-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21294#discussion_r187380230 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1497,12 +1496,18 @@ test_that("column functions", { result <- collect(select(df,

[GitHub] spark pull request #21294: [SPARK-24197][SparkR][SQL] Adding array_sort func...

2018-05-10 Thread mn-mikke
GitHub user mn-mikke opened a pull request: https://github.com/apache/spark/pull/21294 [SPARK-24197][SparkR][SQL] Adding array_sort function to SparkR ## What changes were proposed in this pull request? The PR adds array_sort function to SparkR. ## How was this