Re: [PR] [SPARK-42492][SQL] Add new function filter_value [spark]
github-actions[bot] closed pull request #40085: [SPARK-42492][SQL] Add new function filter_value URL: https://github.com/apache/spark/pull/40085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-42492][SQL] Add new function filter_value [spark]
github-actions[bot] commented on PR #40085: URL: https://github.com/apache/spark/pull/40085#issuecomment-2307950797 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-42492][SQL] Add new function filter_value [spark]
beliefer commented on PR #40085: URL: https://github.com/apache/spark/pull/40085#issuecomment-1831515735 I got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-42492][SQL] Add new function filter_value [spark]
Kimahriman commented on PR #40085: URL: https://github.com/apache/spark/pull/40085#issuecomment-1829775207 > Could you show the mainstream databases support the function? I didn't pull this from anywhere else, I just made it up to address a performance limitation with subexpression elimination which still exists after 2 years and several PRs trying to address. Don't love the name but couldn't think of a better one. @cloud-fan curious your thoughts on this. It's a slightly different approach to solving the same issue as your `NullIf` improvement with the new `With` clause, but for arbitrary condition expressions on a value, not just exact equals. Almost like `NullWhen`. If any of the conditional subexpression eliminations PRs ever get merged or your `With` work eventually covers this use case might not be necessary anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-42492][SQL] Add new function filter_value [spark]
beliefer commented on PR #40085: URL: https://github.com/apache/spark/pull/40085#issuecomment-1828956996 Could you show the mainstream databases support the function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
