Re: [PR] [SPARK-45292][SQL][HIVE] Remove Guava from shared classes from IsolatedClientLoader [spark]
dongjoon-hyun commented on PR #42599: URL: https://github.com/apache/spark/pull/42599#issuecomment-1972081187 Thank you always, @sunchao ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45292][SQL][HIVE] Remove Guava from shared classes from IsolatedClientLoader [spark]
sunchao commented on PR #42599: URL: https://github.com/apache/spark/pull/42599#issuecomment-1972080068 Hey @pan3793 @dongjoon-hyun , sorry for the delay on Hive 2.3.10. I plan to start working on the release in the next few days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45292][SQL][HIVE] Remove Guava from shared classes from IsolatedClientLoader [spark]
pan3793 commented on PR #42599: URL: https://github.com/apache/spark/pull/42599#issuecomment-1953407563 > Is there any update for Apache Hive 2.3.10, @pan3793 ? @dongjoon-hyun we have made several patches into branch-2.3 after 2.3.9 https://github.com/apache/hive/commits/branch-2.3/ seems there are some expected patches were not get in - https://github.com/apache/hive/pull/4892 (low priority) - https://github.com/apache/hive/pull/4911 (new feature) - https://github.com/apache/hive/pull/4923 (CVE) kindly ping @sunchao, do you have ETA for 2.3.10? and please let me know what can I do for this release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45292][SQL][HIVE] Remove Guava from shared classes from IsolatedClientLoader [spark]
dongjoon-hyun commented on PR #42599: URL: https://github.com/apache/spark/pull/42599#issuecomment-1947911644 Is there any update for Apache Hive 2.3.10, @pan3793 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45292][SQL][HIVE] Remove Guava from shared classes from IsolatedClientLoader [spark]
dongjoon-hyun commented on PR #42599: URL: https://github.com/apache/spark/pull/42599#issuecomment-1876382166 Thank you! cc @sunchao for Apache Hive 2.3.10 release~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45292][SQL][HIVE] Remove Guava from shared classes from IsolatedClientLoader [spark]
LuciferYang commented on PR #42599: URL: https://github.com/apache/spark/pull/42599#issuecomment-1876381394 > @dongjoon-hyun thank you, will continue Guava upgrading works once Hive 2.3.10 is available Looking forward to the release of Hive 2.3.10 :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45292][SQL][HIVE] Remove Guava from shared classes from IsolatedClientLoader [spark]
pan3793 commented on PR #42599: URL: https://github.com/apache/spark/pull/42599#issuecomment-1876375035 @dongjoon-hyun thank you, will continue Guava upgrading works once Hive 2.3.10 is available -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45292][SQL][HIVE] Remove Guava from shared classes from IsolatedClientLoader [spark]
dongjoon-hyun commented on PR #42599: URL: https://github.com/apache/spark/pull/42599#issuecomment-1876342306 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45292][SQL][HIVE] Remove Guava from shared classes from IsolatedClientLoader [spark]
dongjoon-hyun closed pull request #42599: [SPARK-45292][SQL][HIVE] Remove Guava from shared classes from IsolatedClientLoader URL: https://github.com/apache/spark/pull/42599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45292][SQL][HIVE] Remove Guava from shared classes from IsolatedClientLoader [spark]
pan3793 commented on PR #42599: URL: https://github.com/apache/spark/pull/42599#issuecomment-1859488407 @JoshRosen @sunchao @wangyum I think no known technical issues are blocking us from upgrading Guava while keeping `IsolatedClientLoader` in Spark 4.0.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45292][SQL][HIVE] Remove Guava from shared classes from IsolatedClientLoader [spark]
pan3793 commented on code in PR #42599:
URL: https://github.com/apache/spark/pull/42599#discussion_r1429441230
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala:
##
@@ -130,8 +130,7 @@ private[hive] object IsolatedClientLoader extends Logging {
}
val hiveArtifacts = version.extraDeps ++
Seq("hive-metastore", "hive-exec", "hive-common", "hive-serde")
-.map(a => s"org.apache.hive:$a:${version.fullVersion}") ++
- Seq("com.google.guava:guava:14.0.1") ++ hadoopJarNames
+.map(a => s"org.apache.hive:$a:${version.fullVersion}") ++
hadoopJarNames
Review Comment:
things changed after we removed support for Hive prior 2.0.0, we can remove
Guava from the shared class list now, thus we can do Guava upgrading while
keeping `IsolatedClientLoader `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
