Re: [PR] [SPARK-46140][SQL][TESTS] Remove no longer needed JVM module options from `HiveExternalCatalogVersionsSuite` [spark]

2023-11-28 Thread via GitHub


LuciferYang commented on PR #44057:
URL: https://github.com/apache/spark/pull/44057#issuecomment-1830969283

   @dongjoon-hyun Agree with your point, have updated the code,  will update 
the pr title and description later.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-46140][SQL][TESTS] Remove no longer needed JVM module options from `HiveExternalCatalogVersionsSuite` [spark]

2023-11-28 Thread via GitHub


LuciferYang commented on PR #44057:
URL: https://github.com/apache/spark/pull/44057#issuecomment-1830131662

   wait me check `HiveExternalCatalogVersionsSuite` with Java 21


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org