Re: [PR] [SPARK-46151][PYTHON][DOCS] Hide the `More drop-down button` in the PySpark docs navigation bar [spark]
HyukjinKwon closed pull request #44068: [SPARK-46151][PYTHON][DOCS] Hide the `More drop-down button` in the PySpark docs navigation bar URL: https://github.com/apache/spark/pull/44068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46151][PYTHON][DOCS] Hide the `More drop-down button` in the PySpark docs navigation bar [spark]
HyukjinKwon commented on PR #44068: URL: https://github.com/apache/spark/pull/44068#issuecomment-183297 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46151][PYTHON][DOCS] Hide the `More drop-down button` in the PySpark docs navigation bar [spark]
itholic commented on PR #44068: URL: https://github.com/apache/spark/pull/44068#issuecomment-1831320232 I guess maybe you wanted to make it looks like: Hide the "More" drop-down button in the PySpark docs navigation bar ? or Hide the `"More"` drop-down button in the PySpark docs navigation bar ? But it's not a big deal, so the PR looks still good to me :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46151][PYTHON][DOCS] Hide the `More drop-down button` in the PySpark docs navigation bar [spark]
panbingkun commented on PR #44068: URL: https://github.com/apache/spark/pull/44068#issuecomment-1831288840 > Btw, seems like the code-block style is not applied properly in the PR title? > > https://private-user-images.githubusercontent.com/44108233/286495201-c80c6c7e-544a-4940-8e87-7c0fed25a5ce.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDEyMzg5OTAsIm5iZiI6MTcwMTIzODY5MCwicGF0aCI6Ii80NDEwODIzMy8yODY0OTUyMDEtYzgwYzZjN2UtNTQ0YS00OTQwLThlODctN2MwZmVkMjVhNWNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzExMjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMTI5VDA2MTgxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJkZmYwNDYxOGYzOWZjZmUzZTJkMDJkYmUxODMxOGZkZGQ0N2UyZGIxMWRmYzg2MTI2NzU4MjNjOTRlYWViZTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.vgX0gyyrCdg87zU_BCIRl8snQdgKdAsqvd6_30KVdwo;> > Could you address it? Done, is it OK now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46151][PYTHON][DOCS] Hide the `More" drop-down button` in the PySpark docs navigation bar [spark]
itholic commented on PR #44068: URL: https://github.com/apache/spark/pull/44068#issuecomment-1831286173 Btw, seems like the code-block style is not applied properly in the PR title? https://github.com/apache/spark/assets/44108233/c80c6c7e-544a-4940-8e87-7c0fed25a5ce;> Could you address it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46151][PYTHON][DOCS] Hide the `More" drop-down button` in the PySpark docs navigation bar [spark]
itholic commented on code in PR #44068: URL: https://github.com/apache/spark/pull/44068#discussion_r1408794458 ## python/docs/source/conf.py: ## @@ -196,6 +196,7 @@ # further. For a list of options available for each theme, see the # documentation. html_theme_options = { +"header_links_before_dropdown": 6, Review Comment: Oh, I was also thinking of fixing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46151][PYTHON][DOCS] Hide the `More" drop-down button` in the PySpark docs navigation bar [spark]
panbingkun commented on code in PR #44068: URL: https://github.com/apache/spark/pull/44068#discussion_r1408773499 ## python/docs/source/conf.py: ## @@ -196,6 +196,7 @@ # further. For a list of options available for each theme, see the # documentation. html_theme_options = { +"header_links_before_dropdown": 6, Review Comment: default value is 5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46151][PYTHON][DOCS] Hide the `More" drop-down button` in the PySpark docs navigation bar [spark]
panbingkun commented on PR #44068: URL: https://github.com/apache/spark/pull/44068#issuecomment-1831256603 cc @HyukjinKwon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org