Re: [PR] [SPARK-46262][PS] Enable test for `np.left_shift` for Pandas-on-Spark object. [spark]

2023-12-05 Thread via GitHub


zhengruifeng closed pull request #44178: [SPARK-46262][PS] Enable test for 
`np.left_shift` for Pandas-on-Spark object.
URL: https://github.com/apache/spark/pull/44178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-46262][PS] Enable test for `np.left_shift` for Pandas-on-Spark object. [spark]

2023-12-05 Thread via GitHub


zhengruifeng commented on PR #44178:
URL: https://github.com/apache/spark/pull/44178#issuecomment-1840475960

   merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-46262][PS] Enable test for `np.left_shift` for Pandas-on-Spark object. [spark]

2023-12-04 Thread via GitHub


HyukjinKwon commented on code in PR #44178:
URL: https://github.com/apache/spark/pull/44178#discussion_r1414970208


##
python/pyspark/pandas/tests/test_numpy_compat.py:
##
@@ -41,10 +41,6 @@ class NumPyCompatTestsMixin:
 "log1p",  # flaky
 "modf",
 "floor_divide",  # flaky
-# Results seem inconsistent in a different version of, I (Hyukjin) 
suspect, PyArrow.

Review Comment:
   :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org