Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up `SeqOps.view` and `ArrayOps.view` conversions [spark]
LuciferYang commented on PR #44179: URL: https://github.com/apache/spark/pull/44179#issuecomment-1842120583 Thanks @yaooqinn @dongjoon-hyun @zhengruifeng ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up `SeqOps.view` and `ArrayOps.view` conversions [spark]
yaooqinn commented on PR #44179: URL: https://github.com/apache/spark/pull/44179#issuecomment-1842108945 Thanks @LuciferYang @dongjoon-hyun @zhengruifeng Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up `SeqOps.view` and `ArrayOps.view` conversions [spark]
yaooqinn closed pull request #44179: [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up `SeqOps.view` and `ArrayOps.view` conversions URL: https://github.com/apache/spark/pull/44179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up `SeqOps.view` and `ArrayOps.view` conversions [spark]
LuciferYang commented on PR #44179: URL: https://github.com/apache/spark/pull/44179#issuecomment-1842024051 Thanks @dongjoon-hyun ~ Could you take another look? @yaooqinn Thanks ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up `SeqOps.view` and `ArrayOps.view` conversions [spark]
dongjoon-hyun commented on code in PR #44179:
URL: https://github.com/apache/spark/pull/44179#discussion_r1415983554
##
core/src/main/scala/org/apache/spark/ui/UIUtils.scala:
##
@@ -431,7 +431,7 @@ private[spark] object UIUtils extends Logging {
}
val headerRow: Seq[Node] = {
- headers.view.zipWithIndex.map { x =>
+ headers.to(LazyList).zipWithIndex.map { x =>
Review Comment:
Thank you for the answer, @LuciferYang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up `SeqOps.view` and `ArrayOps.view` conversions [spark]
LuciferYang commented on code in PR #44179:
URL: https://github.com/apache/spark/pull/44179#discussion_r1415981487
##
core/src/main/scala/org/apache/spark/ui/UIUtils.scala:
##
@@ -431,7 +431,7 @@ private[spark] object UIUtils extends Logging {
}
val headerRow: Seq[Node] = {
- headers.view.zipWithIndex.map { x =>
+ headers.to(LazyList).zipWithIndex.map { x =>
Review Comment:
When using Scala 2.12, it is lazy, so I prefer to use LazyList to restore
its lazy characteristics with Scala 2.13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up `SeqOps.view` and `ArrayOps.view` conversions [spark]
dongjoon-hyun commented on code in PR #44179:
URL: https://github.com/apache/spark/pull/44179#discussion_r1415952748
##
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Entropy.scala:
##
@@ -112,7 +112,7 @@ private[spark] class EntropyAggregator(numClasses: Int)
* @param offsetStart index of stats for this (node, feature, bin).
*/
def getCalculator(allStats: Array[Double], offset: Int): EntropyCalculator =
{
-new EntropyCalculator(allStats.view.slice(offset, offset + statsSize -
1).toArray,
+new EntropyCalculator(allStats.slice(offset, offset + statsSize - 1),
Review Comment:
This kind of simple replacements looks good definitely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up `SeqOps.view` and `ArrayOps.view` conversions [spark]
dongjoon-hyun commented on code in PR #44179:
URL: https://github.com/apache/spark/pull/44179#discussion_r1415950533
##
core/src/main/scala/org/apache/spark/ui/UIUtils.scala:
##
@@ -431,7 +431,7 @@ private[spark] object UIUtils extends Logging {
}
val headerRow: Seq[Node] = {
- headers.view.zipWithIndex.map { x =>
+ headers.to(LazyList).zipWithIndex.map { x =>
Review Comment:
Just a question. Is this better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
