Re: [PR] [SPARK-47080][CORE][TESTS] Fix `HistoryServerSuite` to use `constant value` and `getNumJobsRestful` [spark]
dongjoon-hyun closed pull request #45147: [SPARK-47080][CORE][TESTS] Fix `HistoryServerSuite` to use `constant value` and `getNumJobsRestful` URL: https://github.com/apache/spark/pull/45147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47080][CORE][TESTS] Fix `HistoryServerSuite` to use `constant value` and `getNumJobsRestful` [spark]
dongjoon-hyun commented on PR #45147: URL: https://github.com/apache/spark/pull/45147#issuecomment-1953568843 Thank you so much! Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47080][CORE][TESTS] Fix `HistoryServerSuite` to use `constant value` and `getNumJobsRestful` [spark]
dongjoon-hyun commented on PR #45147: URL: https://github.com/apache/spark/pull/45147#issuecomment-1953566286 This is a `core` module test PR and it's already passed. https://github.com/apache/spark/assets/9700541/a0cb80c9-8602-4529-b850-8169c0e455ed;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47080][CORE][TESTS] Fix `HistoryServerSuite` to use `constant value` and `getNumJobsRestful` [spark]
dongjoon-hyun commented on PR #45147: URL: https://github.com/apache/spark/pull/45147#issuecomment-1953565921 Could you review this PR, @LuciferYang ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47080][CORE][TESTS] Fix `HistoryServerSuite` to use `constant value` and `getNumJobsRestful` [spark]
dongjoon-hyun commented on PR #45147: URL: https://github.com/apache/spark/pull/45147#issuecomment-1953469006 Could you review this once more, @HyukjinKwon ? This is much robust than the AS-IS status and the test coverage is the same which means to verify the number of completed jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
