Re: [PR] [SPARK-47089][BUILD][TESTS] Migrate `mockito 4` to `mockito 5` [spark]
LuciferYang commented on PR #45158: URL: https://github.com/apache/spark/pull/45158#issuecomment-1953377423 late LGTM ~ thanks @panbingkun and @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47089][BUILD][TESTS] Migrate `mockito 4` to `mockito 5` [spark]
dongjoon-hyun commented on PR #45158: URL: https://github.com/apache/spark/pull/45158#issuecomment-1953024589 Merged to master for Apache Spark 4.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47089][BUILD][TESTS] Migrate `mockito 4` to `mockito 5` [spark]
dongjoon-hyun closed pull request #45158: [SPARK-47089][BUILD][TESTS] Migrate `mockito 4` to `mockito 5` URL: https://github.com/apache/spark/pull/45158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47089][BUILD][TESTS] Migrate `mockito 4` to `mockito 5` [spark]
panbingkun commented on code in PR #45158:
URL: https://github.com/apache/spark/pull/45158#discussion_r1494221573
##
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocatorSuite.scala:
##
@@ -124,10 +124,12 @@ class ExecutorPodsAllocatorSuite extends SparkFunSuite
with BeforeAndAfter {
when(podsWithNamespace.withName(driverPodName)).thenReturn(driverPodOperations)
when(podsWithNamespace.resource(any())).thenReturn(podResource)
when(podsWithNamespace.withLabel(anyString(),
anyString())).thenReturn(labeledPods)
-when(podsWithNamespace.withLabelIn(anyString(),
any())).thenReturn(labeledPods)
Review Comment:
https://github.com/apache/spark/assets/15246973/3240dfdb-52c7-4462-a343-8160a43a44bb;>
https://github.com/apache/spark/assets/15246973/5ea32a63-23c0-4f48-8e32-835ca0b603dc;>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47089][BUILD][TESTS] Migrate `mockito 4` to `mockito 5` [spark]
panbingkun commented on PR #45158: URL: https://github.com/apache/spark/pull/45158#issuecomment-1951993429 cc @dongjoon-hyun @LuciferYang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
