Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
HyukjinKwon closed pull request #45159: [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job URL: https://github.com/apache/spark/pull/45159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
HyukjinKwon commented on code in PR #45159: URL: https://github.com/apache/spark/pull/45159#discussion_r1494252065 ## .github/workflows/build_and_test.yml: ## @@ -790,7 +790,8 @@ jobs: maven-build: needs: precondition -if: fromJson(needs.precondition.outputs.required).maven-build == 'true' +# Skipped in branch-3.4, see SPARK-47090. +if: fromJson(needs.precondition.outputs.required).maven-build == 'true' && inputs.branch != 'branch-3.4' Review Comment: Ohh okie that's good then :-). Let me close this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
LuciferYang commented on code in PR #45159: URL: https://github.com/apache/spark/pull/45159#discussion_r1494228629 ## .github/workflows/build_and_test.yml: ## @@ -790,7 +790,8 @@ jobs: maven-build: needs: precondition -if: fromJson(needs.precondition.outputs.required).maven-build == 'true' +# Skipped in branch-3.4, see SPARK-47090. +if: fromJson(needs.precondition.outputs.required).maven-build == 'true' && inputs.branch != 'branch-3.4' Review Comment: https://github.com/apache/spark/actions/runs/7957014021  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
LuciferYang commented on code in PR #45159: URL: https://github.com/apache/spark/pull/45159#discussion_r1494228629 ## .github/workflows/build_and_test.yml: ## @@ -790,7 +790,8 @@ jobs: maven-build: needs: precondition -if: fromJson(needs.precondition.outputs.required).maven-build == 'true' +# Skipped in branch-3.4, see SPARK-47090. +if: fromJson(needs.precondition.outputs.required).maven-build == 'true' && inputs.branch != 'branch-3.4' Review Comment: https://github.com/apache/spark/actions/runs/7957014021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
LuciferYang commented on code in PR #45159: URL: https://github.com/apache/spark/pull/45159#discussion_r1494136868 ## .github/workflows/build_and_test.yml: ## @@ -790,7 +790,8 @@ jobs: maven-build: needs: precondition -if: fromJson(needs.precondition.outputs.required).maven-build == 'true' +# Skipped in branch-3.4, see SPARK-47090. +if: fromJson(needs.precondition.outputs.required).maven-build == 'true' && inputs.branch != 'branch-3.4' Review Comment: https://github.com/apache/spark/blob/c4e4497ff7e747eb71d087cdfb1b51673c53b83b/.github/workflows/build_branch34.yml#L43-L51 For daily build, `maven-build` is not true, and before https://github.com/apache/spark/pull/45148, the `apple-silicon` job was checking the value of `build` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
LuciferYang commented on code in PR #45159: URL: https://github.com/apache/spark/pull/45159#discussion_r1494136868 ## .github/workflows/build_and_test.yml: ## @@ -790,7 +790,8 @@ jobs: maven-build: needs: precondition -if: fromJson(needs.precondition.outputs.required).maven-build == 'true' +# Skipped in branch-3.4, see SPARK-47090. +if: fromJson(needs.precondition.outputs.required).maven-build == 'true' && inputs.branch != 'branch-3.4' Review Comment: https://github.com/apache/spark/blob/c4e4497ff7e747eb71d087cdfb1b51673c53b83b/.github/workflows/build_branch34.yml#L43-L51 For daily build, `maven-build` is not true, before https://github.com/apache/spark/pull/45148, the `apple-silicon` job was checking the value of `build` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
LuciferYang commented on code in PR #45159: URL: https://github.com/apache/spark/pull/45159#discussion_r1494133318 ## .github/workflows/build_and_test.yml: ## @@ -790,7 +790,8 @@ jobs: maven-build: needs: precondition -if: fromJson(needs.precondition.outputs.required).maven-build == 'true' +# Skipped in branch-3.4, see SPARK-47090. +if: fromJson(needs.precondition.outputs.required).maven-build == 'true' && inputs.branch != 'branch-3.4' Review Comment: hmm... I think after https://github.com/apache/spark/pull/45148, the daily job for branch-3.4 will no longer execute maven-build ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
LuciferYang commented on code in PR #45159: URL: https://github.com/apache/spark/pull/45159#discussion_r1494133318 ## .github/workflows/build_and_test.yml: ## @@ -790,7 +790,8 @@ jobs: maven-build: needs: precondition -if: fromJson(needs.precondition.outputs.required).maven-build == 'true' +# Skipped in branch-3.4, see SPARK-47090. +if: fromJson(needs.precondition.outputs.required).maven-build == 'true' && inputs.branch != 'branch-3.4' Review Comment: hmm... I think after https://github.com/apache/spark/pull/45148/files, the daily job for branch-3.4 will no longer execute maven-build ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
HyukjinKwon commented on code in PR #45159: URL: https://github.com/apache/spark/pull/45159#discussion_r1494123602 ## .github/workflows/build_and_test.yml: ## @@ -790,7 +790,8 @@ jobs: maven-build: needs: precondition -if: fromJson(needs.precondition.outputs.required).maven-build == 'true' +# Skipped in branch-3.4, see SPARK-47090. +if: fromJson(needs.precondition.outputs.required).maven-build == 'true' && inputs.branch != 'branch-3.4' Review Comment: Yeah we can do something more fine grained. I prefer to just take it out in branch-3.4 because compilation itself doesn't affect the Spark 3.4 releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
LuciferYang commented on code in PR #45159: URL: https://github.com/apache/spark/pull/45159#discussion_r1494118216 ## .github/workflows/build_and_test.yml: ## @@ -790,7 +790,8 @@ jobs: maven-build: needs: precondition -if: fromJson(needs.precondition.outputs.required).maven-build == 'true' +# Skipped in branch-3.4, see SPARK-47090. +if: fromJson(needs.precondition.outputs.required).maven-build == 'true' && inputs.branch != 'branch-3.4' Review Comment: Perhaps we can use a separate job to generate the content of `matrix` first? Although this might increase complexity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
LuciferYang commented on code in PR #45159: URL: https://github.com/apache/spark/pull/45159#discussion_r1494118216 ## .github/workflows/build_and_test.yml: ## @@ -790,7 +790,8 @@ jobs: maven-build: needs: precondition -if: fromJson(needs.precondition.outputs.required).maven-build == 'true' +# Skipped in branch-3.4, see SPARK-47090. +if: fromJson(needs.precondition.outputs.required).maven-build == 'true' && inputs.branch != 'branch-3.4' Review Comment: Perhaps we can use a separate job to generate the content of `java-matrix` first? Although this might increase complexity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
HyukjinKwon commented on code in PR #45159: URL: https://github.com/apache/spark/pull/45159#discussion_r1494022647 ## .github/workflows/build_and_test.yml: ## @@ -790,7 +790,8 @@ jobs: maven-build: needs: precondition -if: fromJson(needs.precondition.outputs.required).maven-build == 'true' +# Skipped in branch-3.4, see SPARK-47090. +if: fromJson(needs.precondition.outputs.required).maven-build == 'true' && inputs.branch != 'branch-3.4' Review Comment: cc @dongjoon-hyun do you have any preference on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47090][INFRA] Skip JDK 17/21 Maven compilation in branch-3.4 job [spark]
HyukjinKwon commented on code in PR #45159: URL: https://github.com/apache/spark/pull/45159#discussion_r1493969416 ## .github/workflows/build_and_test.yml: ## @@ -790,7 +790,8 @@ jobs: maven-build: needs: precondition -if: fromJson(needs.precondition.outputs.required).maven-build == 'true' +# Skipped in branch-3.4, see SPARK-47090. +if: fromJson(needs.precondition.outputs.required).maven-build == 'true' && inputs.branch != 'branch-3.4' Review Comment: I can add more condition, e.g., only skip JDK 21 in branch-3.5 and branch-3.4 if that's preferred -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
