Re: [PR] [SPARK-47093][TESTS] Upgrade `mockito` to 5.10.0 [spark]

2024-02-19 Thread via GitHub


dongjoon-hyun closed pull request #45169: [SPARK-47093][TESTS] Upgrade 
`mockito` to 5.10.0
URL: https://github.com/apache/spark/pull/45169


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-47093][TESTS] Upgrade `mockito` to 5.10.0 [spark]

2024-02-19 Thread via GitHub


dongjoon-hyun commented on PR #45169:
URL: https://github.com/apache/spark/pull/45169#issuecomment-1953372859

   At the last commit, `dev/connect-jvm-client-mima-check` passed too. Merged 
to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-47093][TESTS] Upgrade `mockito` to 5.10.0 [spark]

2024-02-19 Thread via GitHub


dongjoon-hyun commented on PR #45169:
URL: https://github.com/apache/spark/pull/45169#issuecomment-1953321258

   Although `connect-jvm-client-mima-check` works fine in local env, it is 
unable to find `scalatest-core_2.13-3.2.17.jar` in the CI.
   ```
   $ dev/connect-jvm-client-mima-check
   ...
   Using SPARK_LOCAL_IP=localhost
   Using SPARK_LOCAL_IP=localhost
   Do connect-client-jvm module mima check ...
   finish connect-client-jvm module mima check ...
   connect-client-jvm module mima check passed.
   ```
   
   ![Screenshot 2024-02-19 at 16 43 
35](https://github.com/apache/spark/assets/9700541/fbf4b51e-6276-423f-a89c-8811ce9c8c2b)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-47093][TESTS] Upgrade `mockito` to 5.10.0 [spark]

2024-02-19 Thread via GitHub


dongjoon-hyun commented on PR #45169:
URL: https://github.com/apache/spark/pull/45169#issuecomment-1953296605

   Thank you, @HyukjinKwon .
   
   BTW, `connect-jvm-client-mima-check` seems to have some issues. It passed 
locally but fails in GitHub Action. I'm looking at it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org