Re: [PR] [SPARK-47099][SQL] The `start` value of `paramIndex` for the error class `UNEXPECTED_INPUT_TYPE` should be `1` [spark]
panbingkun commented on PR #45177: URL: https://github.com/apache/spark/pull/45177#issuecomment-1954295467 > This `th` seems oddly: `1th` instead of `1st`, `2th` instead of `2nd`. > > How about to reuse the function: > > https://github.com/apache/spark/blob/fb1e7872a3e64eab6127f9c2b3ffa42b63162f6c/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala#L570-L574 > > > in the error message. Okay, I think it's great, let me do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47099][SQL] The `start` value of `paramIndex` for the error class `UNEXPECTED_INPUT_TYPE` should be `1` [spark]
MaxGekk commented on PR #45177: URL: https://github.com/apache/spark/pull/45177#issuecomment-1954163160 This `th` seems oddly: `1th` instead of `1st`, `2th` instead of `2nd`. How about to reuse the function: https://github.com/apache/spark/blob/fb1e7872a3e64eab6127f9c2b3ffa42b63162f6c/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala#L570-L574 in the error message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47099][SQL] The `start` value of `paramIndex` for the error class `UNEXPECTED_INPUT_TYPE` should be `1` [spark]
panbingkun commented on PR #45177: URL: https://github.com/apache/spark/pull/45177#issuecomment-1953713901 > Shall we make the error message more explicit? > > ``` > The th parameter requires the type, ... > ``` > > or something more accurate in English. cc @srielau How about the following error message? ``` The -th parameter of function requires the type, however has the type . ``` I found a reference: https://github.com/alibaba/sentinel-golang/blob/08071855bc67423777353c6e02f1390b419172b1/core/hotspot/rule.go#L79-L80 https://github.com/apache/spark/assets/15246973/07276789-15cd-4ad3-b2fd-4809671df1dc;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47099][SQL] The `start` value of `paramIndex` for the error class `UNEXPECTED_INPUT_TYPE` should be `1` [spark]
panbingkun commented on PR #45177: URL: https://github.com/apache/spark/pull/45177#issuecomment-1953690124 > > We should unify it and avoid understanding differences. > > I agree we should unify. BTW, did we document somewhere that param indexes are 1-based? How about this file? https://github.com/apache/spark/blob/f0f35c8b1c8f3b1d7f7c2b79945eb29ffb3c8f9a/common/utils/src/main/resources/error/README.md?plain=1 Add the following content at the end of this file? ``` ## Extra 1.The parameter paramIndex of error class `DATATYPE_MISMATCH.UNEXPECTED_INPUT_TYPE` is 1-based. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47099][SQL] The `start` value of `paramIndex` for the error class `UNEXPECTED_INPUT_TYPE` should be `1` [spark]
cloud-fan commented on PR #45177: URL: https://github.com/apache/spark/pull/45177#issuecomment-1953653971 Shall we make the error message more explicit? ``` The th parameter requires the type, ... ``` or something more accurate in English. cc @srielau -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47099][SQL] The `start` value of `paramIndex` for the error class `UNEXPECTED_INPUT_TYPE` should be `1` [spark]
panbingkun commented on PR #45177: URL: https://github.com/apache/spark/pull/45177#issuecomment-1953561931 cc @cloud-fan @MaxGekk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
