cloud-fan closed pull request #46040: [SPARK-47413][SQL] - add support to
substr/left/right for collations
URL: https://github.com/apache/spark/pull/46040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cloud-fan commented on PR #46040:
URL: https://github.com/apache/spark/pull/46040#issuecomment-2068657667
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
GideonPotok commented on PR #46040:
URL: https://github.com/apache/spark/pull/46040#issuecomment-2068213773
@uros-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
GideonPotok commented on PR #46040:
URL: https://github.com/apache/spark/pull/46040#issuecomment-2065859992
@uros-db I have made the suggested changes. please re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
GideonPotok commented on code in PR #46040:
URL: https://github.com/apache/spark/pull/46040#discussion_r1571898438
##
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##
@@ -425,6 +425,54 @@ class CollationStringExpressionsSuite
})
}
uros-db commented on code in PR #46040:
URL: https://github.com/apache/spark/pull/46040#discussion_r1571028944
##
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##
@@ -425,6 +425,54 @@ class CollationStringExpressionsSuite
})
}
+
uros-db commented on code in PR #46040:
URL: https://github.com/apache/spark/pull/46040#discussion_r1571030478
##
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##
@@ -425,6 +425,54 @@ class CollationStringExpressionsSuite
})
}
+
uros-db commented on code in PR #46040:
URL: https://github.com/apache/spark/pull/46040#discussion_r1571028944
##
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##
@@ -425,6 +425,54 @@ class CollationStringExpressionsSuite
})
}
+
GideonPotok closed pull request #45738: [SPARK-47413][SQL] - add support to
substr/left/right for collations
URL: https://github.com/apache/spark/pull/45738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
GideonPotok commented on PR #45738:
URL: https://github.com/apache/spark/pull/45738#issuecomment-2053959041
@ur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
uros-db commented on PR #45738:
URL: https://github.com/apache/spark/pull/45738#issuecomment-2048962946
@GideonPotok You are correct, this refactor should not greatly affect your
current PR in particular - I expect you'll only need to refactor testing a bit
(shouldn't be too much work)
GideonPotok commented on PR #45738:
URL: https://github.com/apache/spark/pull/45738#issuecomment-2048944931
PS: Do you think changes, such as these, which are only to implementations
of `inputTypes` and `replacement`, which do not rely on calling UTFString or
CollationFactory, will need to
GideonPotok commented on PR #45738:
URL: https://github.com/apache/spark/pull/45738#issuecomment-2048941620
@uros-db No problem at all.
if I understand your refactor correctly, my changes will basically either
stay in the same place or move to the new
uros-db commented on PR #45738:
URL: https://github.com/apache/spark/pull/45738#issuecomment-2048923852
@GideonPotok nice work, thanks!
Heads up though: we will soon be finishing some code refactoring related to
collation-aware string expression support
GideonPotok commented on PR #45738:
URL: https://github.com/apache/spark/pull/45738#issuecomment-2048919774
@uros-db this is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
GideonPotok commented on PR #45738:
URL: https://github.com/apache/spark/pull/45738#issuecomment-2047328959
@uros-db I got the file-writing tests to work locally when I simply `export
SPARK_HOME=/Users/gideon/repos/spark` prior to running my maven tests.
More importantly, All GHA
GideonPotok commented on PR #45738:
URL: https://github.com/apache/spark/pull/45738#issuecomment-2046941212
> I don't think `CSVLegacyTimeParserSuite` is related to you, but it would
probably be a very good idea to setup Maven so that you can run/debug all tests
locally in general
uros-db commented on PR #45738:
URL: https://github.com/apache/spark/pull/45738#issuecomment-2046875237
I don't think `CSVLegacyTimeParserSuite` is related to you, but it would
probably be a very good idea to setup Maven so that you can run/debug all tests
locally in general
--
This is
GideonPotok commented on PR #45738:
URL: https://github.com/apache/spark/pull/45738#issuecomment-2046822456
> did you try to run this suite locally and investigate any potential issues?
@uros-db I would love to. I need to fix my setup though, first -- there is
an issue I have been
GideonPotok commented on PR #45738:
URL: https://github.com/apache/spark/pull/45738#issuecomment-2045605623
@uros-db this would be ready for review but spark sql unit tests repeatedly
fail for CSVLegacyTimeParserSuite, which I did not modify. I have reran it a
total of four times. Any idea
20 matches
Mail list logo
