Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-24 Thread via GitHub
cloud-fan closed pull request #46077: [SPARK-47414][SQL] Lowercase collation support for regexp expressions URL: https://github.com/apache/spark/pull/46077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-24 Thread via GitHub
cloud-fan commented on PR #46077: URL: https://github.com/apache/spark/pull/46077#issuecomment-2076353598 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-24 Thread via GitHub
uros-db commented on code in PR #46077: URL: https://github.com/apache/spark/pull/46077#discussion_r1577746735 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ## @@ -158,7 +162,9 @@ case class Like(left: Expression, right:

Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-24 Thread via GitHub
uros-db commented on code in PR #46077: URL: https://github.com/apache/spark/pull/46077#discussion_r1577746005 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ## @@ -1161,7 +1186,8 @@ object RegExpUtils { | // regex

Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-24 Thread via GitHub
cloud-fan commented on code in PR #46077: URL: https://github.com/apache/spark/pull/46077#discussion_r1577453813 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ## @@ -158,7 +162,9 @@ case class Like(left: Expression, right:

Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-24 Thread via GitHub
cloud-fan commented on code in PR #46077: URL: https://github.com/apache/spark/pull/46077#discussion_r1577451945 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ## @@ -543,25 +555,29 @@ case class RLike(left: Expression, right:

Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-24 Thread via GitHub
cloud-fan commented on code in PR #46077: URL: https://github.com/apache/spark/pull/46077#discussion_r1577452915 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ## @@ -1161,7 +1186,8 @@ object RegExpUtils { | // regex

Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-24 Thread via GitHub
cloud-fan commented on code in PR #46077: URL: https://github.com/apache/spark/pull/46077#discussion_r1577449341 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ## @@ -475,7 +485,8 @@ case class RLike(left: Expression, right:

Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-24 Thread via GitHub
cloud-fan commented on code in PR #46077: URL: https://github.com/apache/spark/pull/46077#discussion_r1577448459 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ## @@ -186,7 +192,8 @@ case class Like(left: Expression, right:

Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-24 Thread via GitHub
cloud-fan commented on code in PR #46077: URL: https://github.com/apache/spark/pull/46077#discussion_r1577446659 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ## @@ -158,7 +162,9 @@ case class Like(left: Expression, right:

Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-19 Thread via GitHub
nikolamand-db commented on code in PR #46077: URL: https://github.com/apache/spark/pull/46077#discussion_r1572379229 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollationRegexpExpressionSuite.scala: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the

Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-19 Thread via GitHub
uros-db commented on code in PR #46077: URL: https://github.com/apache/spark/pull/46077#discussion_r1572369335 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollationRegexpExpressionSuite.scala: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache

Re: [PR] [SPARK-47414][SQL] Lowercase collation support for regexp expressions [spark]

2024-04-19 Thread via GitHub
nikolamand-db commented on code in PR #46077: URL: https://github.com/apache/spark/pull/46077#discussion_r1572342093 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollationRegexpExpressionSuite.scala: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the