Re: [PR] [SPARK-48011][Core] Store LogKey name as a value to avoid generating new string instances [spark]

[via GitHub]

LuciferYang commented on PR #46249:
URL: https://github.com/apache/spark/pull/46249#issuecomment-2081298871

   late LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Re: [PR] [SPARK-48011][Core] Store LogKey name as a value to avoid generating new string instances [spark]

[via GitHub]

panbingkun commented on PR #46249:
URL: https://github.com/apache/spark/pull/46249#issuecomment-2080233200

   Great!
   +1, LGTM. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Re: [PR] [SPARK-48011][Core] Store LogKey name as a value to avoid generating new string instances [spark]

[via GitHub]

dongjoon-hyun closed pull request #46249: [SPARK-48011][Core] Store LogKey name 
as a value to avoid generating new string instances
URL: https://github.com/apache/spark/pull/46249


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Re: [PR] [SPARK-48011][Core] Store LogKey name as a value to avoid generating new string instances [spark]

[via GitHub]

gengliangwang commented on PR #46249:
URL: https://github.com/apache/spark/pull/46249#issuecomment-2079860587

   cc @panbingkun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Re: [PR] [SPARK-48011][Core] Store LogKey name as a value to avoid generating new string instances [spark]

[via GitHub]

gengliangwang commented on code in PR #46249:
URL: https://github.com/apache/spark/pull/46249#discussion_r1581359491


##
common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala:
##
@@ -16,10 +16,14 @@
  */
 package org.apache.spark.internal
 
+import java.util.Locale
+
 /**
  * All structured logging `keys` used in `MDC` must be extends `LogKey`
  */
-trait LogKey
+trait LogKey {
+  val name: String = this.toString.toLowerCase(Locale.ROOT)

Review Comment:
   We can also make it `lazy val` here. I am not sure if the cost will be 
eventually higher. I suggest keeping it simple for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org