Re: [PR] make readme easier to follow [spark-connect-go]
MrPowers commented on code in PR #18: URL: https://github.com/apache/spark-connect-go/pull/18#discussion_r1560029954 ## README.md: ## @@ -13,33 +12,42 @@ project reserves the right to withdraw and abandon the development of this proje if it is not sustainable. ## Getting started + +This section explains how to run Spark Connect Go locally. + +Step 1: Install Golang: https://go.dev/doc/install. + +Step 2: Ensure you have installed `buf CLI` installed, [more info here](https://buf.build/docs/installation/) + +Step 3: Run the following commands to setup the Spark Connect client. + ``` git clone https://github.com/apache/spark-connect-go.git git submodule update --init --recursive make gen && make test ``` -> Ensure you have installed `buf CLI`; [more info](https://buf.build/docs/installation/) -## How to write Spark Connect Go Application in your own project +Step 4: Setup the Spark Driver on localhost. -See [Quick Start Guide](quick-start.md) +1. [Download Spark distribution](https://spark.apache.org/downloads.html) (3.4.0+), unzip the package. -## Spark Connect Go Application Example +2. Start the Spark Connect server with the following command: Review Comment: @grundprinzip - updated this language, good suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] make readme easier to follow [spark-connect-go]
grundprinzip commented on code in PR #18: URL: https://github.com/apache/spark-connect-go/pull/18#discussion_r1559883957 ## README.md: ## @@ -13,33 +12,42 @@ project reserves the right to withdraw and abandon the development of this proje if it is not sustainable. ## Getting started + +This section explains how to run Spark Connect Go locally. + +Step 1: Install Golang: https://go.dev/doc/install. + +Step 2: Ensure you have installed `buf CLI` installed, [more info here](https://buf.build/docs/installation/) + +Step 3: Run the following commands to setup the Spark Connect client. + ``` git clone https://github.com/apache/spark-connect-go.git git submodule update --init --recursive make gen && make test ``` -> Ensure you have installed `buf CLI`; [more info](https://buf.build/docs/installation/) -## How to write Spark Connect Go Application in your own project +Step 4: Setup the Spark Driver on localhost. -See [Quick Start Guide](quick-start.md) +1. [Download Spark distribution](https://spark.apache.org/downloads.html) (3.4.0+), unzip the package. -## Spark Connect Go Application Example +2. Start the Spark Connect server with the following command: Review Comment: ```suggestion 2. Start the Spark Connect server with the following command (make sure to use a package version that matches your Spark distribution): ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] make readme easier to follow [spark-connect-go]
nkarpov commented on PR #18: URL: https://github.com/apache/spark-connect-go/pull/18#issuecomment-2048055764 nice I like it. I got tripped up bouncing between readme & quick start as a newbie. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org