Re: Progress package

2018-11-27 Thread Pierre de Villemereuil
Hi, > looks fine to me. but is there a reason why line 53 ends > > ... r_app_stdx(stream)) || rkward_stdx(stream) > > instead of > > ... r_app_stdx(stream) || rkward_stdx(stream)) > > ? There is none whatsoever, good catch! (Precisely the kind of safe-guard I was looking for! ^^) Thank

Re: Progress package

2018-11-27 Thread meik michalke
hi, Am Dienstag, 27. November 2018, 16:28:42 CET schrieb Pierre de Villemereuil: > If you have time to look at this PR regarding this issue with the "progress" > package and tell me if you see anything wrong, I'd be grateful: > https://github.com/r-lib/progress/pull/7

Re: Progress package

2018-11-27 Thread Pierre de Villemereuil
Hi all, If you have time to look at this PR regarding this issue with the "progress" package and tell me if you see anything wrong, I'd be grateful: https://github.com/r-lib/progress/pull/76 Cheers, Pierre. Le Saturday, 3 November 2018, 17:48:43 CET Thomas Friedrichsmeier a éc

Re: Progress package

2018-11-03 Thread Pierre de Villemereuil
It seems to work indeed. I'll try to implement something for progress based on this... when I have the time! ;) Cheers, Pierre Le samedi 3 novembre 2018, 13:43:18 CET meik michalke a écrit : > Am Samstag, 3. November 2018, 13:04:44 CET schrieb Pierre de Villemereuil: > > The dev is asking

Re: Progress package

2018-11-03 Thread meik michalke
Am Samstag, 3. November 2018, 13:04:44 CET schrieb Pierre de Villemereuil: > The dev is asking whether there is a way to detect RKWard. Is there? how about this: "rkward" %in% (.packages()) RKWard loads its own R package which is also not available without RKWard, so when an R package called

Re: Progress package

2018-11-03 Thread Pierre de Villemereuil
The dev is asking whether there is a way to detect RKWard. Is there? If so, I might be able to submit a PR to "progress". At least, I'll try... Cheers, Pierre. Le samedi 3 novembre 2018, 09:49:38 CET Pierre de Villemereuil a écrit : > Yes, Thomas you are right. I see it correctly when using

Re: Progress package

2018-11-03 Thread Pierre de Villemereuil
Yes, Thomas you are right. I see it correctly when using force = TRUE. I've submitted a bug report there: https://github.com/r-lib/progress/issues/74 I'm going to mention this. Cheers, Pierre. Le samedi 3 novembre 2018, 09:07:39 CET Thomas Friedrichsmeier a écrit : > Hi, > > On Fri, 02 Nov

Re: Progress package

2018-11-03 Thread Thomas Friedrichsmeier
Hi, On Fri, 02 Nov 2018 23:42:40 +0100 meik michalke wrote: > without looking at any of the code of the package, the precise list > of applications where the package will run to me reads like it needed > special implementation to reach that goal. so it probably checks its > environment to decide

Re: Progress package

2018-11-02 Thread Thomas Friedrichsmeier
Hi, On Fri, 02 Nov 2018 21:26:57 +0100 Pierre de Villemereuil wrote: > Is there any reason why the "progress" package doesn't display > progress bars in RKWard? I have not quite figured out the details, but essentially: It doesn't want to display the bar, because it thinks it

Progress package

2018-11-02 Thread Pierre de Villemereuil
Hi, Is there any reason why the "progress" package doesn't display progress bars in RKWard? E.g. this code: library(progress) pb <- progress_bar$new(total = 100) f <- function() { pb$tick(0) Sys.sleep(3) for (i in 1:100) { pb$tick() Sys.sleep(1