Fr Aug 27 2010 14:58:06 EDT von IGnatius T Foobar @ Uncensored Betreff: Re: Git?
I'm reading some documentation and tutorials on git, and it looks like something that's only useful for developing the Linux kernel ... essentially not the right tool for a project like ours that relies on a
15:10 CIA-37: citadel: dothebart * r8892 citadel/ (13 files in 8 dirs): * do typedef the visit struct, remove all those 'struct' statements from all over the source15:11 CIA-37: citadel: dothebart * r8893 citadel/user_ops.c: * fix GTSN not to cut seen stats at 1024 chars
(somehow no svn commit
20:14 CIA-37: citadel: dothebart * r8894 webcit/tcp_sockets.c: * moan, if somebody didn't read the full buffer.
(commit messages broken?)
so, everyone listen up.
if you see a 'Suppenkasper alert' some part of webcit didn't read all citserver told him.
so if you see it, please bust down the
ok, you have all been saved from a flood of commits because of the missing commitmails ;-)
The old "template engine' as we knew it up to 7.50 is gone by now.
in the some rare situations where there realy has to be an anonymous string in some kind to be transported, this is done via the array
18:57 CIA-37: citadel: dothebart * r8911 webcit/ (serv_func.c static/t/aide/siteconfig/tab_directory.html): * LDAP wasn't exposed that way for a long time; TODO: does this way still represent the reality with the new ldap support?
Re: we had these in tab_directory.html:
hm, ok, i'd say its the line between header and body which is breaking our neck here.
could you please reassure, that the last line of those messages being written to citserver is the last line of the email-header?
for example .4
X-Evolution-Source: imap://some...@somewhereplace.com/
or in .3:
Sorry about the delay in getting these logs... Had my workstation decide to melt down (or at least the CPU, literally... thankfully Intel has a 3 year warranty...)
Logs are attached. At the end of foolog_IMAPS.3 and foolog_IMAPS.4 it appears that we might (and I stress might, because I have no
Ok, we're switching to git. I remain ambivalent about the subject, but since
it is in high demand I will go with the flow here.
My needs are simple ... even CVS worked just fine for me.
Our source code repository will be offline until the conversion is complete.
Mon Aug 30 2010 1:58:38 pm EDT EDT from IGnatius T Foobar @ Uncensored Subject: Re: Git?
Ok, we're switching to git. I remain ambivalent about the subject, but since it is in high demand I will go with the flow here. My needs are simple ... even CVS worked just fine for me. Our source
Sat Aug 28 2010 10:06:18 am EDT EDT from dothebart @ Uncensored
15:10 CIA-37: citadel: dothebart * r8892 citadel/ (13 files in 8 dirs): * do typedef the visit struct, remove all those 'struct' statements from all over the source15:11 CIA-37: citadel: dothebart * r8893
Files: ba45f305814cd6c8a8ddb0f2a66dc2e165b191bc libcitadel/README.txt
test commit three of three
From: Art Cancro a...@citadel.org
To: room_citadel_development@uncensored.citadel.org
Subject: Commit log befac91a7877128ef5557d28fc6db5b2eee6d5a8
Content-type: text/plain
Files: befac91a7877128ef5557d28fc6db5b2eee6d5a8 citadel/README.txt
Merged: befac91a7877128ef5557d28fc6db5b2eee6d5a8
Another
Files: 068ab5b237fb474b63bf632323aa291f6a3fc251
citadel/scripts/mk_svn_revision.sh
Modified mk_svn_revision.sh so that it doesn't barf when git is in use. Someone
already tried to handle this situation but it was b0rken. Fixed.
ok, since our SVN is unavailable, and our Git is still maturizing, this is the fix for our imaps-blob-uploading issue.
So Aug 29 2010 18:32:54 EDT von dothebart @ Uncensored Betreff: Re: Unusual SSL behavior, likely bug
So Aug 29 2010 17:19:14 EDT von dothebart @ Uncensored Betreff:
Files: e95b72590a3439af45746643aadce2d2ec980c3f
citadel/scripts/mk_svn_revision.sh
Another attempt at fixing svn_revision for git
Sat Aug 28 2010 10:06:18 am EDT EDT from dothebart @ Uncensored
15:10 CIA-37: citadel: dothebart * r8892 citadel/ (13 files in 8 dirs): * do typedef the visit struct, remove all those 'struct' statements from all over the source15:11 CIA-37: citadel: dothebart * r8893
The command
./buildpackages debian
will rename the current directory and create a symlink to the old one.
This breaks git; "it knows", and some commands like "git blame" then think the files aren't checked in yet (although git diff works).
I always thought a build script renaming managed
Scanios, can you re-test with current git trunk?
TIA.
Mo Aug 30 2010 17:34:25 EDT von dothebart @ Uncensored Betreff: Re: Unusual SSL behavior, likely bug
ok, since our SVN is unavailable, and our Git is still maturizing, this is the fix for our imaps-blob-uploading issue.
So Aug 29 2010
Wed Sep 01 2010 6:14:03 am EDT EDT from samjam @ Uncensored Subject: Re: macro "strncmp" requires 3 arguments, but only 2 given
Wed Sep 01 2010 6:06:48 am EDT EDT from dothebart @ Uncensored Subject: Re: macro "strncmp" requires 3 arguments, but only 2 given
HKEY is a macro that
Files: 8ecfb6d56ffd074f0371e77b72361306b8f88465
citadel/scripts/mk_svn_revision.sh
Yet another attempt at pushing my citadel/scripts/mk_svn_revision.sh changes to
the stable-78x branch
somebody should watch compiler warnings?
serv_extensions.c: In function ‘CtdlRegisterServiceHook’:serv_extensions.c:772: warning: attempt to free a non-heap object ‘error’gcc -I/var/lib/citadel -Wall -g -O0 -ggdb -rdynamic -D_GNU_SOURCE -MD -MP -D TECH_PREVIEW -D BIGBAD_IODBG -Wall -Wcast-qual
Wed Sep 01 2010 5:39:34 am EDT EDT from dothebart @ Uncensored Subject: Re: Unusual SSL behavior, likely bug
Scanios, can you re-test with current git trunk?
TIA.
Mo Aug 30 2010 17:34:25 EDT von dothebart @ Uncensored Betreff: Re: Unusual SSL behavior, likely bug
ok, since our SVN
So Aug 29 2010 17:19:14 EDT von dothebart @ Uncensored Betreff: Re: Unusual SSL behavior, likely bug
hm, ok, i'd say its the line between header and body which is breaking our neck here.
could you please reassure, that the last line of those messages being written to citserver is the last
Files: 55b9670ad840bb05b02b29bbc13ae87803bb8b27
citadel/scripts/mk_svn_revision.sh
Oops, my svn/git autodetection logic is still broken. Fixed. (cherry picked
from commit ea36c3b92b59412eb3d74ab248f2c371d254dc06)
That's great! Absolutely great! I can now use webcit to view
mailboxes with thousands of messages. Also, lately I've notice
everything much faster! I don't know if my vhoster has moved me to
better hardware or if citadel has just got lots better.
I can confirm that it is in fact
Files: a44f2cb84cd0f701f04dc85b231bd3c6e9bc9be5 citadel/user_ops.c
branches config description git-daemon-export-ok HEAD hooks info objects
packed-refs refs fix GTSN not to cut seen stats at 1024 chars (cherry picked
from commit e766e2c6d4bfa8ebce17ca3039963a3761fd3e8f)
Files: 0e718c0f851ef9899b07d6faff6b8da7cf0145b4 citadel/textclient/screen.c
removed unused stubs from screen.c
Files: 23864da393aaac9750d354a01165b909f839c612 webcit/Makefile.in
webcit/bootstrap
removed more Id tags from webcit
Files: 2f8f3ead31bd33675ca2820592ce489891883bf4 citadel/.svnignore
ctdlphp/.svnignore webcit/.svnignore
remove .svnignore files
Files: b989292a7afcead8c51272895aab029df9213067 citadel/textclient/citadel.c
citadel/textclient/commands.c citadel/textclient/screen.c
citadel/textclient/screen.h
Removed more vestiges of curses mode
Files: b23a74210ae96ab36961099b39fad1f825b9 citadel/textclient/screen.c
remove scr_putc(). who uses this anyways?
Files: 85cd8b9e5c9f2d78fdec3f9ab8ad8570753849a9 citadel/debian/changelog
libcitadel/debian/changelog webcit/debian/changelog
branches config description git-daemon-export-ok HEAD hooks info objects
packed-refs refs set 7.84 version
Files: 05819406b11fc0508d1e1762df495e02bda64db0 libcitadel/configure.in
libcitadel/lib/libcitadel.h
libcitadel to 7.84
Files:
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Files: 9022f0446ec957ea7789e1e1c135d687d4d36b6b citadel/textclient/citadel.c
citadel/textclient/screen.c
The new paginator now makes use of the server-supplied prompt.
Files:
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Files: ea36c3b92b59412eb3d74ab248f2c371d254dc06
citadel/scripts/mk_svn_revision.sh
Oops, my svn/git autodetection logic is still broken. Fixed.
Files: e0233091b3bd706bd0623388e901aaa89fdf4741 citadel/room_ops.c
CtdlRoomAccess() now returns a set of read-only access rights if the room is
BASEROOM (Lobby) and the user is not logged in.
Files: b636c80b9eebc34e5c591a4c64edb82ce31b31d4 citadel/room_ops.c
All of the cmd_lXXX (list rooms) commands are now set to require access level
ac_logged_in_or_guest
Files: 9eeafab393529f191a766d7e5f63c033588f972f citadel/room_ops.c
Ouch. CtdlRoomAccess() had a couple of places where it was checking 'the
current user' or 'the current room' instead of the user/room supplied by the
caller. Fixed.
Files: de7dd17a266af8e7a41a6ca5b3d66bb1a2760fea citadel/room_ops.c
Further hacks to CtdlRoomAccess() to support guest mode
Files: d553a5a769d887029c43dc5e1bc80664be0f8dd7 citadel/msgbase.c
citadel/room_ops.c
Allow MSGS command to operate in guest mode.
Files: b8eb22f8c5935a353f8ea6d6918d14de1830357b citadel/msgbase.c
cmd_msg*() now work properly in guest mode. This completes the minimum required
functionality for an anonymous guest client to traverse public rooms and read
messages.
Files: 0b6cb30155e5bebe5d5f7035151569c2d1e06366 libcitadel/lib/libcitadel.h
Uncomment 'not yet implemented' next to BLOG_VIEW in libcitadel.h
Mi Sep 01 2010 05:34:55 EDT von samjam @ Uncensored Betreff: Re:
Sat Aug 28 2010 10:06:18 am EDT EDT from dothebart @ Uncensored
15:10 CIA-37: citadel: dothebart * r8892 citadel/ (13 files in 8 dirs): * do typedef the visit struct, remove all those 'struct' statements from all
Files: 2f53e640f180d82fa5b06d29083df890b807b7ca webcit/paramhandling.c
Remove HKEY from call to strncmp so that it compiles.
Ignore that patch; I have one that fixes all 3 projects - otherwise they fail to build properly with symlink loops and the like
c_port_number is used in ./server_main.c to listen on, but never set anywhere.
./server_main.c listens on port 0 when it runs this line:
CtdlRegisterServiceHook(config.c_port_number,So hows that ever supposed to work?
It's been suggested that I re-run "setup" but it doesn't seem to know any of
AJC, I note that you have just added
VIEW_BLOG = 9, /* Blog view (not yet implemented) */but I remind you that 9 was used for VIEW_DRAFTS before it was disabled, and many of my uses already have such rooms.
I'm just doing fixes for drafts anyway (so I noticed this) - please
Sat Sep 04 2010 8:54:39 am EDT EDT from samjam @ Uncensored Subject: Re: What happened to c_port_number?
Nope, still broken - re-installing the (new) debs, breaks it again and knocks the config back again
setup -q is the culprit,
after "setup" my ip address is 0.0.0.0, after setup -q
Files: 348c6acf5f481614e88c74cc19e9a04083ff92f0 citadel/euidindex.c
citadel/user_ops.c webcit/static/t/edit_message.html
webcit/static/t/view_message.html
branches config description git-daemon-export-ok HEAD hooks info objects
packed-refs refs re-enable drafts as proposed by samjam.
So Sep 05 2010 14:32:59 EDT von "Wilfried Goesgens" dotheb...@citadel.org Betreff: Commit log to refs/heads/master
Files: 348c6acf5f481614e88c74cc19e9a04083ff92f0 citadel/euidindex.c citadel/user_ops.c webcit/static/t/edit_message.html webcit/static/t/view_message.html branches config
afair IG disabled it because of it was getting late to get a 7.60 release out; maybe the history of this room of that time shows a more detailed reason. I think some of the concepts weren't all clean yet; probably when that 'save to drafts' button should be shown and when not; or, what to do
Mon Sep 06 2010 5:11:39 am EDT EDT from samjam @ Uncensored Subject: Re: Fw: [PATCH] Fake the old version number for the paths inside the tar files
Sun Sep 05 2010 2:24:33 pm EDT EDT from dothebart @ Uncensored Subject: Re: Fw: [PATCH] Fake the old version number for the paths
Sun Sep 05 2010 2:44:51 pm EDT EDT from dothebart @ Uncensored Subject: Re: Fw: [PATCH] Re-enable drafts
afair IG disabled it because of it was getting late to get a 7.60 release out; maybe the history of this room of that time shows a more detailed reason. I think some of the concepts
The symlink loop occurs when this line is executed:
ln -sf libcitadel libcitadel-7.83cd libcitadel-7.83
if libcitadel-7.83 is already a symlink pointing to libcitadel - so the symlink get's made inside libcitadel. The -f option doesn't have the desired effect if the pre-existing symlink target
Fix typo that prevent message summary from working
---
webcit/static/t/mailsummary_json.html |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/webcit/static/t/mailsummary_json.html b/webcit/static/t/mailsummary_json.html
index 9bf68eb..2e3a749 100644
---
Helps for:
./buildpackes debian src
and
./buildpackages sourcedist
Also prevent the symlink from being created inside the target
if the symlink already exists and points to the target
---
citadel/buildpackages| 16
libcitadel/buildpackages | 15 ---
Mon Sep 06 2010 7:12:03 am EDT EDT from samjam @ Uncensored Subject: Re: Fw: [PATCH] Fake the old version number for the paths inside the tar files
The symlink loop occurs when this line is executed:
ln -sf libcitadel libcitadel-7.83cd libcitadel-7.83
if libcitadel-7.83 is already a
citadel still lets a logged in user read messages belonging to any other user.
test:
login as yourself, and try MSG4 with arbitrary message-numbers.
I think Art proposed a fix which would be to cause the MSG* functions to make sure that the requested message was in the current room
Sun Sep 05 2010 2:44:51 pm EDT EDT from dothebart @ Uncensored Subject: Re: Fw: [PATCH] Re-enable drafts
afair IG disabled it because of it was getting late to get a 7.60 release out; maybe the history of this room of that time shows a more detailed reason. I think some of the concepts
Ok folks, commit 8f713e8bba92ebb93a9a486d81ec7e966583fd9e in branch stable-78x
is the official 7.84 release of all components. tarballs have been built
and uploaded.
Allow save-to-drafts without recipients
---
citadel/msgbase.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
Still need to read X-Citadel-Room when resuming from draftsdiff --git a/citadel/msgbase.c b/citadel/msgbase.c
index cd4fd5e..d7f832a 100644
---
Mon Sep 06 2010 11:11:50 am EDT EDT from IGnatius T Foobar @ Uncensored
Ok folks, commit 8f713e8bba92ebb93a9a486d81ec7e966583fd9e in branch stable-78x is the official 7.84 release of all components. tarballs have been built and uploaded.
Did you push?
Sam
I there a way to automaticaly push such a commit mail?
Mo Sep 06 2010 08:06:28 EDT von samjam @ Uncensored Betreff: [PATCH] Allow save-to-drafts without recipients
Allow save-to-drafts without recipients
--- citadel/msgbase.c |9 + 1 files changed, 5 insertions(+), 4
Yes I did, but it has not been implemented.
*gna* git-am doesn't speak imap.
now I need to set up some fetchmail to retrieve patches into a maildir? st00pit shit.
Mo Sep 06 2010 16:01:19 EDT von dothebart @ Uncensored Betreff: Re: [PATCH] Allow save-to-drafts without recipients
I there a way to automaticaly push such a commit mail?
Sorry about posting the status line stuff in Citadel Support. I feel sort
of foolish in thinking that was stable code. My error for not checking as
much as I should have.
If you need a Mac for testing, I'd be willing to give you access to mine
if that's easier. I've been around here long
Files: 149c6ffe8db1f96a3bcd9403d4bd8804e439b9f4 webcit/serv_func.c
webcit/webcit.h
ServInfo now learns whether the server supports guest mode. Removed the
moreprompt from here because it's not used in webcit.
Sep 3 2010 10:23am from Art Cancro a...@citadel.org to
room_citadel_development@uncensored.citadel.org
Subject: Commit log refs/heads/master
Files: b6938b71c266f458180103090af0ab72e3d9616c citadel/citadel.h
citadel/include/dtds/user-defs.h
citadel/textclient/citadel.c
Files: ae1b7a3a9531d8be10de6e0ea9c79230fc7afb9c citadel/user_ops.c
cmd_invt_kick() is normally permitted when the room namespace matches the user
number because it means the user owns the room. Disable this when the namespace
happens to be 0.
Files:
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Files: 6890b64dae56f05982f83218da6478d6d302fa8e .gitignore
branches config description git-daemon-export-ok HEAD hooks info objects
packed-refs refs asterisks...
Di Sep 07 2010 17:01:12 EDT von "Wilfried Goesgens" dotheb...@citadel.org Betreff: Commit log to refs/heads/master
Files: Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
hm, pushing multiple revisions produces broken commit mails.
Wed Sep 08 2010 4:33:02 am EDT EDT from dothebart @ Uncensored
MS-RFC-Violator uses the timestamp when it polled the messages from citadel via imap to show and sort them? WTF?
Do you mean that that is how it finds new messages?
Mi Sep 08 2010 06:04:06 EDT von samjam @ Uncensored Betreff: Re:
Wed Sep 08 2010 4:33:02 am EDT EDT from dothebart @ Uncensored
MS-RFC-Violator uses the timestamp when it polled the messages from citadel via imap to show and sort them? WTF?
Do you mean that that is how it finds
Personally I use the terminal as much as I use the GUI. I wish they
would lose the mach kernel one day though. I'd love to see OS X be
based on straight *BSD.
Let me get something clear, then ... was your trouble report involving the
Terminal application or the console? Is there
Just curious - if additional information (for a plugin, etc.) needs to
be added to a user's profile, what is the best way to accomplish that
w/o modifying internal structures? This information would need to be
secure from modification by the end user.
What I normally do is
Sun Sep 05 2010 2:24:33 pm EDT EDT from dothebart @ Uncensored Subject: Re: Fw: [PATCH] Fake the old version number for the paths inside the tar files
hm,
did you run that script in advance?
since its not clever to rename subdirectories (citadel/ to citadel-7.83) in a git workingcopy
It would be much easier, but I can't guarantee exactly when I'm going to have
the chance to work on it.
Ok. I'm trying to get a Hackintosh running under VMware but so far I
am having some trouble.
and you will continue to for a very very long time.
I found one exactly ONE image that worked, and it was an exsiting install,
you can't install it yourself.
And the downside is, it's
Files: 7f5c03bd732302f360f6840f0d815ad3e644416d webcit/po/da.po webcit/po/de.po
webcit/po/en_GB.po webcit/po/es.po webcit/po/et_EE.po webcit/po/fr.po
webcit/po/hu.po webcit/po/it.po webcit/po/nl.po webcit/po/pt_BR.po
webcit/po/ru.po webcit/po/webcit.pot webcit/siteconfig.c
Files: 21a8456c6011dc185f2cc38640c713e9c62e696f webcit/feed_generator.c
If a webcit user is logged in and loads the RSS feed for a room, don't destroy
the session.
Files: 267e2b83ceee867d7bd1ebc4c48cff530e5cb35a webcit/bbsview_renderer.c
Found a comment in bbsview_renderer.c which made a reference to a particular
svn revision. Changed it to the matching git commit hash.
hm,
did you run that script in advance?
since its not clever to rename subdirectories (citadel/ to citadel-7.83) in a git workingcopy (and symlink citadel/ to it), I instead made it create the symlink to the citadel directory.
If you already have it the other way arround, it won't work for you
Fr Sep 10 2010 10:35:26 EDT von samjam @ Uncensored Betreff: Edit drafts, was Re: others messages
Fri Sep 10 2010 9:51:16 am EDT EDT from dothebart @ Uncensored Subject: Edit drafts, was Re: others messages
Fr Sep 10 2010 08:32:44 EDT von samjam @ Uncensored Betreff: Edit
Files: 27894d501e017e45172cae54097693b46bce86c4 webcit/Makefile.in
webcit/sitemap.c webcit/webcit.h
Sitemaps!
Fr Sep 10 2010 11:28:58 EDT von samjam @ Uncensored Betreff: Edit drafts, was Re: others messages
Fri Sep 10 2010 11:15:23 am EDT EDT from dothebart @ Uncensored Subject: Edit drafts, was Re: others messages
Sam, have a look (from this message editing thing i'm just using):
input
Files: 841e60cdd9f1c30350163475255096a49de19dd8
webcit/static/t/mailsummary_json.html
Apply samjam's patch to fix mailbox view
Nope. It's either there or it isn't. I suppose you could drop the table
:)
In nearly git-head of citadel, composing a mail message with webcit doesn't let me choose my identity, doesn't even choose my primary internet email address, but insists on making my from address be user.n...@full.host.name instead of u...@domain.name
I ran IGAB command but it made no
Files: 683cf04a13751c32c61ee9ae6949f2886a6515ba
citadel/modules/rssclient/serv_rssclient.c
branches config description git-daemon-export-ok HEAD hooks info objects
packed-refs refs remove debugging output etc.
Files: 88063ed1e26f3262c0a9cd5c344ec60824467f38 webcit/sitemap.c
Sitemap can now be retrieved at either /sitemap or /sitemap.xml
Files: f7fa2cb3c9eee3efa7b685ba0dcf04882a743c0a webcit/roomops.c
branches config description git-daemon-export-ok HEAD hooks info objects
packed-refs refs knrooms(): - use the right values for the type of display -
detect properly whether we need to set a default
Files: 8837ef861d6cad629f9902749f7b05dbe8383d79 webcit/context_loop.c
Fixed a race condition which made the thread pool size unnecessarily large.
Files: 898b8a51b960cd199a7bb5a45faf480468e37590 citadel/modules/imap/imap_misc.c
imap server update to new API
Fri Sep 10 2010 11:15:23 am EDT EDT from dothebart @ Uncensored Subject: Edit drafts, was Re: others messages
Sam, have a look (from this message editing thing i'm just using):
input type="hidden" name="force_room" value="Citadel Development"
its just posted to the server. If you add an
Tue Sep 14 2010 1:22:03 pm EDT EDT from IGnatius T Foobar @ Uncensored Subject: Re: Commit log to refs/heads/master
How is this information stored on disk?
Which information?
The id's of messages in rooms. Is it a list or a tree or a hash or a string?
Files: 390d6820bfa666374c3d6aa43768559f53406952 webcit/messages.c
readfwd etc now work in anonymous guest mode
Files: 45ba5fe490f4221ea01b6ff8b3e97258bb9e0502 webcit/context_loop.c
Revert Return 404 for robots.txt
1 - 100 of 108 matches
Mail list logo
