On 2015-05-14 06:00, tkreu...@svn.reactos.org wrote:
-int sign = (copysignf(1, in) 0);
+int sign = (in 0);
-if (copysignf(1.0f, value) 0.0f)
+if (value 0.0f)
++idx;
I believe the behavior would be different here for negative zero:
copysignf(1.0f, -0.0f)
On 2015-05-14 15:44, tkreu...@svn.reactos.org wrote:
+_Check_return_
+float
+__cdecl
+ceilf(
+_In_ float x)
+{
+return (float)ceilf((double)x);
+}
+_Check_return_
+float
+__cdecl
+floorf(
+_In_ float x)
+{
+return (float)floorf((double)x);
+}
Did you mean to call ceil/floor
Yes it did. Except that macro was a ROS-Diff in the first place ;)
On 2015-05-14 11:12, David Quintana (gigaherz) wrote:
Judging by the involved macro, if -0.0 is not 0, then the old code
had exactly the same bug.
On 14 May 2015 at 14:50, Thomas Faber thomas.fa...@reactos.org wrote:
On 2015
On 2015-05-12 06:57, akha...@svn.reactos.org wrote:
+/* FIXME: ntifs.h */
+#define FILE_READ_ONLY_VOLUME 0x0008
This should go in ndk/iotypes.h inside an NTOS_MODE_USER ifdef.
___
Ros-dev mailing list
Ros-dev@reactos.org
You can register your test as a service to be able to run it as SYSTEM. A bunch
if Wine's tests do this, e.g. advapi32:service and services:service.
To solve the other problem, one option might be to inject a thread into the
spooler process and run your test code there. Not sure if we already
Build GCCLin_x86 Release now seems to run on every commit AND once a
day, whereas Build GCCWin_x86 never runs automatically.
Dunno if this was a result of these changes; but the commit trigger
should probably go to the latter one?
Thanks.
On 2015-06-03 21:03, Colin Finck wrote:
Am 23.05.2015
For future reference:
(1) It's a bad idea to move something to a different file and edit it
at the same time
(2) Those constructor parameters really should be optional.
The interface was trivial before, and it's a good idea to keep it
that way. (I'm really only saying this because it
--- trunk/reactos/drivers/network/tcpip/tcpip.rc [iso-8859-1] (original)
+++ trunk/reactos/drivers/network/tcpip/tcpip.rc [iso-8859-1] Thu May 28
10:31:38 2015
@@ -1,5 +1,5 @@
#define REACTOS_VERSION_DLL
-#define REACTOS_STR_FILE_DESCRIPTION TCP/IP protocol driver
+#define
On 2015-06-29 20:26, ek...@svn.reactos.org wrote:
Modified: trunk/reactos/ntoskrnl/config/cmmapvw.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmmapvw.c?rev=68313r1=68312r2=68313view=diff
==
On 2015-08-18 14:26, hbelu...@svn.reactos.org wrote:
[NTVDM]: Initialize the PSP' memory control block owner name with the file
name (without extension, and up to 8 chars) of the started program.
Shouldn't that use GetShortPathName to make sure the program can find
itself on disk? :p
On 2015-08-22 13:16, bfrei...@svn.reactos.org wrote:
[HHPCOMP]
Improve functionality of Windows MSVC build. Based on a WIP patch by Michael
Fritscher.
See CORE-10019.
+/* if O_BINARY is not defined, the system is probably not expecting any such
flag */
+#ifndef O_BINARY
+#define O_BINARY 0
Well... since you asked...
Really good reason not to: if something's not broken, don't fix it.
Really good reason not to: if everything works fine and the user experience is
generally Windows-like, we should NOT try to make things more Windows-like. On
the contrary. Different is good, both in
On 2015-08-10 18:52, drei...@svn.reactos.org wrote:
--- trunk/reactos/dll/win32/browseui/addressband.cpp [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/browseui/addressband.cpp [iso-8859-1] Mon Aug 10
16:52:40 2015
@@ -93,7 +93,11 @@
pdbi-ptActual.y = 22;
}
if
On 2015-08-10 19:54, cwitt...@svn.reactos.org wrote:
@@ -40,8 +40,8 @@
PLIST_ENTRY Helpers;
INT Status;
-TRACE(AddressFamily %p, SocketType %p, Protocol %p, Group %u, Flags
%lx, TransportName %wZ, HelperDllContext %p, HeplperDllData %p, Events
is universal amongst
English
speakers. In Australia we say garbage (not trash) for actual waste
and
recycling for recyclables.
On Sun, Aug 9, 2015 at 7:46 PM, Thomas Faber
thomas.fa...@reactos.org
wrote:
Well... since you asked...
Really good reason not to: if something's not broken, don't fix
It makes a difference because m_RefreshPending was initialized to 0 by
the constructor, but the three bytes behind it were not, so the first
cmpxchg could fail.
Plus of course if someone decided to add another bool or a char array
or whatever at the end, that would get overwritten.
On 2015-11-03
On 2015-11-03 22:02, Timo Kreuzer wrote:
> m_RefreshPending is a 32 bit BOOL and the constructor will initialize it
> completely with 0.
> If it was initializing only the 1st byte, the new code would still be wrong,
> since it makes no difference.
> InterlockedCompareExchange will exchange 32
I would understand a commit that does the exact opposite; I don't
understand this one. How exactly is ASSERT easier to debug?
NT_ASSERT on GCC should essentially be the same as ASSERT
On MSVC/Windbg you get lots of advantages:
- you can ignore specific asserts
- you can set different event
On 2015-09-04 03:14, hbelu...@svn.reactos.org wrote:
> Also I suggest we turn this file (and maybe also
> /lib/sdk/crt/except/i386/cpp.s) into a "msvc-thiscall.c" as it is already
> done in some other DLLs (like in ole32, riched20).
ole32 and riched20 don't export mangled names.
MSVC ignores
You mean KernelMode->UserMode in the KeWaitForSingleObject call?
The only purpose of this wait is to fulfill a user request (namely a
read operation). If the thread performing the read is terminated,
there's no reason to stick around in msfs until data is available in the
mailslot. The wait should
Oh? I'll need to add a test for that then, thanks.
What does Windows's RTL do, then? I know in XP/2003 it might just hand
out user handles, but e.g. on Win7 that would cause verifier to
bugcheck.
On 2015-09-20 20:51, Alex Ionescu wrote:
Actually, in XP, OBJ_KERNEL_HANDLE Did work, and gave
On 2015-12-08 23:54, rnaum...@svn.reactos.org wrote:
> --- trunk/reactos/base/shell/explorer/trayprop.cpp[iso-8859-1] (original)
> +++ trunk/reactos/base/shell/explorer/trayprop.cpp[iso-8859-1] Tue Dec 8
> 22:54:33 2015
> @@ -338,7 +338,7 @@
> VOID
> DisplayTrayProperties(IN HWND
size
>
> Yes this should be a spinlock involved instead, for example the
> "LockQueueIoDatabaseLock" (queued) spinlock that we already use in other
> places in the code.
>
> -----Message d'origine-
> De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de
Timo, this is causing testbot to freak out since it now crashes during
an apitest. Could you look into it?
Thanks.
On 2015-12-29 21:28, tkreu...@svn.reactos.org wrote:
> Author: tkreuzer
> Date: Tue Dec 29 20:28:23 2015
> New Revision: 70464
>
> URL:
Uhm... raising the IRQL is not a synchronization mechanism. Should
there be a spinlock involved?
On 2015-12-23 12:26, gedmur...@svn.reactos.org wrote:
> Author: gedmurphy
> Date: Wed Dec 23 11:26:28 2015
> New Revision: 70408
>
> URL: http://svn.reactos.org/svn/reactos?rev=70408=rev
> Log:
>
On 2016-06-09 12:20, Yonggang Chen wrote:
> After building ReactOS and Rostests successfully, I can't debug CoInitialize
> function through Visual Studio 2015. It seems Visual Studio thinks I'm using
> their CoInitialize of Windows kernel.
That's because you _are_ using Windows's version! :)
The
On 2016-06-05 01:29, hbelu...@svn.reactos.org wrote:
> -rcDesk.left = GetSystemMetrics(SM_XVIRTUALSCREEN);
> -rcDesk.top = GetSystemMetrics(SM_YVIRTUALSCREEN);
> -rcDesk.right = rcDesk.left + GetSystemMetrics(SM_CXVIRTUALSCREEN);
> -rcDesk.bottom = rcDesk.top +
On 2016-06-15 12:10, z...@svn.reactos.org wrote:
--- branches/GSoC_2016/lwIP/drivers/network/tcpip/main.c[iso-8859-1]
(original)
+++ branches/GSoC_2016/lwIP/drivers/network/tcpip/main.c[iso-8859-1]
Wed Jun 15 19:10:40 2016
@@ -384,7 +384,9 @@
Quickie:
On 2016-06-29 02:38, hbelu...@svn.reactos.org wrote:
> +if (!CharCount && (Result == ERROR_INSUFFICIENT_BUFFER))
> +{
> +/* Reallocate the buffer with double size */
> +dwSize *= 2;
> +tmp = (PWSTR)HeapReAlloc(GetProcessHeap(), 0, lpTargetPath, dwSize *
>
On 2016-06-28 21:21, hbelu...@svn.reactos.org wrote:
> --- trunk/reactos/base/system/subst/subst.c [iso-8859-1] (original)
> +++ trunk/reactos/base/system/subst/subst.c [iso-8859-1] Tue Jun 28
> 19:21:08 2016
> @@ -75,81 +75,71 @@
> if (_tcslen(Drive) > 2)
> return FALSE;
>
>
The important part is to remove "svn/" from the URI because that's
ViewVC, and not the actual SVN repository.
On 2016-02-24 22:49, Thomas Schweikle wrote:
> Hi!
> I can't try that, because I am bound to use http(s) to check out – no
> Internet access without using a proxy … :-(
>
> 2016-02-24
That should have included "Patch by Víctor Martínez Calvo. CID 1322162."
On 2016-04-09 18:16, tfa...@svn.reactos.org wrote:
> Author: tfaber
> Date: Sat Apr 9 16:16:12 2016
> New Revision: 71129
>
> URL: http://svn.reactos.org/svn/reactos?rev=71129=rev
> Log:
> [NTOS:WMI]
> - Avoid a memory
On 2016-03-20 20:30, pschweit...@svn.reactos.org wrote:
> Seriously... GCC, you allow this?!
Apparently this is valid in newer C++ standards, so GCC allows it also
for C. It will warn with -pedantic, which is probably too... pedantic
for our code base unfortunately ;)
Hey Valentin,
thanks for your proposal and your interest in the project. I'm hopeful
we'll be able to get you some feedback tomorrow.
As for you build problem, make sure "find" refers to
%windir%\system32\find.exe. In particular, MSYS, cygwin or similar
environments come with a Unix-style 'find'
On 2016-03-03 01:36, hbelu...@svn.reactos.org wrote:
> @@ -160,9 +163,9 @@
>
> switch (argv[i][1])
> {
> -case L'?':
> -Usage(argv[0]);
> -break;
> +// case L'?':
> +
On 2016-03-31 23:12, ek...@svn.reactos.org wrote:
> +DWORD WINAPI DsEnumerateDomainTrustsW(LPWSTR ServerName, ULONG Flags,
> PDS_DOMAIN_TRUSTSW* Domains, PULONG DomainCount)
> +{
> +FIXME("(%s, %x, %p, %p): stub\n", ServerName, Flags, Domains,
> DomainCount);
> +return
On 2016-04-23 21:09, spetreo...@svn.reactos.org wrote:
> [NDIS]
> Silence a debug output.
> CORE-11137 #resolve
> --- trunk/reactos/drivers/network/ndis/ndis/protocol.c[iso-8859-1]
> (original)
> +++ trunk/reactos/drivers/network/ndis/ndis/protocol.c[iso-8859-1]
> Sat Apr 23
On 2016-04-20 14:16, akha...@svn.reactos.org wrote:
> [CLASSPNP] Fix MSVC build. Brought to you by Timo.
> --- trunk/reactos/drivers/storage/classpnp/class.c[iso-8859-1] (original)
> +++ trunk/reactos/drivers/storage/classpnp/class.c[iso-8859-1] Wed Apr 20
> 12:16:16 2016
> @@ -877,7
Looks like we've encountered an issue with this
KiTrapReturnNoSegmentsRet8 approach. As seen in
https://jira.reactos.org/browse/CORE-5, when a large number of
interrupts happen, this will cause us to run out of kernel stack.
Since the popfd / ret 8 steps do not happen atomically, interrupts
On 2016-08-10 00:10, gedmur...@svn.reactos.org wrote:
> +/* Calc and allocate a buffer to hold our filter name */
> +BufferLength = wcslen(lpFilterName) * sizeof(WCHAR);
> +FilterName = RtlAllocateHeap(GetProcessHeap(),
> + 0,
> +
Comments inline.
On 2016-07-05 20:35, z...@svn.reactos.org wrote:
> --- branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c
> [iso-8859-1] (original)
> +++ branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c
> [iso-8859-1] Tue Jul 5 18:35:17 2016
> @@ -357,15
Can't event viewer load those icons from shell32 (much like regedit
should)?
On 2016-07-06 01:42, hbelu...@svn.reactos.org wrote:
> Author: hbelusca
> Date: Tue Jul 5 23:42:40 2016
> New Revision: 71829
>
> URL: http://svn.reactos.org/svn/reactos?rev=71829=rev
> Log:
> [CLIPBRD]: Use NULL for
On 2016-07-08 19:52, z...@svn.reactos.org wrote:
> --- branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c
> [iso-8859-1] (original)
> +++ branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c
> [iso-8859-1] Fri Jul 8 17:52:42 2016
> @@ -33,6 +33,8 @@
> static
On 2017-02-24 02:52, hbelu...@svn.reactos.org wrote:
@@ -4419,12 +4422,31 @@
LPCWSTR UnSafepwc = pwc;
LPWORD UnSafepgi = pgi;
-if ((!UnSafepwc) && (!UnSafepgi)) return cwc;
-
-if ((UnSafepwc == NULL) || (UnSafepgi == NULL))
+/* Check for integer overflow */
+if (cwc &
On 2017-02-13 23:38, ek...@svn.reactos.org wrote:
> +_SEH2_TRY
> +{
> +Relations = RelationsData->Relations;
> +BufferSize = RelationsData->BufferSize;
> +Buffer = RelationsData->Buffer;
> +
> +ProbeForWrite(RelationsData->Buffer,
> +
"ASSUME DS:.text" allows the assembler to use a smaller addressing
mode -- but then also (silently) refuses to use 32 bit memory operands.
E.g.
mov ds:[01234h], ax
mov ds:[012345678h], ax
becomes
6: a3 34 12mov%ax,0x1234
9: a3 78 56mov
I've seen like 4 people change this stuff recently and not one of them
got it 100% right.
So here are the rules for how to use probes and SEH:
* Probe pointers before accessing them. This ensures you're not reading
kernel mode memory (and does pretty much nothing else)
* Never access user mode
Could you elaborate on what makes it broken? Link to a bug perhaps?
On 2016-09-24 13:39, cwitt...@svn.reactos.org wrote:
> Author: cwittich
> Date: Sat Sep 24 11:39:17 2016
> New Revision: 72792
>
> URL: http://svn.reactos.org/svn/reactos?rev=72792=rev
> Log:
> [CRYPTNET] disable broken code
>
mitted a better fix.
>
>
> Am 24.09.2016 um 13:56 schrieb Thomas Faber:
>> Could you elaborate on what makes it broken? Link to a bug perhaps?
>>
>> On 2016-09-24 13:39, cwitt...@svn.reactos.org wrote:
>>> Author: cwittich
>>> Date: Sat Sep 24 11:3
ests
> + * LICENSE: GPLv2+ - See COPYING in the top level directory
> + * PURPOSE: Test for getaddrinfo
> + * PROGRAMMER: Thomas Faber <thomas.fa...@reactos.org>
> + */
Thanks for the credit, but I don't think I deserve it ;)
On 2016-09-18 16:24, janderw...@svn.reactos.org wrote:
> +NTSTATUS
> +SubmitUrbSync(
> +IN PKSDEVICE Device,
> +IN PURB Urb)
> +{
> +PIRP Irp;
> +KEVENT Event;
> +PDEVICE_EXTENSION DeviceExtension;
> +IO_STATUS_BLOCK IoStatus;
> +PIO_STACK_LOCATION IoStack;
> +
On 2016-09-21 01:43, hbelu...@svn.reactos.org wrote:
> @@ -300,25 +268,53 @@
> * @implemented
> */
> NTSTATUS
> -WINAPI
> -LsaRegisterLogonProcess(PLSA_STRING LsaLogonProcessName,
> -PHANDLE Handle,
> -PLSA_OPERATIONAL_MODE OperationalMode)
> -{
On 2016-09-06 18:59, gedmur...@svn.reactos.org wrote:
> +NTSTATUS
> +HandleLoadUnloadIoctl(_In_ PDEVICE_OBJECT DeviceObject,
> + _Inout_ PIRP Irp)
> +{
> +PIO_STACK_LOCATION StackPtr;
> +UNICODE_STRING Name;
> +PFILTER_NAME FilterName;
> +ULONG BufferLength;
>
On 2016-09-06 18:47, gedmur...@svn.reactos.org wrote:
> @@ -116,12 +150,21 @@
> InitializeListHead(>PortList.mList);
> Filter->PortList.mCount = 0;
>
> +/* We got this far, assume success from here */
> +Status = STATUS_SUCCESS;
> +
> /* Check if the caller requested any
On 2016-08-20 11:43, gadamopou...@svn.reactos.org wrote:
> --- trunk/reactos/dll/win32/shell32/shlfileop.cpp [iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/shell32/shlfileop.cpp [iso-8859-1] Sat Aug 20
> 09:43:09 2016
> @@ -1480,6 +1480,19 @@
> return 0;
> }
>
You should be able to simply add an
Options=...
line to the [Setup] section in boot/bootdata/bootcd.ini to modify
the setup's freeldr options. That file becomes freeldr.ini in the root
dir of the BootCD.
On 2016-09-27 12:21, Love Nystrom wrote:
> Good afternoon gentlemen..
>
> Can anyone tell
orrect LastError when
>> you pass an invalid path like "C:C:\Windows"
>> Our CreateFile returns ERROR_INVALID_NAME, wines PATH_NOT_FOUND or
>> FILE_NOT_FOUND**
>>
>> Guess we need a test for CreateFile...
>>
>> Am 24.09.2016 um 17:10 schrieb Thoma
APITests should be named after a function.
And in particular, they can't be named the same as a Wine test for the
same module. This is currently causing result submission on Testbot to
fail, so please rename this test.
On 2016-11-09 23:13, mjan...@svn.reactos.org wrote:
Author: mjansen
Date:
On 2016-10-19 01:45, hbelu...@svn.reactos.org wrote:
> --- trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c
> [iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c
> [iso-8859-1] Tue Oct 18 23:45:19 2016
> @@ -137,7 +137,7 @@
>
On 2016-10-21 23:15, janderw...@svn.reactos.org wrote:
> NTSTATUS
> +NTAPI
> +USBAudioGetDescriptor(
> +IN PDEVICE_OBJECT DeviceObject,
> +IN UCHAR DescriptorType,
> +IN ULONG DescriptorLength,
> +IN UCHAR DescriptorIndex,
> +IN LANGID LanguageId,
> +OUT PVOID
On 2016-11-14 17:19, hbelu...@svn.reactos.org wrote:
-hInstance = GetModuleHandleW(L"lsasrv.dll");
+hInstance = GetModuleHandleW(NULL);
Those are not equivalent at all.
___
Ros-dev mailing list
Ros-dev@reactos.org
On 2016-11-02 12:24, pha...@svn.reactos.org wrote:
+/* Check if we had an unspecified address */
+if (Connection->AddressFile->Address.Address.IPv4Address !=
bindaddr.addr)
+{
+/* We did, so we need to copy back the address */
+
And what's wrong with just adding it to our headers?
On 2016-10-30 15:14, hbelu...@svn.reactos.org wrote:
Author: hbelusca
Date: Sun Oct 30 14:14:27 2016
New Revision: 73078
URL: http://svn.reactos.org/svn/reactos?rev=73078=rev
Log:
[BTRFS]: Fix compilation with MSVC too, as we don't have the
On 2016-10-27 00:06, hbelu...@svn.reactos.org wrote:
-/* Sundry checkboxes */
+/* Other checkboxes */
Not sure how this "fixes" anything? Those are synonyms?
___
Ros-dev mailing list
Ros-dev@reactos.org
Hurray! Congrats on your first commit!
On 2016-10-10 08:38, pha...@svn.reactos.org wrote:
> Author: phater
> Date: Mon Oct 10 06:38:52 2016
> New Revision: 72948
>
> URL: http://svn.reactos.org/svn/reactos?rev=72948=rev
> Log:
> [MSAFD] Fix some return codes and better parameter checks based on
On 2016-12-07 01:10, gadamopou...@svn.reactos.org wrote:
[SHELL32] - Initialize the shell icon cache only when needed or when
FileIconInit is called (and not in the DllMain of shell32)
--- trunk/reactos/dll/win32/shell32/iconcache.cpp [iso-8859-1] (original)
+++
On 2017-01-13 05:06, jimta...@svn.reactos.org wrote:
VOID FASTCALL
IntSendChildNCPaint(PWND pWnd)
{
+ PWND Child;
+ HWND *List, *phWnd;
+
+ List = IntWinListChildren(UserGetDesktopWindow());
+ if ( List )
+ {
+ for (phWnd = List; *phWnd; ++phWnd)
+ {
+ Child =
On 2016-12-22 11:39, jimta...@svn.reactos.org wrote:
+#ifndef _WIN32K_ / Fix CORE-2201.
+if (!(flags & DT_NOCLIP) )
+{
+ int hasClip;
+ hrgn = CreateRectRgn(0,0,0,0);
+ if (hrgn)
+ {
+ hasClip = GetClipRgn(hdc, hrgn);
+ // If the region to be
On 2017-03-12 10:48, gadamopou...@svn.reactos.org wrote:
// *** IServiceProvider methods ***
HRESULT STDMETHODCALLTYPE CExplorerBand::QueryService(REFGUID guidService,
REFIID riid, void **ppvObject)
{
-UNIMPLEMENTED;
-return E_NOTIMPL;
+/* FIXME: we probably want to handle more
I can tell you some possible next steps:
- x64: implement PAE support in the 32 bit kernel
- SMP: Implement resource translators and arbiters (I have some initial work
for this somewhere)
- Also SMP: build a CONFIG_SMP kernel (with some hack to use the regular HAL)
and debug any issues coming
Hey,
from your list I'd be the likely mentor for at least the KMTest
project. Other projects might be supported by Pierre, Giannis or others.
To help pick your project I'd suggest you let us know more about your
interests and skills, as these are probably the most important factor.
A real-time
Hello,
I've seen some of your contributions and am happy to hear you're
considering applying.
I'd be the most likely mentor candidate for a USB-related project, so
feel free to direct any technical questions toward me or show me
proposal drafts. The code you'd be working on will be structurally
Hi,
Terminal Services is a relatively generic project that we might assign
almost any mentor to. Feel free to post any technical questions you
might have here or on #reactos-dev. If you'd like to talk to someone
privately, you may pick any of the devs that you see active on the
mailing list or
On 2017-03-04 17:02, ek...@svn.reactos.org wrote:
> +Dacl = ExAllocatePool(PagedPool, AclLength);
Would you mind using ExAllocatePoolWithTag for new code please,
with no exceptions?
(I want to #define ExAllocatePool do_not_use_this_function at some point)
Thanks!
-Thomas
On 2017-03-05 01:40, hbelu...@svn.reactos.org wrote:
+
+/*
+ * Check whether we actually just retrieved the needed buffer size
+ * because our previous local allocation did fail. If so, allocate
+ * a new buffer and retry again.
+ */
+if ( (!UnicodeQuerySet) &&
I said it's unclear how, not that it doesn't happen ;)
This change fixes boot on the machine mentioned in
https://jira.reactos.org/browse/CORE-12993
What happens is there's a bug in the BIOS that causes a ret to an
broken address, then we execute garbage and fault on a stack address.
The stack
There's an easy benefit for them: it reduces their test matrix.
That's why you generally only support platforms that have value, rather
than supporting everything unless and until you have a concrete reason
to drop it.
On 2017-06-29 16:08, Hermès BÉLUSCA-MAÏTO wrote:
I’m wondering for which
We have a bin2c tool that would make including the boot logo much
nicer. You'll want to use something like the attached patch, and add
the bmp file as app/rosload/logo.bmp. Then just include "logo.h"
instead of the g_Logo array in rosload.c.
On 2017-05-15 03:38, i...@svn.reactos.org wrote:
Hey Hermès,
I'm fixing how the BCD hive is generated and this just showed up in an
svn blame for me.
Can you explain why this bcd_hive dependency is needed? I don't see the
command depending on the hive file.
Thanks,
Thomas
On 2015-09-09 21:48, hbelu...@svn.reactos.org wrote:
> Author: hbelusca
Basic source control rule: please don't change things and move them
around at the same time. Unless your goal is to make sure noone reviews
your changes, of course.
Thanks.
-Thomas
On 2017-05-15 03:52, hbelu...@svn.reactos.org wrote:
Author: hbelusca
Date: Mon May 15 01:52:34 2017
New
On 2017-05-15 03:59, hbelu...@svn.reactos.org wrote:
Author: hbelusca
Date: Mon May 15 01:59:28 2017
New Revision: 74550
URL: http://svn.reactos.org/svn/reactos?rev=74550=rev
Log:
[USETUP]: Continue implementing the NT OS installation detector.
What remains to be done here, besides cleaning up
Hi again,
some comments inline.
On 2017-05-15 03:59, hbelu...@svn.reactos.org wrote:
--- branches/setup_improvements/base/setup/usetup/osdetect.c[iso-8859-1]
(original)
+++ branches/setup_improvements/base/setup/usetup/osdetect.c[iso-8859-1]
Mon May 15 01:59:28 2017
@@ -19,6 +19,9
Hi,
comments inline.
On 2017-05-15 18:05, gadamopou...@svn.reactos.org wrote:
--- trunk/reactos/dll/win32/uxtheme/nonclient.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/uxtheme/nonclient.c [iso-8859-1] Mon May 15
16:05:14 2017
@@ -100,16 +100,7 @@
return hIcon;
}
-WCHAR
On 2017-06-02 19:52, pha...@svn.reactos.org wrote:
+aDstNextStr = (char*)((DWORD)aDstNextStr + (DWORD)bItmLen);
DWORD cannot always fit a pointer. You want DWORD_PTR for this kind of
math (or simply use char *).
___
Ros-dev mailing list
On 2017-06-09 05:14, tthomp...@svn.reactos.org wrote:
> +RtlZeroMemory(, sizeof(UNICODE_STRING));
> +FilenameNoPath.Buffer = Buffer;
> +FilenameNoPath.MaximumLength = MAX_PATH;
> +
RtlInitEmptyUnicodeString does this for you
On 2017-06-09 05:14, tthomp...@svn.reactos.org wrote:
> +
On 2017-06-12 01:58, hbelu...@svn.reactos.org wrote:
+NTSTATUS
+SetupMoveFile(
+IN PCWSTR ExistingFileName,
+IN PCWSTR NewFileName,
+IN ULONG Flags)
+{
+NTSTATUS Status;
+IO_STATUS_BLOCK IoStatusBlock;
+OBJECT_ATTRIBUTES ObjectAttributes;
+PFILE_RENAME_INFORMATION
On 2017-06-19 18:29, hbelu...@svn.reactos.org wrote:
+/*
+ * Free it from the pool.
+ *
+ * We cannot use here ExFreePoolWithTag(..., OB_NAME_TAG); , because
+ * the object name may have been massaged during operation by different
+ * object parse
On 2017-05-22 03:09, hbelu...@svn.reactos.org wrote:
--- branches/setup_improvements/base/setup/lib/arcname.c(added)
+++ branches/setup_improvements/base/setup/lib/arcname.c[iso-8859-1]
Mon May 22 01:09:35 2017
+PCSTR
+ArcGetNextTokenA(
+IN PCSTR ArcPath,
+OUT
On 2017-05-22 01:41, hbelu...@svn.reactos.org wrote:
+static PCVS_VERSION_INFO_STRUCT32
+VersionInfo32_FindChild(
+IN PCVS_VERSION_INFO_STRUCT32 info,
+IN PCWSTR szKey,
+IN UINT cbKey)
+{
+PCVS_VERSION_INFO_STRUCT32 child = VersionInfo32_Children(info);
+
+while
On 2017-05-22 01:45, hbelu...@svn.reactos.org wrote:
> +BOOLEAN
> +NtPathToDiskPartComponents(
> +IN PCWSTR NtPath,
> +OUT PULONG pDiskNumber,
> +OUT PULONG pPartNumber,
> +OUT PCWSTR* PathComponent OPTIONAL)
> +{
> +ULONG DiskNumber, PartNumber;
> +PCWSTR Path;
> +
> +
On 2017-05-22 01:36, hbelu...@svn.reactos.org wrote:
--- branches/setup_improvements/base/setup/lib/partlist.c [iso-8859-1]
(original)
+++ branches/setup_improvements/base/setup/lib/partlist.c [iso-8859-1]
Sun May 21 23:36:13 2017
@@ -1333,8 +1348,204 @@
Testbots seem to dislike this commit, looks like 3rd stage boot is
broken in some way. :(
On 2017-05-28 21:27, mjan...@svn.reactos.org wrote:
Author: mjansen
Date: Sun May 28 19:27:51 2017
New Revision: 74693
URL: http://svn.reactos.org/svn/reactos?rev=74693=rev
Log:
[KERNEL32] Initial
On 2017-06-01 20:37, hbelu...@svn.reactos.org wrote:
+if (!NT_SUCCESS(Status))
+{
+/* We failed, close all the opened handles and return */
+// NtClose(KeyHandle);
Please don't add commented-out code.
What is that supposed to even mean? "I was too lazy to test this"?
On 2017-06-02 02:00, hbelu...@svn.reactos.org wrote:
[MKHIVE]: Formatting changes only + sync back the names of the reg-inf
functions with the ones where they are coming from (aka. Wine's
setupapi/install.c).
Those two goals clearly conflict with either other. Either keep Wine's
function
On 2017-06-02 02:44, hbelu...@svn.reactos.org wrote:
@@ -341,7 +341,7 @@
}
InitializeObjectAttributes(, , OBJ_CASE_INSENSITIVE, NULL, NULL);
-Status = NtCreateKey(, 0, , 0, NULL, 0, NULL);
+Status = NtCreateKey(, KEY_ALL_ACCESS, , 0,
NULL, 0, NULL);
if
I understand not making the change to how 1st stage deals with the
registry in trunk.
Why not the tool change though? Can't you have the new mkhive do the
exact same thing it does now, and do it in trunk? The smaller your
branch merge commit the easier it will be to avoid/pinpoint/fix
On 2017-06-01 20:27, hbelu...@svn.reactos.org wrote:
/* EISA */
case EisaAdapter:
-
+{
/* Fixup information */
Interface = Eisa;
Bus = CmpTypeCount[EisaAdapter]++;
years old).
On 2017-05-08 04:11, Hermès BÉLUSCA-MAÏTO wrote:
Hi!
The assert is fixed (r74495). For ExAllocatePool, it would be better to change
them all at once in this file.
Hermès
-Message d'origine-
De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Thomas Faber
Envoyé
On 2017-05-07 20:15, hbelu...@svn.reactos.org wrote:
--- trunk/reactos/ntoskrnl/io/iomgr/driver.c[iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/driver.c[iso-8859-1] Sun May 7
18:15:12 2017
@@ -884,7 +884,7 @@
PDEVICE_NODE DeviceNode;
PDRIVER_OBJECT DriverObject;
I'm wary of opening up pushing to master. If we really want a linear
history, it should be enforced. Accidents with version control happen
all the time (when was the last time the SVN pre-commit hook stopped you
from committing because you forgot to set eol-style?).
I wouldn't mind forcing the
101 - 200 of 231 matches
Mail list logo
