Re: [ros-dev] [ros-diffs] [mkupfer] 45302: this log message leftintentionally non-descriptive

2010-01-28 Thread Kamil Horníček
what? andrew is missing? abandon the ship! revert!

- Original Message - 
From: Andrew Faulds
To: ReactOS Development List
Sent: Friday, January 29, 2010 12:05 AM
Subject: Re: [ros-dev] [ros-diffs] [mkupfer] 45302: this log message 
leftintentionally non-descriptive


Like me?
OK I only did two patches... but it's an example

Sent from my iPod
Andrew Faulds

On 28 Jan 2010, at 22:29, Ged Murphy  wrote:


This is a bad idea.
Ignoring the fact that the code is a serious crash hazard, you've now got a 
public place which needs to be kept current.
I bet I can name at least 10 developers which aren't on this list.


On Thu, Jan 28, 2010 at 10:18 PM,  wrote:

Author: mkupfer
Date: Thu Jan 28 23:18:31 2010
New Revision: 45302

URL: http://svn.reactos.org/svn/reactos?rev=45302&view=rev
Log:
this log message left intentionally non-descriptive

Modified:
   trunk/reactos/dll/cpl/sysdm/general.c
   trunk/reactos/dll/cpl/sysdm/lang/de-DE.rc
   trunk/reactos/dll/cpl/sysdm/lang/en-US.rc
   trunk/reactos/dll/cpl/sysdm/resource.h

Modified: trunk/reactos/dll/cpl/sysdm/general.c
URL: 
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/sysdm/general.c?rev=45302&r1=45301&r2=45302&view=diff
==
--- trunk/reactos/dll/cpl/sysdm/general.c [iso-8859-1] (original)
+++ trunk/reactos/dll/cpl/sysdm/general.c [iso-8859-1] Thu Jan 28 23:18:31 
2010
@@ -12,6 +12,9 @@

 #include "precomp.h"

+#define ANIM_STEP 2
+#define ANIM_TIME 50
+
 typedef struct _IMGINFO
 {
HBITMAP hBitmap;
@@ -19,6 +22,7 @@
INT cySource;
 } IMGINFO, *PIMGINFO;

+PIMGINFO pImgInfo = NULL;

 void
 ShowLastWin32Error(HWND hWndOwner)
@@ -70,6 +74,124 @@
}
 }

+LRESULT CALLBACK RosImageProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM 
lParam)
+{
+   static UINT timerid = 0, top = 0, offset;
+   static HBITMAP hBitmap2;
+   RECT r;
+   NONCLIENTMETRICS ncm;
+   HFONT hfont;
+   BITMAP bitmap;
+   HDC dc, sdc;
+   TCHAR devtext[2048];
+   switch (uMsg)
+   {
+   case WM_LBUTTONDBLCLK:
+   if (wParam & (MK_CONTROL | MK_SHIFT))
+   {
+   if (timerid == 0)
+   {
+   top = 0; // set top
+
+   // build new bitmap
+   GetObject(pImgInfo->hBitmap, 
sizeof(BITMAP), &bitmap);
+   dc = 
CreateCompatibleDC(GetDC(NULL));
+   sdc = CreateCompatibleDC(dc);
+   ncm.cbSize = 
sizeof(NONCLIENTMETRICS);
+ 
SystemParametersInfo(SPI_GETNONCLIENTMETRICS, sizeof(NONCLIENTMETRICS), 
&ncm, 0);
+
+   hfont = 
CreateFontIndirect(&ncm.lfMessageFont);
+   SelectObject(dc, hfont);
+   SetRect(&r, 0, 0, 0, 0);
+   LoadString(hApplet, IDS_DEVS, 
devtext, sizeof(devtext) / sizeof(TCHAR));
+   DrawText(dc, devtext, -1, &r, 
DT_CALCRECT);
+   hBitmap2 = 
CreateBitmap(pImgInfo->cxSource, (2 * pImgInfo->cySource) + (r.bottom + 1 - 
r.top), bitmap.bmPlanes, bitmap.bmBitsPixel, NULL);
+   SelectObject(sdc, 
pImgInfo->hBitmap);
+   SelectObject(dc, hBitmap2);
+   offset = 0;
+   BitBlt(dc, 0, offset, 
bitmap.bmWidth, bitmap.bmHeight, sdc, 0, 0, SRCCOPY);
+   offset += bitmap.bmHeight;
+
+   SetRect(&r, 0, offset, 
bitmap.bmWidth, offset + (r.bottom - r.top) + 1);
+   FillRect(dc, &r, 
GetSysColorBrush(COLOR_3DFACE));
+   SetBkMode(dc, TRANSPARENT);
+   OffsetRect(&r, 1, 1);
+   SetTextColor(dc, 
GetSysColor(COLOR_BTNSHADOW));
+   DrawText(dc, devtext, -1, &r, 
DT_CENTER);
+   OffsetRect(&r, -1, -1);
+   SetTextColor(dc, 
GetSysColor(COLOR_WINDOWTEXT));
+   DrawText(dc, devtext, -1, &r, 
DT_CENTER);
+   offset += r.bottom - r.top;
+
+   BitBlt(dc, 0, offset, 
bitmap.bmWidth, bitmap.bmHeight, sdc, 0, 0, SRCCOPY);
+   offset += bitmap.bmHeight;
+   DeleteDC(sdc);
+   DeleteDC(dc);
+
+   timerid = SetTimer(hwnd, 1, 
ANIM_TIME, NULL);
+

Re: [ros-dev] Arwinss presentation

2010-01-17 Thread Kamil Horníček
What would be the advantage of such an approach? We now use only Wine DX 
libs anyway and wined3d seems to do its job just fine.
This would go directly against the whole arwinss idea = use tested and known 
to work code from Wine and only spend valuable dev time on parts that are 
reactos specific.

Kamil

- Original Message - 
From: "Jérôme Gardou" 
To: "ReactOS Development List" 
Sent: Sunday, January 17, 2010 2:31 AM
Subject: Re: [ros-dev] Arwinss presentation


> Could this be pushed to write a rosd3d driver? Take all d3d dlls from
> wine and write a wined3d compatible dll?
> Also, users could make a choice between wine and ReactOS implementation...
>
> Marius Przybylski wrote:
>> What are the disadvantages to using ARWINSS as Win32 subsystem ?
>>
>> "Entry level is rather low" - What are the requirements for Arwinss 
>> developer ?
>>
>>
>>
>> - Marius Przybylski
>>
>>
>>
>>
>>
>> Dnia 16 stycznia 2010 22:44 Aleksey Bragin 
>> napisał(a):
>>
>
> ___
> Ros-dev mailing list
> Ros-dev@reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev 


___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev