Re: [Rosegarden-devel] Category logging

2021-05-06 Thread Philip Leishman
On 5/6/21 10:03 AM, David Faure wrote: On mercredi 21 avril 2021 10:21:13 CEST Philip Leishman wrote: Yes this mail is an excellent description of the benefits of qCDebug. Thanks David. I agree with everything. Actually parallel to this I did a little merge request - also with a minimal chan

Re: [Rosegarden-devel] Category logging

2021-05-06 Thread David Faure
On mercredi 21 avril 2021 10:21:13 CEST Philip Leishman wrote: > Yes this mail is an excellent description of the benefits of qCDebug. > Thanks David. I agree with everything. > > Actually parallel to this I did a little merge request - also with a > minimal change to demonstrate category debuggin

Re: [Rosegarden-devel] Category logging

2021-04-21 Thread Philip Leishman
On 4/21/21 2:59 PM, Ted Felix wrote: On 4/21/21 3:44 AM, David Faure wrote: qDebug/qCDebug can be turned off at compile time with QT_NO_DEBUG_OUTPUT, which we could decide to set in release builds.  That is *exactly* what I need.  I need the performance hit removed in release builds.  If som

Re: [Rosegarden-devel] Category logging

2021-04-21 Thread Ted Felix
On 4/21/21 3:44 AM, David Faure wrote: > qDebug/qCDebug can be turned off at compile time with QT_NO_DEBUG_OUTPUT, which we could decide to set in release builds. That is *exactly* what I need. I need the performance hit removed in release builds. If someone wants debug logging, they can d

Re: [Rosegarden-devel] Category logging

2021-04-21 Thread Philip Leishman
Yes this mail is an excellent description of the benefits of qCDebug. Thanks David. I agree with everything. Actually parallel to this I did a little merge request - also with a minimal change to demonstrate category debugging. And (surprise) it looks almost exactly like the changes here !! Howe

Re: [Rosegarden-devel] Category logging

2021-04-21 Thread David Faure
On lundi 19 avril 2021 02:54:18 CEST Ted Felix wrote: > On 4/18/21 3:48 PM, Philip Leishman wrote: > > I still think qCDebug is a good way to go. I just don't know how to do > > it without changing many hundreds of lines of code in almost all files. > >Before we embark on this project, I would

Re: [Rosegarden-devel] Category logging

2021-04-18 Thread Ted Felix
On 4/18/21 3:48 PM, Philip Leishman wrote: I still think qCDebug is a good way to go. I just don't know how to do it without changing many hundreds of lines of code in almost all files. Before we embark on this project, I would like to see a proof of concept that shows that we can correctly

Re: [Rosegarden-devel] Category logging

2021-04-18 Thread David Faure
On dimanche 18 avril 2021 21:48:35 CEST Philip Leishman wrote: > Yes in that sense it does slot in. > I was looking for a way to use the existing macro - redefine RG_DEBUG to > something using qCDebug - this appears to be not so easy. > > I still think qCDebug is a good way to go. I just don't know

[Rosegarden-devel] Category logging

2021-04-18 Thread Philip Leishman
Yes in that sense it does slot in. I was looking for a way to use the existing macro - redefine RG_DEBUG to something using qCDebug - this appears to be not so easy. I think the category logging is a separate issue to the precompiled headers - I think we have reached a good status with the prec