Re: [Rosegarden-devel] Build failure in r15475

2019-03-30 Thread David Faure
On samedi 30 mars 2019 16:45:23 CET Colin Fletcher wrote: > On 30/03/2019 15:34, David Faure wrote: > > On samedi 30 mars 2019 15:57:30 CET Colin Fletcher wrote: > >> Updated patch with {} attached. > > > > Looks good to me. > > > > Do you have access in order to push it, or should I? > > I don'

Re: [Rosegarden-devel] Build failure in r15475

2019-03-30 Thread Colin Fletcher via Rosegarden-devel
On 30/03/2019 15:34, David Faure wrote: > On samedi 30 mars 2019 15:57:30 CET Colin Fletcher wrote: >> Updated patch with {} attached. > > Looks good to me. > > Do you have access in order to push it, or should I? I don't have commit access, no. If you're happy with it and you could push it, tha

Re: [Rosegarden-devel] Build failure in r15475

2019-03-30 Thread David Faure
On samedi 30 mars 2019 15:57:30 CET Colin Fletcher wrote: > On 30/03/2019 14:17, David Faure wrote: > > On samedi 30 mars 2019 14:54:31 CET Colin Fletcher wrote: > >> On 30/03/2019 12:09, David Faure wrote: > >>> On samedi 30 mars 2019 13:05:13 CET Colin Fletcher wrote: > On 30/03/2019 11:41,

Re: [Rosegarden-devel] Build failure in r15475

2019-03-30 Thread Colin Fletcher via Rosegarden-devel
On 30/03/2019 14:17, David Faure wrote: > On samedi 30 mars 2019 14:54:31 CET Colin Fletcher wrote: >> On 30/03/2019 12:09, David Faure wrote: >>> On samedi 30 mars 2019 13:05:13 CET Colin Fletcher wrote: On 30/03/2019 11:41, David Faure wrote: > On samedi 30 mars 2019 12:37:57 CET Colin F

Re: [Rosegarden-devel] Build failure in r15475

2019-03-30 Thread David Faure
On samedi 30 mars 2019 14:54:31 CET Colin Fletcher wrote: > On 30/03/2019 12:09, David Faure wrote: > > On samedi 30 mars 2019 13:05:13 CET Colin Fletcher wrote: > >> On 30/03/2019 11:41, David Faure wrote: > >>> On samedi 30 mars 2019 12:37:57 CET Colin Fletcher via Rosegarden-devel > > > > wrote

Re: [Rosegarden-devel] Build failure in r15475

2019-03-30 Thread Colin Fletcher via Rosegarden-devel
On 30/03/2019 12:09, David Faure wrote: > On samedi 30 mars 2019 13:05:13 CET Colin Fletcher wrote: >> On 30/03/2019 11:41, David Faure wrote: >>> On samedi 30 mars 2019 12:37:57 CET Colin Fletcher via Rosegarden-devel > wrote: no known conversion for argument 2 from ‘std::nullptr_t’ to

Re: [Rosegarden-devel] Build failure in r15475

2019-03-30 Thread David Faure
On samedi 30 mars 2019 13:05:13 CET Colin Fletcher wrote: > On 30/03/2019 11:41, David Faure wrote: > > On samedi 30 mars 2019 12:37:57 CET Colin Fletcher via Rosegarden-devel wrote: > >> no known conversion for argument 2 from ‘std::nullptr_t’ > >> to ‘QSharedPointer’ > > > > QSharedPtr only gai

Re: [Rosegarden-devel] Build failure in r15475

2019-03-30 Thread David Faure
On samedi 30 mars 2019 12:37:57 CET Colin Fletcher via Rosegarden-devel wrote: > no known conversion for argument 2 from ‘std::nullptr_t’ > to ‘QSharedPointer’ QSharedPtr only gained support for nullptr_t in Qt 5.8. Is your Qt version older than that? -- David Faure, fa...@kde.org, http://www.d

Re: [Rosegarden-devel] Build failure in r15475

2019-03-30 Thread Colin Fletcher via Rosegarden-devel
On 30/03/2019 11:41, David Faure wrote: > On samedi 30 mars 2019 12:37:57 CET Colin Fletcher via Rosegarden-devel wrote: >> no known conversion for argument 2 from ‘std::nullptr_t’ >> to ‘QSharedPointer’ > > QSharedPtr only gained support for nullptr_t in Qt 5.8. > > Is your Qt version older than