Patch: Add %_specfile macro

2013-08-26 Thread Per Øyvind Karlsen
This one has been commited by devzero2000 (IIRC) on HEAD branch, but not in rpm-5_4. It simply adds a %_specfile macro to get the file name of the spec file parsed. -- Regards, Per Øyvind rpm-5.4.4-add-_specfile-macro.patch Description: Binary data

Fix rpm -qa \*foo\*

2013-08-26 Thread Per Øyvind Karlsen
The following patch fixes querying rpmdb with wildcards, whereas without this fix, it'll return all entries and not just those matching. -- Regards, Per Øyvind rpm-5.4.9-fix-rpm_qa-pattern.patch Description: Binary data

Support for terminate build on duplicate files

2013-08-26 Thread Per Øyvind Karlsen
This patch enables termination of build on duplicate files by setting %_duplicate_files_terminate_build . -- Regards, Per Øyvind rpm-5.4.10-duplicate_files_terminate_build.patch Description: Binary data

Don't display suggests with --requires

2013-08-26 Thread Per Øyvind Karlsen
This patch fixes so that soft dependencies won't be displayed with 'rpm -q --requires', only with 'rpm -q --suggests' -- Regards, Per Øyvind rpm-5.4.8-dont-show-suggests-with-requires.patch Description: Binary data

Silence excessive output from eu-strip

2013-08-26 Thread Per Øyvind Karlsen
This patch silences excessive output from eu-strip during find-debuginfo.sh usage. -- Regards, Per Øyvind rpm-5.4.4-find-debuginfo-avoid-excessive-output-from-eu-strip.patch Description: Binary data

Some ruby 1.9 fixes

2013-08-26 Thread Per Øyvind Karlsen
This patch fixes compatibility with ruby 1.9. -- Regards, Per Øyvind rpm-5.4.9-ruby1.9-fixes.patch Description: Binary data

Don't include buildroot in list of duplicate files printed

2013-08-26 Thread Per Øyvind Karlsen
This patch will strip away the buildroot prefix for duplicate files listed, providing greater consistency with behaviour otherwise. -- Regards, Per Øyvind rpm-5.4.9-strip-buildroot-away-from-duplicate-files-list.patch Description: Binary data

Re: Fix rpm -qa \*foo\*

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 2:19 PM, Per Øyvind Karlsen wrote: The following patch fixes querying rpmdb with wildcards, whereas without this fix, it'll return all entries and not just those matching. The issue of wildcard queries is/was discussed years ago when implemented, and the behavior

Fix incorrect sizeof usage to get string length

2013-08-26 Thread Per Øyvind Karlsen
This patch fixes an incorrect attempt to get the string length with sizeof on a string allocated on the heap. -- Regards, Per Øyvind rpm-5.4.12-rpmfc-use-strlen-not-sizeof.patch Description: Binary data

Support terminate build on files listed twice.

2013-08-26 Thread Per Øyvind Karlsen
This patch adds support for termination builds with files listed twice by setting %_files_listed_twice_terminate_build -- Regards, Per Øyvind rpm-5.4.10-files-listed-twice-terminates-build.patch Description: Binary data

Only generate ruby and python deps for executables and modules

2013-08-26 Thread Per Øyvind Karlsen
This patch will make the dependency generator only generate ruby and python dependencies for executable and modules, this way preventing dependencies being generated for such as ie. private python files shipped with some package at some non-standard location, not meant to be available/exported for

Re: Don't display suggests with --requires

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 2:21 PM, Per Øyvind Karlsen wrote: This patch fixes so that soft dependencies won't be displayed with 'rpm -q --requires', only with 'rpm -q --suggests' This patch can be done (by masking RPMSENSE_MISSINGOK using awk) without changing any C code. I'm also very

Re: Fix rpm -qa \*foo\*

2013-08-26 Thread Per Øyvind Karlsen
2013/8/26 Jeffrey Johnson n3...@me.com On Aug 26, 2013, at 2:19 PM, Per Øyvind Karlsen wrote: The following patch fixes querying rpmdb with wildcards, whereas without this fix, it'll return all entries and not just those matching. The issue of wildcard queries is/was discussed years ago

Change default package suffix for debug packages to -debuginfo

2013-08-26 Thread Per Øyvind Karlsen
As -debuginfo is the most commonly used suffix for debug packages, there's also code with special behaviour for naming convention (see lib/dependens.c where '-debuginfo' rather than '-debug' is used, not to forget other software such as ie. gdb etc. also that expects this), this patch changes the

Re: Don't display suggests with --requires

2013-08-26 Thread Per Øyvind Karlsen
2013/8/26 Jeffrey Johnson n3...@me.com On Aug 26, 2013, at 2:21 PM, Per Øyvind Karlsen wrote: This patch fixes so that soft dependencies won't be displayed with 'rpm -q --requires', only with 'rpm -q --suggests' This patch can be done (by masking RPMSENSE_MISSINGOK using awk) without

Re: Don't include buildroot in list of duplicate files printed

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 2:24 PM, Per Øyvind Karlsen wrote: This patch will strip away the buildroot prefix for duplicate files listed, providing greater consistency with behaviour otherwise. While the approach is sensible, the deeper flaw is that duplicate file checks added by Alexey Tourbin

Make sure hdrfmt argv element is initialized

2013-08-26 Thread Per Øyvind Karlsen
This patch should be pretty self-explaining.. :) -- Regards, Per Øyvind rpm-5.4.7-hdrfmt-fix-unitialized-argv-element.patch Description: Binary data

Re: Don't include buildroot in list of duplicate files printed

2013-08-26 Thread Per Øyvind Karlsen
2013/8/26 Jeffrey Johnson n3...@me.com On Aug 26, 2013, at 2:24 PM, Per Øyvind Karlsen wrote: This patch will strip away the buildroot prefix for duplicate files listed, providing greater consistency with behaviour otherwise. While the approach is sensible, the deeper flaw is that

Fix minor memlead

2013-08-26 Thread Per Øyvind Karlsen
The following patch fixes a couple of minor memleaks. -- Regards, Per Øyvind rpm-5.4.7-fix-minor-memleaks.patch Description: Binary data

Fix miRE strings lacking null terminator

2013-08-26 Thread Per Øyvind Karlsen
This patch ensures that strings has a null terminator at end, otherwise strings passed to mireRegexec might be missing it. -- Regards, Per Øyvind rpm-5.4.9-mire-fix-strings-lacking-null-terminator.patch Description: Binary data

Fix typo in rpmtag.h

2013-08-26 Thread Per Øyvind Karlsen
Requires no explanation.. -- Regards, Per Øyvind rpm-5.4.9-fix-typo-in-rpmtag-header.patch Description: Binary data

Fix a couple of debugedit memleaks

2013-08-26 Thread Per Øyvind Karlsen
Simple enough.. -- Regards. Per Øyvind rpm-5.4.10-fix-a-couple-of-debugedit-memleaks.patch Description: Binary data

Re: Support for terminate build on duplicate files

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 2:25 PM, Per Øyvind Karlsen wrote: This patch enables termination of build on duplicate files by setting %_duplicate_files_terminate_build . This (and many other patches of yours) merely detect flaws which all have fairly simple resolutions that could be fully

Fix tagSwab handling of RPM_UINT64_TYPE

2013-08-26 Thread Per Øyvind Karlsen
This patch fixes tagSwab() to work with RPM_UINT64_TYPE. I'm not sure why it's not using newer functions (ie. from endian(3)) with support for 64 integers rather than using two 32 bit integers, but I guess it might be related to legacy compatibility..? And if so, is it still relevant, or should

Strip newlines from mono requires

2013-08-26 Thread Per Øyvind Karlsen
This patch strips newlines for mono dependencies generated that really shouldn't be there.. ;) -- Regards. Per Øyvind rpm-5.4.7-mono-find-requires-strip-newlines.patch Description: Binary data

Re: Silence excessive output from eu-strip

2013-08-26 Thread Jeffrey Johnson
The existing behavior of find-debuginfo.sh is already configurable: there is no One True Answer, nor is there any benefit to cosmetically removing errors from eu-strip. The far deeper flaw is that package executables are stripped multiple times even if no one has noticed. The entire means by

Fix rpm --verify segfault

2013-08-26 Thread Per Øyvind Karlsen
This fixes a segfault with --verify (IIRC on packages signed with old signature type). The bug is discussed at https://qa.mandriva.com/show_bug.cgi?id=64378 No definite consensus were ever achieved in previous discussions about the correct fix for this bug, but the patch does at least work (tm)

Don't remap i18n trings if enabled

2013-08-26 Thread Per Øyvind Karlsen
This patch disables remapping of i18n strings if support of is enabled. Considering i18n strings are getting phased out, the importance of this patch is of course rather diminishing, but at least it does fix what it's supposed to fix. :) -- Regards, Per Øyvind

Re: Some ruby 1.9 fixes

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 2:30 PM, Per Øyvind Karlsen wrote: This patch fixes compatibility with ruby 1.9. There are far far far deeper issues with ruby 1.8.x != 1.9.x behavior that need to be addressed. There is no consensus (no even a goal) stated that might lead to a more useful

Avoid double slashes in path for dirname trigger matching

2013-08-26 Thread Per Øyvind Karlsen
This patch ensures that double '/' doesn't end up in dirname paths triggers matched against. -- Regards, Per Øyvind rpm-5.4.9-avoid-double-slash-in-path-for-dirname-filetrigger-matching.patch Description: Binary data

Don't try generate rpmfc dependencies from doc files

2013-08-26 Thread Per Øyvind Karlsen
This patch prevents automatic dependencies from being generated for doc files. -- Regards, Per Øyvind rpm-5.4.12-dont-try-generate-rpmfc-dependencies-from-doc-files.patch Description: Binary data

Skip dependencies for block character devices

2013-08-26 Thread Per Øyvind Karlsen
This patch prevents dependencies being generated for block character devices. -- Regards, Per Øyvind rpm-5.4.5-skip-dependencies-for-character-devices.patch Description: Binary data

Actually link against internal lua

2013-08-26 Thread Per Øyvind Karlsen
This patch fixes an issue with internal lua not being linked against even if enabled. -- Regards, Per Øyvind rpm-5.4.7-actually-perform-linking-against-internal-lua.patch Description: Binary data

Apply python coloring from magic

2013-08-26 Thread Per Øyvind Karlsen
Add missing string reported by libmagic on some python files. -- Regards, Per Øyvind rpm-5.4.5-rpmfc-apply-python-coloring-from-magic.patch Description: Binary data

Don't add rpmlib(VersionedDependencies) feature dependency

2013-08-26 Thread Per Øyvind Karlsen
This patch comes from some discussion of ours longlong time ago about there no longer being any need for the rpmlib(VersionedDependencies) feature dependency.. So as I understood from you it being of no use, I yanked it locally in cooker at least.. :) -- Regards, Per Øyvind

Don't generate php dependencies on only executable php scripts

2013-08-26 Thread Per Øyvind Karlsen
Subject says it all.. rpm-5.4.5-dont-generate-php-dependencies-only-when-executable.patch Description: Binary data

Re: Fix incorrect sizeof usage to get string length

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 2:36 PM, Per Øyvind Karlsen wrote: This patch fixes an incorrect attempt to get the string length with sizeof on a string allocated on the heap. The line numbers and code both indicate that this patch is not against rpm5.org code. The proper fix here (imho) is _NOT_ to

find-debuginfo.sh: strip reloc debug sections

2013-08-26 Thread Per Øyvind Karlsen
Here's a patch from devzero2000 that got lost on HEAD... -- Regards, Per Øyvind rpm-5.4.9-find-debuginfo-strip-reloc-debug-sections.patch Description: Binary data

Set proper file color for scripts using env in shellbang

2013-08-26 Thread Per Øyvind Karlsen
I'm almost done with the first round of pushing (mainly ~pure) bug fix(/more trivial) patches for now.. -- Regards, Per Øyvind rpm-5.4.5-set-proper-file-color-for-scripts-using-env-in-shellbang.patch Description: Binary data

Re: Only generate ruby and python deps for executables and modules

2013-08-26 Thread Jeffrey Johnson
See my other comments regarding path based filtering, all of which is non-portable even in linux, where paths/needs are on a de facto per-interpreter, per-distro, and per-FHS-version basis. General rule based filtering on content (i.e. using man 5 magic strings), or a more general configuration

Update brp-compress with support for xz/lzma compression

2013-08-26 Thread Per Øyvind Karlsen
This patch adds support for compressing man info pages with xz or lzma compression. -- Regards, Per Øyvind rpm-5.4.10-update-and-use-brp-compress.patch Description: Binary data

Fix neon saving error pages as target file

2013-08-26 Thread Per Øyvind Karlsen
This patch fixes neon saving error pages when encountered to target file. I'm not entirely sure if this is the *correct* way to fix it though, but at least it does work... ;) On a related note, is neon failing to download whenever being redirected (ie. when downloading from sourceforge.net) a

Re: Fix rpm -qa \*foo\*

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 2:51 PM, Per Øyvind Karlsen wrote: 2013/8/26 Jeffrey Johnson n3...@me.com On Aug 26, 2013, at 2:19 PM, Per Øyvind Karlsen wrote: The following patch fixes querying rpmdb with wildcards, whereas without this fix, it'll return all entries and not just those matching.

Re: Change default package suffix for debug packages to -debuginfo

2013-08-26 Thread Jeffrey Johnson
This patch is to macro madness configuration. RPM is expected to be legacy compatible even if distros don't give a hoot about what packaging conventions/naming might have been in place when a distro was released. You have also pointed out that gdb, not rpm, is responsible for establishing

Re: Don't display suggests with --requires

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 3:06 PM, Per Øyvind Karlsen wrote: 2013/8/26 Jeffrey Johnson n3...@me.com On Aug 26, 2013, at 2:21 PM, Per Øyvind Karlsen wrote: This patch fixes so that soft dependencies won't be displayed with 'rpm -q --requires', only with 'rpm -q --suggests' This patch

Re: Make sure hdrfmt argv element is initialized

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 3:09 PM, Per Øyvind Karlsen wrote: This patch should be pretty self-explaining.. :) A reproducer please. This may (or may not) be the right pace to fix, and there may be other places in need of fixing. None of this is self-explanatory. I routinely run under valgrind and in

Re: Support terminate build on files listed twice.

2013-08-26 Thread R P Herrold
On Mon, 26 Aug 2013, Jeffrey Johnson wrote: See other comments: Resolving simple build flaws rather than detecting and terminating a build configurably is what is needed. Avoiding unexpected breakage and avoiding new support load models is a Good Thing (tm) I would write

Re: Fix miRE strings lacking null terminator

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 3:17 PM, Per Øyvind Karlsen wrote: This patch ensures that strings has a null terminator at end, otherwise strings passed to mireRegexec might be missing it. Is there a specific problem here? DO you have a reproducer? The use of alloca tells me that I applied a

Re: Fix typo in rpmtag.h

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 3:24 PM, Per Øyvind Karlsen wrote: Requires no explanation.. So _THAT_ is why the harmless message is being displayed. ;-) Applied, thanks. The better (and p[lanned) fix is to rip out all code marked with SUPPORT_I18NSTRING_TYPE now that distros have had almost 1.5y to

Re: Fix a couple of debugedit memleaks

2013-08-26 Thread Jeffrey Johnson
Send to @rpm.org. So far, I track _EXACTLY_ what the @redhat.com glibc cabal recommends with no other changes. And the entire debugedit code base, replacing NSS with BeeCrypt digests (the right fix is to add a SHA1 implementation to debugedit.c directly to simplify upgrading changes). I also

Fix variables getting overriden by /etc/os-release

2013-08-26 Thread Per Øyvind Karlsen
The follow patch fixes /etc/os-release being sourced right into same environment as the configure script runs in, meaning that any existing variables with same names as found in /etc/os-release gets overriden. This patch sources /etc/os-release and prints the $ID variable in a sub-shell in order

Re: Fix tagSwab handling of RPM_UINT64_TYPE

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 3:42 PM, Per Øyvind Karlsen wrote: This patch fixes tagSwab() to work with RPM_UINT64_TYPE. I'm not sure why it's not using newer functions (ie. from endian(3)) with support for 64 integers rather than using two 32 bit integers, but I guess it might be related to

Re: Fix variables getting overriden by /etc/os-release

2013-08-26 Thread Jeffrey Johnson
*shrug* applied The entire idea that one can specify a vendor reliably in a file for access portably by AutoCrap is naive. 73 de Jeff On Aug 26, 2013, at 5:27 PM, Per Øyvind Karlsen wrote: The follow patch fixes /etc/os-release being sourced right into same environment as the configure

Re: Fix rpm --verify segfault

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 3:52 PM, Per Øyvind Karlsen wrote: This fixes a segfault with --verify (IIRC on packages signed with old signature type). The bug is discussed at https://qa.mandriva.com/show_bug.cgi?id=64378 No definite consensus were ever achieved in previous discussions about the

Re: Don't try generate rpmfc dependencies from doc files

2013-08-26 Thread Jeffrey Johnson
See other comments regarding automagically filtering autodeps manifests based on either MIME suffix or paths. Its all fabulously fg=fragile and broken and needs to be implemented intelligently and generally, not ad hoc patches to fix Yet Another just realized convention. Note that the existing

Re: Skip dependencies for block character devices

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 4:04 PM, Per Øyvind Karlsen wrote: This patch prevents dependencies being generated for block character devices. Any packaging that includes block/char devices is intrinsically busted. Use %dev instead. Its been implememnted for a L-O-N-G time. 73 de Jeff --

Re: Actually link against internal lua

2013-08-26 Thread Jeffrey Johnson
Not the right fix afaict. lua is treated as a helper library and merged into librpmmisc when internal. But how lua gets linked into rpm is rather complicated. 73 de Jeff On Aug 26, 2013, at 4:05 PM, Per Øyvind Karlsen wrote: This patch fixes an issue with internal lua not being linked

Debugedit busted in rpm-5.4.13

2013-08-26 Thread Per Øyvind Karlsen
The following change breaks debugedit: http://rpm5.org/cvs/chngview?cn=17180 With this patch applied, debugedit will fail in following fashion: extracting debug info from /home/peroyvind/ABF/queue/augeas/BUILDROOT/augeas-1.0.0-4-mdk2013.0.x86_64-buildroot/lib64/libaugeas.so.0.16.0 Failed to

Re: Apply python coloring from magic

2013-08-26 Thread Jeffrey Johnson
Not the right fix. Here's why: RPM includes/uses magic strings returned from libmagic. For reproducible results, where external system magic changes arbitrarily, there are any number of problems that ensue because the (what used to be) /etc/magic text has changed. The only proper reproducible

Re: Don't add rpmlib(VersionedDependencies) feature dependency

2013-08-26 Thread Jeffrey Johnson
I'd love to apply this patch, but the ensuing legacy compatibility discussions would eat months of my time. So I choose my battles wisely, and won't apply the patch. tracking dependency is a polite euphemism for I-N-C-O-M-P-A-T-B-I-L-E invented to distract LSB (and others) from recognizing an

Re: Don't generate php dependencies on only executable php scripts

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 4:13 PM, Per Øyvind Karlsen wrote: Subject says it all.. Um no. I can't tell whether you have sent a reversed patch or are attempting a change in behavior. RPM SHOULD extract dependencies only from executable files. This is advertised behavior because of chmod -x

Re: Set proper file color for scripts using env in shellbang

2013-08-26 Thread Jeffrey Johnson
On Aug 26, 2013, at 4:21 PM, Per Øyvind Karlsen wrote: I'm almost done with the first round of pushing (mainly ~pure) bug fix(/more trivial) patches for now.. This has _NOTHING to do with file colors (because its a script). Only elf executables have colors. Meanwhile I have no desire to

Re: Update brp-compress with support for xz/lzma compression

2013-08-26 Thread Jeffrey Johnson
No interest because already there are huge amounts of breakage making *.spec files tied to per-distro choices of what compressor to invoke. I have to fix issues like this in nearly every Fedora package I look at, to replace explicit suffixes with a glob in %files manifests. Maintain outside of

Re: Some ruby 1.9 fixes

2013-08-26 Thread Elan Ruusamäe
Config vs RbConfig : https://github.com/ruby/ruby/blob/v1_9_3_327/lib/rbconfig/obsolete.rb#L4 so i understand 1.8.x (latest is 1.8.7 [1]) works with RbConfig too [2] ftp://ftp.ruby-lang.org/pub/ruby/1.8 On Mon, Aug 26, 2013 at 10:57 PM, Jeffrey Johnson n3...@me.com wrote: On Aug 26, 2013,

Re: Don't include buildroot in list of duplicate files printed

2013-08-26 Thread Jeffrey Johnson
I'm unconvinced that directories need to be treated differently than files. There has been %unpackaged_files_terminate_build since forever. I still believe that the macros need to be removed and the behavior needs to be made MANDATORY (if desired). Alexey Tourbin also implemented some