Currently rpm requires build ids to be between 16 and 64 bytes in size:
https://github.com/rpm-software-management/rpm/blob/b7d427728b8ba8734ba47d51849a5736bdd727cd/build/files.c#L1883
Since the main intention of build-id is to avoid accidentally using the wrong
binary, lld defaults to xxhash
dmnks commented on this pull request.
> @@ -238,11 +239,25 @@ static rpmtd makeSigTag(Header sigh, int ishdr, uint8_t
> *pkt, size_t pktlen)
return sigtd;
}
+pid_t gpgPid = 0;
Indeed. No rush!
Declaration fixed.
--
You are receiving this because you are subscribed to this thread.
@dmnks pushed 1 commit.
f4d2e9ebf21660ece2986879d6602fc7fa88aea3 Stop blocking when GPG process dies
prematurely (RhBug:1746353)
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
pmatilai commented on this pull request.
> @@ -238,11 +239,25 @@ static rpmtd makeSigTag(Header sigh, int ishdr, uint8_t
> *pkt, size_t pktlen)
return sigtd;
}
+pid_t gpgPid = 0;
I don't trust myself to do a proper review this late on Friday afternoon (and
neither should you) :smile:
Sorry for the delay; I just pushed a reworked version of this patch, please
re-review.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@dmnks pushed 1 commit.
1c92f7bbd135e60468dda7ff0e79cdc284dbeaa1 Stop blocking when GPG process dies
prematurely (RhBug:1746353)
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Possibly a straight up revert is the right thing to do. I was trying to keep
the intention of the previous patch as much as possible.
In terms of VFP/VFPv3 it is a requirement of ARMv8, but in theory (although I'm
not sure why you'd want to) you could have softfp builds on armv8 so to keep
Fixing a fix of a fix is always a bit of a red flag.
The unification in commit 8c3a7b8fa92b49a811fe36b60857b12f5d7db8a8 assumes that
we'll want to keep adding these modifier letters like 'h' forever more for all
new versions to come, but isn't VFP/VFPv3 capability a requirement in >= armv8
Try to auto-detect non-rotational disks on start of transactions,
and if all involved disks are non-rotational enable optimizations:
%_minimize_io to conserve writes, and %_flush_io to avoid trashing
the system caches.
Caveat: this potentially overrides values from system macro configuration
All these find/xargs combos should really be using -print0/-0 instead for weird
character safety. Those are not standard :astonished: but then neither is -d,
and -0 does exist on FreeBSD too.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
Hi,
Since this commit 09d181d78c16e1751779586c606e85c11f360407, `rpmbuild` will
have issues on FreeBSD. `xargs` does not have a -d option on FreeBSD.
Would it be possible to make this conditionally if it's not FreeBSD?
Thanks
--
You are receiving this because you are subscribed to this
11 matches
Mail list logo
