pmatilai commented on this pull request.
> @@ -238,11 +239,25 @@ static rpmtd makeSigTag(Header sigh, int ishdr, uint8_t
> *pkt, size_t pktlen)
return sigtd;
}
+pid_t gpgPid = 0;
I don't trust myself to do a proper review this late on Friday afternoon (and
neither should you) :smile: but just a quick comment: this variable needs to
be declared static, otherwise it'll end up visible in the library ABI.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/938#pullrequestreview-321583545_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
