Re: [Rpm-maint] [rpm-software-management/rpm] Enhance requires with version information from the build root. (PR #2372)

2023-02-05 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -542,6 +542,12 @@ Supplements: (%{name} = %{version}-%{release} and > langpacks-%{1})\ # Use internal dependency generator rather than external helpers? %_use_internal_dependency_generator1 +# +# Generate minimum versions for ELF

Re: [Rpm-maint] [rpm-software-management/rpm] Simplify + clean up rpmio thread enablement code (PR #2379)

2023-02-05 Thread Panu Matilainen
Merged #2379 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2379#event-8444504213 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Failed to delete files during the rmbuild execution (Issue #2380)

2023-02-05 Thread licunlong
> No, that commit is not the problem, it's just the messenger. > > See #1382 https://github.com/rpm-software-management/rpm/commit/b34333fa021c0ee7215714eeef96d1a2843ea08e changed the default behavior. Now users running `rpmbuild -ba *spec` will automatically remove the build directory, so

Re: [Rpm-maint] [rpm-software-management/rpm] Enhance requires with version information from the build root. (PR #2372)

2023-02-05 Thread Gordon Messmer
@gordonmessmer commented on this pull request. > + * a copy of the version number. + */ +static char *getLibtoolVer(const char *filename) +{ +const char *so; +char dest[PATH_MAX]; +int destsize = 0; +int found_digit = 0, found_dot = 0; + +destsize = readlink(filename, dest,

Re: [Rpm-maint] [rpm-software-management/rpm] Enhance requires with version information from the build root. (PR #2372)

2023-02-05 Thread Panu Matilainen
@pmatilai commented on this pull request. > + * a copy of the version number. + */ +static char *getLibtoolVer(const char *filename) +{ +const char *so; +char dest[PATH_MAX]; +int destsize = 0; +int found_digit = 0, found_dot = 0; + +destsize = readlink(filename, dest,

Re: [Rpm-maint] [rpm-software-management/rpm] Enhance requires with version information from the build root. (PR #2372)

2023-02-05 Thread Panu Matilainen
@pmatilai commented on this pull request. > +/* + * Rather than re-implement path searching for shared objects, use + * dlmopen(). This will still perform initialization and finalization + * functions, which isn't necessarily safe, so do that in a separate + * process. + */ +static char

Re: [Rpm-maint] [rpm-software-management/rpm] Enhance requires with version information from the build root. (PR #2372)

2023-02-05 Thread Gordon Messmer
@gordonmessmer commented on this pull request. > +/* + * Rather than re-implement path searching for shared objects, use + * dlmopen(). This will still perform initialization and finalization + * functions, which isn't necessarily safe, so do that in a separate + * process. + */ +static char

Re: [Rpm-maint] [rpm-software-management/rpm] Enhance requires with version information from the build root. (PR #2372)

2023-02-05 Thread Panu Matilainen
@pmatilai commented on this pull request. > +/* + * Rather than re-implement path searching for shared objects, use + * dlmopen(). This will still perform initialization and finalization + * functions, which isn't necessarily safe, so do that in a separate + * process. + */ +static char

Re: [Rpm-maint] [rpm-software-management/rpm] Enhance requires with version information from the build root. (PR #2372)

2023-02-05 Thread Gordon Messmer
@gordonmessmer commented on this pull request. > +/* + * Rather than re-implement path searching for shared objects, use + * dlmopen(). This will still perform initialization and finalization + * functions, which isn't necessarily safe, so do that in a separate + * process. + */ +static char

Re: [Rpm-maint] [rpm-software-management/rpm] Enhance requires with version information from the build root. (PR #2372)

2023-02-05 Thread Panu Matilainen
@pmatilai commented on this pull request. > +/* + * Rather than re-implement path searching for shared objects, use + * dlmopen(). This will still perform initialization and finalization + * functions, which isn't necessarily safe, so do that in a separate + * process. + */ +static char

Re: [Rpm-maint] [rpm-software-management/rpm] Failed to delete files during the rmbuild execution (Issue #2380)

2023-02-05 Thread Panu Matilainen
Closed #2380 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2380#event-8443809541 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Failed to delete files during the rmbuild execution (Issue #2380)

2023-02-05 Thread Panu Matilainen
No, that commit is not the problem, it's just the messenger. See https://github.com/rpm-software-management/rpm/issues/1382 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2380#issuecomment-1418551808 You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Failed to delete files during the rmbuild execution (Issue #2380)

2023-02-05 Thread xujing
It is confirmed that this problem is caused by b34333fa021c0ee7215714eeef96d1a2843ea08e. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2380#issuecomment-1418443920 You are receiving this because you are subscribed to this thread.

[Rpm-maint] [rpm-software-management/rpm] Failed to delete files during the rmbuild execution (Issue #2380)

2023-02-05 Thread xujing
When Non-privileged user was used to build the "rpm" package, the file deletion failed during the final rmbuild cleanup phase. The problem is caused by the lack of write permission on the testing directory. ``` ... [ 209s] Checking for unpackaged file(s): /usr/lib/rpm/check-files