Re: [Rpm-maint] [rpm-software-management/rpm] Implement merging of new key material when importing pubkeys (PR #3083)

2024-05-21 Thread Michael Schroeder
About that "legacy" name: how about changing it to "traditional"? It doesn't sound so negative and also suggests that the code is somewhat not state of the art. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)

2024-05-21 Thread Panu Matilainen
Oh, yup. I thought I made a further comment here but apparently didn't... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3085#issuecomment-2122295789 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Ensure noarch packages don't get debuginfo (PR #3116)

2024-05-21 Thread Michal Domonkos
Merged #3116 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3116#event-12877666577 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add Fedora integration CI job (Issue #3118)

2024-05-21 Thread Michal Domonkos
At that point, though, we might as well have a proper spec file and build an actual rpm package out of the sources, much like what Packit does... I need to think about this more. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add Fedora integration CI job (Issue #3118)

2024-05-21 Thread Michal Domonkos
Note that it might also turn out that many of our existing tests aren't compatible with e.g. redhat-rpm-config's macros, in which case we might need to either adjust those or disable them. -- Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Add Fedora integration CI job (Issue #3118)

2024-05-21 Thread Michal Domonkos
While testing rpm in a "sterile" environment where no distribution specific rpm configuration is present has its value, there are cases where integration with an actual distribution such as Fedora may reveal bugs in otherwise innocent looking patches, such as the just-discovered #3115. The

[Rpm-maint] [rpm-software-management/rpm] RFE: enable relevant debuginfo configs by default (Issue #3117)

2024-05-21 Thread Panu Matilainen
We're now by default enabling debug packages on Linux since 8535694599ee7f35747d44e2ea0a62dc5e8880e5 but there are a thousand tunables that are not. Go through the knobs and tunables and set reasonable presets. At least %_debuginfo_subpackages and %_debugsource_packages should be enabled by

Re: [Rpm-maint] [rpm-software-management/rpm] Ensure noarch packages don't get debuginfo (PR #3116)

2024-05-21 Thread Panu Matilainen
And now with a test-case... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3116#issuecomment-2122208337 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Ensure noarch packages don't get debuginfo (PR #3116)

2024-05-21 Thread Panu Matilainen
@pmatilai pushed 1 commit. 4631a3f4c03afbe41ef2a96c5d43a44a82e28b69 Ensure noarch packages don't get debuginfo -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3116/files/1eb269872142982dd21dce3015c2cd67d824e1e9..4631a3f4c03afbe41ef2a96c5d43a44a82e28b69 You are

[Rpm-maint] [rpm-software-management/rpm] Ensure noarch packages don't get debuginfo (PR #3116)

2024-05-21 Thread Panu Matilainen
Add back the %ifnarch noarch test overconfidently removed in commit 8535694599ee7f35747d44e2ea0a62dc5e8880e5, its more complicated than that. This is band-aid for #3115. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3116

[Rpm-maint] [rpm-software-management/rpm] %_enable_debug_packages can cause debuginfo on noarch packages (Issue #3115)

2024-05-21 Thread Panu Matilainen
Commit 8535694599ee7f35747d44e2ea0a62dc5e8880e5 hinged the entire debuginfo generation logic around %_enable_debug_packages, including getting it right (disabled) for noarch packages from the platform configuration macros. The problem with that, %_enable_debug_packages is *intended* to be a

[Rpm-maint] [rpm-software-management/rpm] RFE: proper error reporting for fsm operations (Issue #3114)

2024-05-21 Thread Panu Matilainen
#3100 started life as a report on unintelligible error message on install failure, and it's far from an isolated case. When an occurs inside the fsm, we save the path but not the errno. and when the error eventually does get reported there have been any arbitrary number of places that could,

Re: [Rpm-maint] [rpm-software-management/rpm] Replace rpmfi(les) hardlink discovery + lookup with STL containers (PR #3112)

2024-05-21 Thread Panu Matilainen
Merged #3112 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3112#event-12874452602 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint