Re: [Rpm-maint] [rpm-software-management/rpm] metainfo.attr: Fix execution of the generator (#1259)

2020-06-08 Thread Panu Matilainen
Thanks for the patch though. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1259#issuecomment-640429529___ Rpm-maint mailing

Re: [Rpm-maint] [rpm-software-management/rpm] metainfo.attr: Fix execution of the generator (#1259)

2020-06-08 Thread Panu Matilainen
Doh... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1259#issuecomment-640429423___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] metainfo.attr: Fix execution of the generator (#1259)

2020-06-08 Thread Panu Matilainen
Merged #1259 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1259#event-3418629316___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] %transfiletriggerin does not work on Fedora 33 (#1260)

2020-06-08 Thread Panu Matilainen
Okay, quite easily reproduced. Looks like our first reported bug in sqlite :beetle: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] error: Couldn't exec metainfo(): No such file or directory (#1261)

2020-06-08 Thread Parag Nemade
Thanks @ignatenkobrain I tested that patch, worked fine :+1: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)

2020-06-08 Thread Florian Festi
May be the macro should be renamed to not collide with the with/without mechanism. The bcond mechnism assumes that the actual value is not set as a macro but only on the command line and is basically read only within the spec. If you set the macro itself having two of them can lead to the

Re: [Rpm-maint] [rpm-software-management/rpm] error: Couldn't exec metainfo(): No such file or directory (#1261)

2020-06-08 Thread Igor Raits
Sent patch yesterday https://github.com/rpm-software-management/rpm/pull/1259 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)

2020-06-08 Thread Florian Festi
Did a PR for this on Friday. Comments on #1256 are welcome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)

2020-06-08 Thread Panu Matilainen
Most tools rpm interacts with don't *have* their own configuration, that's mostly limited to SCMs. It might well be sufficient set HOME to some temporary build directory during build scriptlets, or something like that. -- You are receiving this because you are subscribed to this thread. Reply

[Rpm-maint] [rpm-software-management/rpm] error: Couldn't exec metainfo(): No such file or directory (#1261)

2020-06-08 Thread Parag Nemade
Any package Fedora 33/rawhide build that involved installing metainfo files has started giving error in build.log e.g. See this scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=45537932 which shows line ```error: Couldn't exec metainfo(): No such file or directory```

[Rpm-maint] [rpm-software-management/rpm] Add support for dependency generators for RPMTAG_ORDERNAME (#1262)

2020-06-08 Thread Florian Festi
aka OrderWithRequires. Use __find_order in the attribute files Resolves: #1257 Please test! You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1262 -- Commit Summary -- * Add support for dependency generators for

Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)

2020-06-08 Thread torsava
I would like to avoid `nocheck`, because the common way to conditinalize would be `%if %{without nocheck}` and that's just confusing to read. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] %transfiletriggerin does not work on Fedora 33 (#1260)

2020-06-08 Thread Panu Matilainen
Just to record my findings so far: - *some* %transfiletriggerin scripts do run, but not all - on erasure, the triggers on the very same conditions that miss on install do run, eg ``` $ rpm -q --filetriggers hicolor-icon-theme transfiletriggerin scriptlet (using /bin/sh) --

Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-08 Thread Zbigniew Jędrzejewski-Szmek
> But why? If a package contains a config is /usr/lib/sysusers.d/, why not to > ensure that it is installed after systemd-sysusers binary is present and so > the scriptlet which creates users can be executed? Yes, in that case the dependency is warranted. > If there is just a scriptlet which

Re: [Rpm-maint] [rpm-software-management/rpm] error: Couldn't exec metainfo(): No such file or directory (#1261)

2020-06-08 Thread Igor Raits
Backported to rawhide & fixed in master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1261#issuecomment-640492804___

Re: [Rpm-maint] [rpm-software-management/rpm] error: Couldn't exec metainfo(): No such file or directory (#1261)

2020-06-08 Thread Igor Raits
Closed #1261. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1261#event-3419175160___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)

2020-06-08 Thread torsava
> I think this should set _with_check unless _without_check is defined already. > Basically to have `%bcond_without check` by default without having to put it > in all spec files. But still need to make sure that somebody defines > `%bcond_without check`, this code won't override it. That

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-08 Thread Colin Walters
@cgwalters commented on this pull request. > +state->logging = 1; + +/* ...don't log test transactions */ +if (rpmtsFlags(ts) & (RPMTRANS_FLAG_TEST|RPMTRANS_FLAG_BUILD_PROBS)) + state->logging = 0; + +/* ...don't log chroot transactions */ +if

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-08 Thread Jonathan Lebon
@jlebon commented on this pull request. > @@ -0,0 +1,25 @@ +'\" t +.TH "RPM-DBUS-ANNOUNCE" "8" "03 Jun 2020" "Red Hat, Inc." +.SH NAME +rpm-plugin-dbus-announce \- DBus plugin for the RPM Package Manager + +.SH Description + +The plugin writes basic information about rpm transactions to the

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-08 Thread Michael Schroeder
@mlschroe commented on this pull request. > +state->logging = 1; + +/* ...don't log test transactions */ +if (rpmtsFlags(ts) & (RPMTRANS_FLAG_TEST|RPMTRANS_FLAG_BUILD_PROBS)) + state->logging = 0; + +/* ...don't log chroot transactions */ +if (!rstreq(rpmtsRootDir(ts),

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-08 Thread Colin Walters
Is there any coordination between this and the work to add dbus to libdnf in https://github.com/rpm-software-management/libdnf/pull/941 for example? For rpm-ostree we are already a DBus daemon, and having multiple other libraries in the stack also going out and talking to DBus is going to be a