Re: [Rpm-maint] [rpm-software-management/rpm] Not ignoring generator failure shows strange issue (#1285)

2020-06-23 Thread soig
Adding: + printf("mname='%s', cmd='%s' (callable=%d)\n", mname, cmd, callable); Shows the following: grep _font RES1 -1 mname='__elf_provides', cmd='/usr/lib/rpm/elfdeps --provides ' (callable=0) mname='__font_provides', cmd=' ' (callable=0) mname='__gobjectintrospection_provides', cmd='/us

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

2020-06-23 Thread soig
Le mer. 24 juin 2020 à 08:38, Panu Matilainen a écrit : > On 6/24/20 9:30 AM, soig wrote: > > Also rpm's own fontconfig.prov is broken: > > > http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/updates_testing/20200624045432.daviddavid.duvel.28729/log/plasma-desktop-5.19.2-1.mga8/build.0.20

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

2020-06-23 Thread Panu Matilainen
On 6/23/20 5:16 PM, rpm-maint wrote: > Architecture is hardcoded in test and thus it fails on anything not x86_64 > :-( > > See > http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623135516.tv.duvel.30441/log/rpm-4.16.0-0.beta2.1.mga8/build.0.20200623135605.log > > --- - 2020

[Rpm-maint] [rpm-software-management/rpm] Not ignoring generator failure shows strange issue (#1285)

2020-06-23 Thread soig
rpm's own fontconfig.prov is broken: http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/updates_testing/20200624045432.daviddavid.duvel.28729/log/plasma-desktop-5.19.2-1.mga8/build.0.20200624045513.log http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623223351.luigiwals

[Rpm-maint] [rpm-software-management/rpm] Architecture is hardcoded in new test and thus it fails on anything not x86_64 :-( (#1284)

2020-06-23 Thread soig
Architecture is hardcoded in test and thus it fails on anything not x86_64 :-( See http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623135516.tv.duvel.30441/log/rpm-4.16.0-0.beta2.1.mga8/build.0.20200623135605.log --- - 2020-06-23 13:59:13.826080861 + +++ /home/iurt/

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

2020-06-23 Thread Panu Matilainen
On 6/24/20 9:30 AM, soig wrote: > Also rpm's own fontconfig.prov is broken: > http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/updates_testing/20200624045432.daviddavid.duvel.28729/log/plasma-desktop-5.19.2-1.mga8/build.0.20200624045513.log > http://pkgsubmit.mageia.org/uploads/failure/cau

[Rpm-maint] [rpm-software-management/rpm] Fix depgen failure test to be architecture independent, doh (#1283)

2020-06-23 Thread Panu Matilainen
Nobody noticed the test-results being x86_64-specific due to buildroot path getting exposed, what a dumb cause... Override the default buildroot definition to make it arch-independent for these cases. Fixes: fb5299b2a49460216c38674b7398296d3a6d767c You can view, comment on, or merge this pull requ

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

2020-06-23 Thread soig
Ex: $ sudo mv /usr/lib/rpm/fileattrs/font.attr{,.no} $ LC_ALL=C rpmbuild --short-circuit --define "_topdir $PWD" -ba SPECS/feh.spec (…) Wrote: /home/tv/mga/pkgs/feh/RPMS/x86_64/feh-3.4.1-1.mga8.x86_64.rpm Wrote: /home/tv/mga/pkgs/feh/RPMS/x86_64/feh-debugsource-3.4.1-1.mga8.x86_64.rpm Wrote: /home

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

2020-06-23 Thread soig
Also rpm's own fontconfig.prov is broken: http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/updates_testing/20200624045432.daviddavid.duvel.28729/log/plasma-desktop-5.19.2-1.mga8/build.0.20200624045513.log http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623223351.luig

Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)

2020-06-23 Thread Panu Matilainen
@pmatilai approved this pull request. Ok, I think we're good to go now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/938#pullrequestreview-436342767___

Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)

2020-06-23 Thread Panu Matilainen
Merged #938 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/938#event-3475894319___ Rpm-maint mailing list Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)

2020-06-23 Thread Michal Domonkos
Rebased and fixed the `%m` thing. Apologies for the long "round-trip delay time" on this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/938#issuecomment-648253508_

Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)

2020-06-23 Thread Michal Domonkos
@dmnks pushed 2 commits. 5b3831f7d5d76bfefcd2a28a5aabddc39866da19 GPG: Switch back to pipe(7) for signing e91e2ad55e18131aea621f3c2e6772bc891d1aa4 GPG: refactor: clean up exit label -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm

Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)

2020-06-23 Thread Michal Domonkos
@dmnks commented on this pull request. > if (gpg_path && *gpg_path != '\0') (void) setenv("GNUPGHOME", gpg_path, 1); + if (tty) + setenv("GPG_TTY", tty, 0); + else if (!getenv("GPG_TTY")) + rpmlog(RPMLOG_WARNING, _("Could not set GPG_TTY to

Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)

2020-06-23 Thread Michal Domonkos
@dmnks pushed 2 commits. 7080e2456d513d54538129a4d414848591b49508 GPG: Switch back to pipe(7) for signing 5e81da9a19f576ad35d6358ed3d29787f8a708cc GPG: refactor: clean up exit label -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm

Re: [Rpm-maint] [Rpm-announce] RPM 4.16.0 beta2 released!

2020-06-23 Thread Thierry Vignaud
Le mar. 23 juin 2020 à 14:41, Panu Matilainen a écrit : > > Some fairly important fixes cropped up in the last few weeks so we > decided to go with a second beta for a change. The highlights since > beta1 include: > > - fix hardlink breakage on upgrade when minimize_writes is enabled > - fix some

[Rpm-maint] Announcing POPT upstream reboot and 1.18 release!

2020-06-23 Thread Panu Matilainen
At the time of the rpm.org upstream reboot back in 2006 [1], the idea was to split out popt from the rpm codebase and then ... something. Only we were too busy dealing with rpm itself and popt got left behind. The last popt release is from 2010 and about a year ago it's download site dropped of

[Rpm-maint] RPM 4.16.0 beta2 released!

2020-06-23 Thread Panu Matilainen
Some fairly important fixes cropped up in the last few weeks so we decided to go with a second beta for a change. The highlights since beta1 include: - fix hardlink breakage on upgrade when minimize_writes is enabled - fix some file triggers missed with sqlite backend - fix SSD optimizations

Re: [Rpm-maint] [rpm-software-management/rpm] Rpm 4.16 beta2 (#1281)

2020-06-23 Thread Panu Matilainen
Merged #1281 into rpm-4.16.x. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1281#event-3472632758___ Rpm-maint mailing list Rpm

Re: [Rpm-maint] [rpm-software-management/rpm] Rpm 4.16 beta2 (#1281)

2020-06-23 Thread lgtm-com[bot]
This pull request **fixes 1 alert** when merging 5936122a35ed522f2c59fa656506a44d86a7270f into e50e0a8fe9f7976a00a2909f72a300cec97b82d4 - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-30aaffc331b8ddb00e701d925951e97cc1586cdf) **fixed alerts:** * 1 for Unnece

Re: [Rpm-maint] [rpm-software-management/rpm] Rpm 4.16 beta2 (#1281)

2020-06-23 Thread Panu Matilainen
@pmatilai pushed 2 commits. 43a4608d2b0012b1799d6de8366bc1762c80af48 Update popt download location 2bb712eb584e36161ddb521f991cba1312403f05 Preparing for rpm 4.16.0-beta2 -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-ma

Re: [Rpm-maint] [rpm-software-management/rpm] Update popt download location (#1282)

2020-06-23 Thread Panu Matilainen
Merged #1282 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1282#event-3472572629___ Rpm-maint mailing list Rpm-mai

[Rpm-maint] [rpm-software-management/rpm] Update popt download location (#1282)

2020-06-23 Thread Panu Matilainen
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1282 -- Commit Summary -- * Update popt download location -- File Changes -- M INSTALL (4) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1282.p

Re: [Rpm-maint] [rpm-software-management/rpm] Discussion: How to handle Python extras (#1061)

2020-06-23 Thread Miro Hrončok
We have proposed this in Fedora: https://fedoraproject.org/wiki/Changes/PythonExtras -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1061#issuecomment-648082385__

Re: [Rpm-maint] [rpm-software-management/rpm] Rpm 4.16 beta2 (#1281)

2020-06-23 Thread lgtm-com[bot]
This pull request **fixes 1 alert** when merging 1434c21c450b77de1fe7d73e2e74d50c25aa587a into e50e0a8fe9f7976a00a2909f72a300cec97b82d4 - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-84871d636d7ad0c5305651d5d4151647befc5b71) **fixed alerts:** * 1 for Unnece

[Rpm-maint] [rpm-software-management/rpm] Rpm 4.16 beta2 (#1281)

2020-06-23 Thread Panu Matilainen
Pull various important fixes + the test-suite parallelisation effort to avoid having to deal with test conflicts with upstream for the 4.16 lifetime. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1281 -- Commit Summary --

Re: [Rpm-maint] [rpm-software-management/rpm] Package upgrades break if hardlinks got added (#1278)

2020-06-23 Thread Fabian Vogt
Thanks for the quick fix! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1278#issuecomment-648050421___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Package upgrades break if hardlinks got added (#1278)

2020-06-23 Thread Panu Matilainen
Thanks for reporting and the nice reproducer! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1278#issuecomment-648046616___ Rp

Re: [Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)

2020-06-23 Thread Panu Matilainen
Merging as is for now, thanks for the patch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1246#issuecomment-648045721___ Rpm-m

Re: [Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)

2020-06-23 Thread Panu Matilainen
Merged #1246 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1246#event-3472197426___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Add --excludeartifacts install option (#1274)

2020-06-23 Thread Panu Matilainen
Merged #1274 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1274#event-3472180157___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Don't install man pages for disabled features (#1280)

2020-06-23 Thread Panu Matilainen
Merged #1280 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1280#event-3472165281___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Package upgrades break if hardlinks got added (#1278)

2020-06-23 Thread Panu Matilainen
Closed #1278 via #1279. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1278#event-3472164919___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Account for symlinks in total package size (RhBug:1848199) (#1275)

2020-06-23 Thread Panu Matilainen
Merged #1275 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1275#event-3472164261___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Fix (work around) FA_TOUCH not scoping correctly over hardlinks (#1279)

2020-06-23 Thread Panu Matilainen
Merged #1279 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1279#event-3472164907___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)

2020-06-23 Thread Panu Matilainen
Closed #1183 via #1271. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#event-3472161387___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

2020-06-23 Thread Panu Matilainen
Merged #1271 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1271#event-3472161361___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] only install rpm-plugin-selinux.8 if enabled (#1247)

2020-06-23 Thread Panu Matilainen
Closed #1247. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1247#event-3471955830___ Rpm-maint mailing list Rpm-maint@lists.rpm

Re: [Rpm-maint] [rpm-software-management/rpm] only install rpm-plugin-selinux.8 if enabled (#1247)

2020-06-23 Thread Panu Matilainen
As mentioned earlier, if we do this for one conditional thing we should do it for all of them, and also this would cause the selinux manual to be skipped from the dist tarball too depending on the enable/disable status, which is wrong. A more complete patch submitted as PR #1280, but thanks for

[Rpm-maint] [rpm-software-management/rpm] Don't install man pages for disabled features (#1280)

2020-06-23 Thread Panu Matilainen
Doesn't make much sense to install manuals for features that are not enabled in a build. Conditionalize our man page installation where necessary, taking care to include the manuals in tarballs regardless of configured status. Inspired by PR (#1247) from Thierry Vignaud You can view, comment on, o

Re: [Rpm-maint] [rpm-software-management/rpm] Make the "rpmbuild debuginfo -g3 .debug_macro" test an expected fail … (#1267)

2020-06-23 Thread ニール・ゴンパ
@pmatilai It would definitely be nice to wire up some clang testing, since OpenMandriva and macOS use clang as the default compiler -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-manageme

Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild should report missing files for all subpackages (#1277)

2020-06-23 Thread mokraemer
I think it depends. I had packaged MariaDB, which is big too. And they change a lot of things during each minor release. To get all changes I had to do the rebuilt for 10 times. Each one consuming 30 minutes. If I had all missing/duplicate files at once, I think this can be done in 2 rebuilds.

[Rpm-maint] [rpm-software-management/rpm] Fix (work around) FA_TOUCH not scoping correctly over hardlinks (#1279)

2020-06-23 Thread Panu Matilainen
The existing FSM code doesn't correctly handle FA_TOUCH on hardlinked file sets, which causes the hardlink set to break on at least some upgrade scenarios when minimize_writes is enabled. Only enable FA_TOUCH on non-hardlinked files to work around the issue for now. While at it, rearrange the cond