Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@torsava commented on this pull request. > @@ -11,6 +11,10 @@ # RPM python dependency generator, using .egg-info/.egg-link/.dist-info data # +# Please know: +# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in +# 2020 can be found in the message of the commit that added this line. > I see this by a wrong comment, but +1. What do you mean by that? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415943934___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@hroncok commented on this pull request. > @@ -11,6 +11,10 @@ # RPM python dependency generator, using .egg-info/.egg-link/.dist-info data # +# Please know: +# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in +# 2020 can be found in the message of the commit that added this line. I see this by a wrong comment, but +1. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415943074___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@Conan-Kudo commented on this pull request. > @@ -11,6 +11,10 @@ # RPM python dependency generator, using .egg-info/.egg-link/.dist-info data # +# Please know: +# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in +# 2020 can be found in the message of the commit that added this line. LGTM -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415936789___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@torsava commented on this pull request. > @@ -11,6 +11,10 @@ # RPM python dependency generator, using .egg-info/.egg-link/.dist-info data # +# Please know: +# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in +# 2020 can be found in the message of the commit that added this line. @Conan-Kudo @hroncok WDYT? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415926110___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
This pull request **introduces 1 alert** when merging e7cc87a083366439c0450c720ed36475b09d into 9a30bcdacca365a6d8c4078dc6b6f8014d31d66f - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-6a72d51c59c7dece06617335d467976326e344fd) **new alerts:** * 1 for Module is imported more than once -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-620054580___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
> Any new sources need to be EXTRA_DIST in Makefile.am's. I've added the checked-in files to the `EXTRA_DIST` in the fixup commit. I didn't add the automatically-downloaded metadata, as the test script will automatically fetch them if missing. If it's desirable to have them inside EXTRA_DIST as well, let me know. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-620050790___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@torsava pushed 1 commit. e7cc87a083366439c0450c720ed36475b09d fixup! scripts/pythondistdeps: Add the tests to the readme and makefile -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195/files/96be70abdb8f5b7633fb41829a8b5d496a466e03..e7cc87a083366439c0450c720ed36475b09d ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
This pull request **introduces 1 alert** when merging 96be70abdb8f5b7633fb41829a8b5d496a466e03 into 9a30bcdacca365a6d8c4078dc6b6f8014d31d66f - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-37240692b220d858f7c84048312ded371ecb5b9f) **new alerts:** * 1 for Module is imported more than once -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-619945878___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@torsava commented on this pull request. > @@ -11,6 +11,10 @@ # RPM python dependency generator, using .egg-info/.egg-link/.dist-info data # +# Please know: +# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in +# 2020 can be found in the message of the commit that added this line. Implemented to support both ways, see the latest fixup commit. And I've added tests for these cases: --provides --majorver-provides-versions 3.9 --majorver-provides-versions 2.7 --provides --majorver-provides-versions 3.9,2.7 --provides --majorver-provides-versions 3.9,2.7 --majorver-provides-versions 3.10 --provides --majorver-provides-versions 3.9 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415748782___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@torsava pushed 1 commit. 96be70abdb8f5b7633fb41829a8b5d496a466e03 fixup! scripts/pythondistdeps: Add option to generate major-version provides only for specified Python versions -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195/files/dbc365b59207f4b00624241ae25542dd3f0a83cd..96be70abdb8f5b7633fb41829a8b5d496a466e03 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@Conan-Kudo commented on this pull request.
> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+ reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group = parser.add_mutually_exclusive_group(required=True)
+group.add_argument('-P', '--provides', action='store_true', help='Print
Provides')
+group.add_argument('-R', '--requires', action='store_true', help='Print
Requires')
+group.add_argument('-r', '--recommends', action='store_true', help='Print
Recommends')
+group.add_argument('-C', '--conflicts', action='store_true', help='Print
Conflicts')
+group.add_argument('-E', '--extras', action='store_true', help='Print
Extras')
+group_majorver = parser.add_mutually_exclusive_group()
+group_majorver.add_argument('-M', '--majorver-provides',
action='store_true', help='Print extra Provides with Python major version only')
+group_majorver.add_argument('--majorver-provides-versions', action='store',
Hmm, okay 👍
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415697446___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@torsava commented on this pull request.
> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+ reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group = parser.add_mutually_exclusive_group(required=True)
+group.add_argument('-P', '--provides', action='store_true', help='Print
Provides')
+group.add_argument('-R', '--requires', action='store_true', help='Print
Requires')
+group.add_argument('-r', '--recommends', action='store_true', help='Print
Recommends')
+group.add_argument('-C', '--conflicts', action='store_true', help='Print
Conflicts')
+group.add_argument('-E', '--extras', action='store_true', help='Print
Extras')
+group_majorver = parser.add_mutually_exclusive_group()
+group_majorver.add_argument('-M', '--majorver-provides',
action='store_true', help='Print extra Provides with Python major version only')
+group_majorver.add_argument('--majorver-provides-versions', action='store',
> I'm mostly thinking of potential field parsing bugs. I'm thinking of if
> people call it twice with two comma separated lists. I don't know if we
> really want to make that case possible...
The reason I'm suggesting it is that `--majorver-provides-versions` doesn't
have a short form (and it's so specific that I don't think it should), and it
would result in very long calls, e.g. in Fedora we would need:
--provides --majorver-provides-versions 2.7 --majorver-provides-versions
3.8 --normalized-names-format pep503 --normalized-names-provide-both
I can actually make a test for all the possible ways to call
`--majorver-provides-versions` so it should be safe to implement it both ways.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415696889___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
> Any new sources need to be EXTRA_DIST in Makefile.am's. For a moment I was > puzzling as to how come this is passing dist-check when the added sources are > missing in the release tarball, but then realized the added tests are not > getting run in _our_ test-suite. Which to me kinda steps over a certain line. That is not on purpose, I would love if these tests were also run as part of the upstream test-suite. I thought about hooking it into `make check`. I didn't do it for 2 reasons: 1. These tests require new dependencies, and I wasn't sure if you would want to tie the rpm test suite to the pythondistdeps testing dependencies. This way there's a specific way to run the pythondistdeps test (and perhaps other scripts/ tests later) using `make check-scripts` that can be just added to the CI bot if desired. 2. The makefile machinery for `make test` is a bit too confusing to me to easily add to. However, a separate repo would also work. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-619883458___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@Conan-Kudo commented on this pull request. > @@ -11,6 +11,10 @@ # RPM python dependency generator, using .egg-info/.egg-link/.dist-info data # +# Please know: +# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in +# 2020 can be found in the message of the commit that added this line. It's definitely the first. 🤣 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415688461___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@hroncok commented on this pull request. > @@ -11,6 +11,10 @@ # RPM python dependency generator, using .egg-info/.egg-link/.dist-info data # +# Please know: +# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in +# 2020 can be found in the message of the commit that added this line. Possible meanings of the emoji: - @Conan-Kudo is sad about the conclusion, but respects the way it was figured out. - The way this information is presented is making @Conan-Kudo sad. - @Conan-Kudo doesn't agree with the arguments presented in that commit message. - @Conan-Kudo is sad about current world situation and presented it here by accident. I hope it is the first listed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415687829___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@Conan-Kudo commented on this pull request.
> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+ reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group = parser.add_mutually_exclusive_group(required=True)
+group.add_argument('-P', '--provides', action='store_true', help='Print
Provides')
+group.add_argument('-R', '--requires', action='store_true', help='Print
Requires')
+group.add_argument('-r', '--recommends', action='store_true', help='Print
Recommends')
+group.add_argument('-C', '--conflicts', action='store_true', help='Print
Conflicts')
+group.add_argument('-E', '--extras', action='store_true', help='Print
Extras')
+group_majorver = parser.add_mutually_exclusive_group()
+group_majorver.add_argument('-M', '--majorver-provides',
action='store_true', help='Print extra Provides with Python major version only')
+group_majorver.add_argument('--majorver-provides-versions', action='store',
I'm mostly thinking of potential field parsing bugs. I'm thinking of if people
call it twice with two comma separated lists. I don't know if we really want to
make that case possible...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415687029___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@hroncok commented on this pull request.
> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+ reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group = parser.add_mutually_exclusive_group(required=True)
+group.add_argument('-P', '--provides', action='store_true', help='Print
Provides')
+group.add_argument('-R', '--requires', action='store_true', help='Print
Requires')
+group.add_argument('-r', '--recommends', action='store_true', help='Print
Recommends')
+group.add_argument('-C', '--conflicts', action='store_true', help='Print
Conflicts')
+group.add_argument('-E', '--extras', action='store_true', help='Print
Extras')
+group_majorver = parser.add_mutually_exclusive_group()
+group_majorver.add_argument('-M', '--majorver-provides',
action='store_true', help='Print extra Provides with Python major version only')
+group_majorver.add_argument('--majorver-provides-versions', action='store',
I agree that we don't *need* it. How big difference it is if we *support* it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415685949___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@Conan-Kudo commented on this pull request.
> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+ reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group = parser.add_mutually_exclusive_group(required=True)
+group.add_argument('-P', '--provides', action='store_true', help='Print
Provides')
+group.add_argument('-R', '--requires', action='store_true', help='Print
Requires')
+group.add_argument('-r', '--recommends', action='store_true', help='Print
Recommends')
+group.add_argument('-C', '--conflicts', action='store_true', help='Print
Conflicts')
+group.add_argument('-E', '--extras', action='store_true', help='Print
Extras')
+group_majorver = parser.add_mutually_exclusive_group()
+group_majorver.add_argument('-M', '--majorver-provides',
action='store_true', help='Print extra Provides with Python major version only')
+group_majorver.add_argument('--majorver-provides-versions', action='store',
Do we need comma-separated entries if we use `append`? Most people would call
it at most twice.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415685129___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@torsava commented on this pull request.
> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+ reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group = parser.add_mutually_exclusive_group(required=True)
+group.add_argument('-P', '--provides', action='store_true', help='Print
Provides')
+group.add_argument('-R', '--requires', action='store_true', help='Print
Requires')
+group.add_argument('-r', '--recommends', action='store_true', help='Print
Recommends')
+group.add_argument('-C', '--conflicts', action='store_true', help='Print
Conflicts')
+group.add_argument('-E', '--extras', action='store_true', help='Print
Extras')
+group_majorver = parser.add_mutually_exclusive_group()
+group_majorver.add_argument('-M', '--majorver-provides',
action='store_true', help='Print extra Provides with Python major version only')
+group_majorver.add_argument('--majorver-provides-versions', action='store',
`append` shouldn't be a problem. `extend` however, swallows unlimited number of
arguments, which could interfere with positional arguments, so I'd rather avoid
it. How about using `append` and also keeping the option for comma-separated
entries?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1195#discussion_r415683331___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@pmatilai I wish you were right, but in practice that is not what has happened. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-619873262___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
> Ultimately, the problem is that it not being in the rpm tarball means I have > no hammer to get people to discover it and use it. Unfortunately, the only > standardization point is in rpm itself. I would argue the opposite: people interested in Python are more likely to find and contribute to a python-specific project than this weird rpm thing with its archaic build- and test systems and all. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-619872675___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Document all of rpmdeps options (#1157)
@pmatilai approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1157#pullrequestreview-400792284___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Document all of rpmdeps options (#1157)
Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1157#issuecomment-619865055___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Document all of rpmdeps options (#1157)
Merged #1157 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1157#event-3274920498___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
@hroncok Ultimately, the problem is that it not being in the rpm tarball means I have no hammer to get people to discover it and use it. Unfortunately, the only standardization point is in rpm itself. I hesitate to split it out after spending so much work integrating it into rpm upstream to get everyone to start using it... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-619864395___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
Having a separate repo here is actually not a compromise but IMHO the preferred option. rpm-extras was thought more as an interim solution for scripts that don't have a large enough contributor base to be projects on their own. Even better if people from multiple distributions can share the ownership of the repo. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-619862405___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
Totally fine by me. @torsava @Conan-Kudo @gordonmessmer @ignatenkobrain @s-t-e-v-e-n-k WDYT? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-619859881___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
> Maybe there might be a compromise by having a separate repo in the > rpm-software-management namespace? That could be an option, and would be absolutely fine by me if it makes sense for the Python "SIG" around here. rpm-extras was supposed to be the place for scripts like these, but it's not catching on. And the way I see it, when a thing is mature enough to grow its own test-suite ecosystem, maybe its time for the parents to let go :sweat_smile: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-619855467___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Document all of rpmdeps options (#1157)
2nd commit has been droped -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1157#issuecomment-619849387___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
> We talk about upstreaming changes like this, but to me the situation looks > pretty much the opposite: this has an active upstream of its own and we're > merely syncing it from time to time, which is doing double work for ... I > don't know what. We are happy to maintain this ourselves. The idea was that if this lives here, other distros will use it (see the recent contribution by SUSE). Maybe there might be a compromise by having a separate repo in the rpm-software-management namespace? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-619841494___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)
Any new sources need to be EXTRA_DIST in Makefile.am's. For a moment I was puzzling as to how come this is passing dist-check when the added sources are missing in the release tarball, but then realized the added tests are not getting run in *our* test-suite. Which to me kinda steps over a certain line. We talk about upstreaming changes like this, but to me the situation looks pretty much the opposite: this has an active upstream of its own and we're merely syncing it from time to time, which is doing double work for ... I don't know what. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-619839716___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Unclosed %if (when defined inside %define) (#1198)
Ack, thanks for chasing that down. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1198#issuecomment-619789939___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Unclosed %if (when defined inside %define) (#1198)
5f4fdce3041b80ef26e3a87db07ecdbd2041a9b2 is the first bad commit commit 5f4fdce3041b80ef26e3a87db07ecdbd2041a9b2 Author: Pavlina Moravcova Varekova Date: Mon Jul 1 13:06:35 2019 +0200 Parse multiline conditional and %include parameters correctly (#775) Trailing '\' after multiline conditionals or %include will be trimmed. After the patch lines like: %if 1 && ( 2 || \ 3 ) %endif will be parsed correctly. The other lines stay unchanged. A test is added. build/parseSpec.c | 25 +++-- tests/Makefile.am | 1 + tests/data/SPECS/ifmultiline.spec | 28 tests/rpmmacro.at | 12 4 files changed, 60 insertions(+), 6 deletions(-) create mode 100644 tests/data/SPECS/ifmultiline.spec -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1198#issuecomment-619787090___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Unclosed %if (when defined inside %define) (#1198)
It also happens in 4.15, but not 4.14. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1198#issuecomment-619785696___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Unclosed %if (when defined inside %define) (#1198)
```
Name: hello
Version: 1
Release: 1%{?dist}
Summary: Hello
License: Public Domain
URL: https://google.com
%if 0%{?foo} >= 8
%define test() \
%if 1\
BUG\
%endif\
%{nil}
%endif
%description
%{summary}.
%prep
%autosetup -c -T
%files
```
Make sure that `foo` is not defined in your environment.
This produces:
```
error: line 9: Unclosed %if
```
This is happening with `rpm-build-4.15.90-0.git14971.8.fc33.x86_64`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1198___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
