Re: [Rpm-maint] [rpm-software-management/rpm] Various python fixes (#71)

2016-06-09 Thread Igor Gnatenko
@ffesti have you looked into results of the CI? ;) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/71#issuecomment-224881810___

[Rpm-maint] [rpm-software-management/rpm] rpm/transaction: move from __future__ to the top (#72)

2016-06-09 Thread Igor Gnatenko
`` Signed-off-by: Igor Gnatenko <ignate...@redhat.com> You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/72 -- Commit Summary -- * rpm/transaction: move from __future__ to the top -- File Changes -- M python/rpm/t

Re: [Rpm-maint] [rpm-software-management/rpm] testing GHPRB (#67)

2016-05-25 Thread Igor Gnatenko
@lkardos @ffesti could you close it? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/67#issuecomment-221625737___ Rpm-maint

[Rpm-maint] [rpm-software-management/rpm] rpmplugins: don't print error if return code is RPMRC_NOTFOUND (#75)

2016-07-26 Thread Igor Gnatenko
. Signed-off-by: Igor Gnatenko <ignate...@redhat.com> You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/75 -- Commit Summary -- * rpmplugins: don't print error if return code is RPMRC_NOTFOUND -- File Changes --

Re: [Rpm-maint] [rpm-software-management/rpm] let debuginfo packages provide the build-id (#77)

2016-08-03 Thread Igor Gnatenko
just tested it, fixed and it just works! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/77#issuecomment-237198405___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] let debuginfo packages provide the build-id (#77)

2016-08-03 Thread Igor Gnatenko
P.S. I didn't tested it yet. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/77#issuecomment-237186367___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] let debuginfo packages provide the build-id (#77)

2016-08-03 Thread Igor Gnatenko
This patch lets debuginfo packages provide build-id like follows: debuginfo(build-id) = c63cb23876c5fa85f36beaff58f8557e1bf22517 Originally this patch was written by Jan Blunck <jblu...@suse.de>. Signed-off-by: Igor Gnatenko <ignate...@redhat.com> You can view, comment on, or mer

[Rpm-maint] [rpm-software-management/rpm] configure.ac: use LIBDW always conditionally (#78)

2016-08-10 Thread Igor Gnatenko
References: https://bugzilla.redhat.com/show_bug.cgi?id=1365278 Reported-and-tested-by: Neal Gompa <ngomp...@gmail.com> Signed-off-by: Igor Gnatenko <i.gnatenko.br...@gmail.com> You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-managem

Re: [Rpm-maint] [rpm-software-management/rpm] configure.ac: use LIBDW always conditionally (#78)

2016-08-10 Thread Igor Gnatenko
@ffesti note, that I didn't tested it. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/78#issuecomment-238846047___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Macros in script comments are expanded (#140)

2017-01-30 Thread Igor Gnatenko
Use `%%autopatch` to escape macro. But join #124 for discussion of possible solutions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Macros in script comments are expanded (#140)

2017-01-30 Thread Igor Gnatenko
Closed #140. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/140#event-940971516___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] RPM must kill all childs on exit (from section?) (#134)

2017-01-28 Thread Igor Gnatenko
@voxik try to compile package as I showed above. You run something in background from RPM, you get RPMs, but process is still running which is IMO not acceptable. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] RPM must kill all childs on exit (from section?) (#134)

2017-01-28 Thread Igor Gnatenko
Imagine, we have some stupid program which forks and doesn't exit until we send SIGTERM/SIGKILL, so build finishes, but process is still running. easy way to reproduce is just run `./hang &` from `%check`. I think @voxik has some real example in mongodb build while I have only dummy one:

[Rpm-maint] [rpm-software-management/rpm] Check return value of uname() (#132)

2017-01-20 Thread Igor Gnatenko
Everyone knows that it can fail... You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/132 -- Commit Summary -- * rpmrc: don't run uname() second time * rpmio: check return value of uname() -- File Changes -- M

Re: [Rpm-maint] [rpm-software-management/rpm] Check return value of uname() (#132)

2017-01-20 Thread Igor Gnatenko
cc @proyvind -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/132#issuecomment-274225716___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Check return value of uname() (#132)

2017-01-20 Thread Igor Gnatenko
Honestly, I didn't check 2nd patch carefully.. But according to my knowledge about operators precedence in C, it should just work. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Check return value of uname() (#132)

2017-01-20 Thread Igor Gnatenko
@cgwalters just strace with failure injection: `strace -e uname -e fault=uname rpm -qa` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Version range dependency (#159)

2017-02-19 Thread Igor Gnatenko
Example from Rust world: ``` ripgrep: BuildRequires: crate(clap) >= 2.18.0 ripgrep: BuildConflicts: crate(clap) >= 2.19.0 rust-clap-devel: Requires: crate(vec_map) >= 0.6.0 rust-clap-devel: Conflicts: crate(vec_map) >= 0.7.0 rust-clap-devel: Requires: crate(clippy) >= 0.0.112 rust-clap-devel:

[Rpm-maint] [rpm-software-management/rpm] Version range dependency (#159)

2017-02-19 Thread Igor Gnatenko
Coming from https://bugzilla.redhat.com/show_bug.cgi?id=1389871 Unfortunately, rich dependencies do not help with that as pointed in one of comments: ``` # rpm -i bar-1-1.fc25.remi.noarch.rpm error: Failed dependencies: ((foo >= 2) and (foo <= 3)) is needed by bar-1-1.fc25.remi.noarch

Re: [Rpm-maint] [rpm-software-management/rpm] Version range dependency (#159)

2017-02-19 Thread Igor Gnatenko
Let me show some example how would libsolv work with this: ``` repo system 0 testtags repo available 0 testtags #>=Pkg: ripgrep 0.4.0 1 src #>=Req: crate(clap) >= 2.18.0 & crate(clap) < 2.19.0 #>=Pkg: rust-clap-devel 2.18.5 1 noarch #>=Prv: crate(clap) = 2.18.5 #>=Req: crate(vec_map) >= 0.6.0 &

[Rpm-maint] [rpm-software-management/rpm] add support for rich dependencies from dependency generators (#168)

2017-02-25 Thread Igor Gnatenko
Closes: https://github.com/rpm-software-management/rpm/issues/167 Signed-off-by: Igor Gnatenko <ignate...@redhat.com> You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/168 -- Commit Summary -- * add support fo

Re: [Rpm-maint] [rpm-software-management/rpm] add support for rich dependencies from dependency generators (#168)

2017-02-25 Thread Igor Gnatenko
@ignatenkobrain pushed 1 commit. 357751e fixup! add support for rich dependencies from dependency generators -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] dependency generation doesn't work with rich dependencies (#167)

2017-02-24 Thread Igor Gnatenko
``` error: invalid dependency (bad format): (crate(spin) >= 0.4.0 with crate(spin) < 0.5.0) ``` I know that `with` is not something what RPM supports, but I suspect that any other rich dep will cause same error. RPM is 4.13.0.1. -- You are receiving this because you are subscribed to this

Re: [Rpm-maint] [rpm-software-management/rpm] RPM fails to parse rich dependencies returned by dependency generator (#167)

2017-02-24 Thread Igor Gnatenko
`parseDep()` from `build/rpmfc.c` does it's own parser, so I think if I will reuse `rpmrichParse()` from `lib/rpmds.h`, we will construct full string, then pass constructed information to `rpmdsSinglePool()` and finally call `rpmfcAddFileDep()` on newly created rpmds. I suppose this should

Re: [Rpm-maint] [rpm-software-management/rpm] [WIP] tests: add tests for boolean dependencies (#164)

2017-02-23 Thread Igor Gnatenko
@ffesti, I wrote couple of testcases for "with" op and looks like it doesn't work in some cases ``` 208: unsatisfied WITH requireok 209: satisfied WITH require ok 210: unsatisfied nested WITH-AND require FAILED (rpmdeps.at:851) 211:

[Rpm-maint] [rpm-software-management/rpm] [WIP] tests: add tests for boolean dependencies (#164)

2017-02-23 Thread Igor Gnatenko
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/164 -- Commit Summary -- * tests: add tests for boolean dependencies -- File Changes -- M tests/rpmdeps.at (483) -- Patch Links --

Re: [Rpm-maint] [rpm-software-management/rpm] Fix pythondistdeps.py --provides for Python wheels (#154)

2017-02-14 Thread Igor Gnatenko
ignatenkobrain approved this pull request. LGTM, @Conan-Kudo thoughts? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Conditional macro expansion fails (#127)

2017-01-16 Thread Igor Gnatenko
workaround which I use in `%py3_build` is `%py3_build "--use-cython"` which works I would reopen this bug. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add OpenSSL crypto backend (#129)

2017-01-18 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > +else { +/* ASCII requested */ +if (lenp) *lenp = (2*digestlen) + 1; +if (datap) { +const uint8_t * s = (const uint8_t *) digest; +*datap = pgpHexStr(s, digestlen); +} +} + +ret

Re: [Rpm-maint] [rpm-software-management/rpm] python bindings are using system RPM instead of in-source one (#130)

2017-01-18 Thread Igor Gnatenko
I will make a patch for it -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/130#issuecomment-273552868___ Rpm-maint mailing

Re: [Rpm-maint] [rpm-software-management/rpm] RISCV support (#79)

2016-08-20 Thread Igor Gnatenko
Closed #79. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/79#event-762071120___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps.py: Ensure that dist data used has py_version data (#80)

2016-08-20 Thread Igor Gnatenko
++ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/80#issuecomment-241205005___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [rpm-software-management/rpm] couple of fixes for pythondistdeps.py (#83)

2016-08-22 Thread Igor Gnatenko
Merged #83. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/83#event-76234___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps.py: Ensure that dist data used has py_version data (#80)

2016-08-22 Thread Igor Gnatenko
Closed #80. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/80#event-762844884___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [rpm-software-management/rpm] build: fgetc returns int, not char. (#82)

2016-08-22 Thread Igor Gnatenko
LGTM! nice catch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/82#issuecomment-241352151___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] couple of fixes for pythondistdeps.py (#83)

2016-08-22 Thread Igor Gnatenko
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/83 -- Commit Summary -- * pythondistdeps.py: Ensure that dist data used has py_version data * pythondistdeps.py: show warning if version is not found * pythondistdeps.py:

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for RISC-V (#81)

2016-08-22 Thread Igor Gnatenko
> @@ -243,6 +247,9 @@ arch_canon: mipsr6el: mipsr6el 20 > arch_canon: mips64r6: mips64r6 21 > arch_canon: mips64r6el: mips64r6el 21 > > +arch_canon: riscv: riscv64 22 one more tab? ;) -- You are receiving this because you are subscribed to this thread. Reply to this

[Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret higher than other separators in version/release (#87)

2016-09-09 Thread Igor Gnatenko
- This allows much nicer handling some scenarios where out of line versions are alphabetically smaller than previous verion numbers. - Add a rpmlib() tracking dependency to prevent older rpm versions from getting confused with packages relying on the new behavior. You can view, comment on, or

[Rpm-maint] [rpm-software-management/rpm] Makefile.maint: use git-rev-list (#89)

2016-09-10 Thread Igor Gnatenko
No need to query all commits and count lines of output, we can just ask git to provide information directly. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/89 -- Commit Summary -- * Makefile.maint: use git-rev-list --

[Rpm-maint] [rpm-software-management/rpm] Add support for sorting '+' higher than base verion (#88)

2016-09-10 Thread Igor Gnatenko
illed with tilde separator, but it's not obvious and doesn't fulfil first case. Signed-off-by: Igor Gnatenko <i.gnatenko.br...@gmail.com> You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/88 -- Commit Summary -- * Add support

Re: [Rpm-maint] [rpm-software-management/rpm] Remove extra dependencies (#86)

2016-09-10 Thread Igor Gnatenko
@legionus basically same what you wrote to github PR. Also update summary on the commit: `Remove extra dependencies` -> `tools/rpm2cpio.sh: remove extra dependencies` or something like this -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#88)

2016-09-12 Thread Igor Gnatenko
Changed to caret as @ffesti requested in ML. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/88#issuecomment-246362847___

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting '+' higher than base version (#88)

2016-09-10 Thread Igor Gnatenko
> @@ -45,6 +45,20 @@ int rpmvercmp(const char * a, const char * b) > continue; > } > > + /* > + * Handle plus separator. Concept is same as tilde, but it one of > + * strings ends, it's considered as lower version. no. -- You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting '+' higher than base version (#88)

2016-09-10 Thread Igor Gnatenko
@ignatenkobrain pushed 1 commit. 5af2531 Add rpmlib(PlusInVersions) extension -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive: return EXIT_SUCCESS on successful processing of package (#94)

2016-10-08 Thread Igor Gnatenko
ignatenkobrain approved this pull request. LGTM -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] Planning for rpm 4.13.0 (-rc2)

2016-10-15 Thread Igor Gnatenko
/gitlab.com/unity-linux-pkgs-core/rpm/blob/master/rpm-4.14.x-portable-definitions.patch > > I'd also like to see the following commits added in general, because > it fixes issues with building rpm that I've discovered over time > (oldest first): > aa4c0d4 digest_beecrypt: Use correct

Re: [Rpm-maint] Planning for rpm 4.13.0 (-rc2)

2016-10-14 Thread Igor Gnatenko
; time to speak up. > > - Panu - > > P.S. Yes, I'm back at rpm work, officially started this Monday. Lest anybody > have funny ideas: this was set in motion out of my own will well before the > recent "crisis" reported on lwn.net, although the timing of that was quite a &g

Re: [Rpm-maint] [rpm-software-management/rpm] appdata -> appstream, add support for metainfo files (#98)

2016-11-15 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > +# +# Transform appdata/metainfo xml file into RPM appstream(filename) provides +# +# Author: Michael Schroeder +# Based on other provides scripts from RPM + +OLD_IFS="$IFS" +while read instfile ; do + case "$instfile" in +

[Rpm-maint] [rpm-software-management/rpm] --keep-cr for %_scm_apply_git_am() (#102)

2016-11-25 Thread Igor Gnatenko
it should not hurt and will help users when archive comes with CRLF, but git-format-patch(1) creates LF. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Read the full date from RPM changelog (#95)

2016-10-21 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. LGTM. Though I'm not sure how this will work with RPMs created before that change. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

2016-12-09 Thread Igor Gnatenko
@soig Fully agree, saw same problem in Fedora -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266029269___

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

2016-12-09 Thread Igor Gnatenko
@rpm-maint Please hate @jsilhan and @j-mracek for this -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266035398___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Metatags (#107)

2016-12-12 Thread Igor Gnatenko
@proyvind @proyvind, I still didn't got use-case for this. Can you show some example? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

2017-01-11 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -70,6 +70,15 @@ %{_rpmconfigdir}/brp-strip %{__strip} \ %{_rpmconfigdir}/brp-strip-static-archive %{__strip} \ %{_rpmconfigdir}/brp-strip-comment-note %{__strip} %{__objdump} \ +%{?!dont_clean_files: [ -n

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

2017-01-11 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -0,0 +1,15 @@ +#!/bin/sh + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +INFODIR=`rpm --eval %{_infodir}/dir` + +dir="$RPM_BUILD_ROOT/$INFODIR" + +if [ -f

Re: [Rpm-maint] [rpm-software-management/rpm] Error if a macro in a comment is expanded to multiple lines (#124)

2017-01-12 Thread Igor Gnatenko
I like idea of this patchset. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/124#issuecomment-272172751___ Rpm-maint mailing

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

2017-01-11 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -0,0 +1,14 @@ +#!/bin/sh + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +find "$RPM_BUILD_ROOT" \( -type f -o -type l \) -name \*.la -print0 | nice one

Re: [Rpm-maint] [rpm-software-management/rpm] Support pbzip command for multicore environment (#117)

2017-01-06 Thread Igor Gnatenko
ignatenkobrain requested changes on this pull request. also it falis to build: ```c rpmio.c:706:1: error: expected identifier or '(' before '+' token + ^ ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Support pbzip command for multicore environment (#117)

2017-01-06 Thread Igor Gnatenko
@leemgs sure -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/117#issuecomment-270900988___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] find-lang.sh: Add --with-kde KF5 support (#112)

2017-01-01 Thread Igor Gnatenko
ignatenkobrain approved this pull request. lgtm -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Support pbzip command for multicore environment (#117)

2017-01-06 Thread Igor Gnatenko
ignatenkobrain approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/117#pullrequestreview-15490414___

Re: [Rpm-maint] [rpm-software-management/rpm] Support pbzip command for multicore environment (#117)

2017-01-06 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -72,6 +72,7 @@ Here's what's in yyy (\::\ format): binutils-2.9.1.0.23-7::/usr/lib/libbfd-2.9.1.0.24.so binutils-2.9.1.0.23-7::/usr/lib/libopcodes-2.9.1.0.24.so

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

2016-12-18 Thread Igor Gnatenko
ignatenkobrain approved this pull request. LGTM -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign: don't create & free NULL pointer (#111)

2016-12-20 Thread Igor Gnatenko
@pmatilai done -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/111#issuecomment-268204924___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] rpmsign: don't create & free NULL pointer (#111)

2016-12-19 Thread Igor Gnatenko
Signed-off-by: Igor Gnatenko <i.gnatenko.br...@gmail.com> You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/111 -- Commit Summary -- * rpmsign: don't create & free NULL pointer -- File Changes -- M rp

[Rpm-maint] [rpm-software-management/rpm] pkgconfigdeps: disable dependency resolver where supported (#192)

2017-04-07 Thread Igor Gnatenko
/show_bug.cgi?id=1401463 Reported-by: Martin Sehnoutka <msehn...@redhat.com> Signed-off-by: Igor Gnatenko <ignate...@redhat.com> You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/192 -- Commit Summary -- * pkgconfigd

Re: [Rpm-maint] [rpm-software-management/rpm] Adding high precision event time stamps to RPM (#197)

2017-04-11 Thread Igor Gnatenko
@n3npq please, can you send Pull Request instead of attaching patches in archive? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] 2 of 3 dwz tests are failing (#170)

2017-03-03 Thread Igor Gnatenko
@ffesti @pmatilai on unrelated note, `make check` doesn't fail when tests are failing... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [PATCH] tests/tpmbuild.at: Make file sed regexp more strict to extract BuildID.

2017-03-04 Thread Igor Gnatenko
t by only matching a hex-string. > Also properly "escape" [ and ] which inside an AT_CHECK should be [[ > and ]]. > > Tested against file versions 5.11, 5.29 and 5.30. > > Signed-off-by: Mark Wielaard <m...@klomp.org> Tested-by: Igor Gnatenko <ignate...@redhat.c

Re: [Rpm-maint] [rpm-software-management/rpm] Bump file digests to SHA256 by default, finally (0cd74ad)

2017-03-08 Thread Igor Gnatenko
shouldn't default mark be moved? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] build: error: line 73: unclosed macro or bad line continuation (broken spectool) (#175)

2017-03-11 Thread Igor Gnatenko
92a8babf1b46fa40a57a0e807f949f2c0f186435 is the first bad commit ``` commit 92a8babf1b46fa40a57a0e807f949f2c0f186435 Author: Lubos Kardos Date: Fri Mar 11 16:43:35 2016 +0100 Remove hopefully the last static buffer in rpm spec reading :04 04

Re: [Rpm-maint] [rpm-software-management/rpm] 2 of 3 dwz tests are failing (#170)

2017-03-10 Thread Igor Gnatenko
Closed #170. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/170#event-995289235___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] 2 of 3 dwz tests are failing (#170)

2017-03-10 Thread Igor Gnatenko
Fixed in master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/170#issuecomment-285737785___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for ARM 64bit (aarch64) - Add arm32 and arm64 macros (#173)

2017-03-08 Thread Igor Gnatenko
but why not to use just aarch64 in specs? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/173#issuecomment-284974832___

Re: [Rpm-maint] [rpm-software-management/rpm] RPM fails to parse rich dependencies returned by dependency generator (#167)

2017-03-08 Thread Igor Gnatenko
Closed #167 via #168. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/167#event-991074176___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] add support for rich dependencies from dependency generators (#168)

2017-03-08 Thread Igor Gnatenko
Merged #168. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/168#event-991074180___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for ARM 64bit (aarch64) - Add arm32 and arm64 macros (#173)

2017-03-08 Thread Igor Gnatenko
what I meant is that we have `%{ix86}` which represents `i386 i486 i586 ...`, but we don't have anything for `x86_64` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix non-standard inherented modes of directories in debuginfo (#194)

2017-04-08 Thread Igor Gnatenko
ignatenkobrain approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/194#pullrequestreview-31702779___

[Rpm-maint] [rpm-software-management/rpm] exclude respective debug files for files which are excluded (#286)

2017-07-28 Thread Igor Gnatenko
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/286 -- Commit Summary -- * remove duplicated call to strlen() * store path of excluded files * exclude respective debug files for files which are excluded -- File

Re: [Rpm-maint] [rpm-software-management/rpm] RFC Merge RPM 4.13 OS/2 code changes (#260)

2017-07-29 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. generally this looks good, is it everything what needs to be done to make RPM to compile and work on OS/2? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

2017-07-29 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. brp-clean-files seems useless to me and might break something. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

2017-07-29 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. brp-relink-symlinks seems too magic and I prefer users to explicitly do the right thing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

2017-07-29 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. brp-remove-info-dir looks useful, although I don't see why we need to be able to turn it off -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] _debuginfo_subpackages doesn't play well with perl (#278)

2017-07-29 Thread Igor Gnatenko
Closed #278. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/278#event-1184451466___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] _debuginfo_subpackages doesn't play well with perl (#278)

2017-07-29 Thread Igor Gnatenko
it seems to be just duplicate of #284 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/278#issuecomment-318813939___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

2017-07-29 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. brp-remove-libtool-files feels useless because some packages might need it (there are such packages in fedora), so asking packagers to remove libtool files is my preference here -- You are receiving this because you are subscribed to this

Re: [Rpm-maint] [rpm-software-management/rpm] exclude respective debug files for files which are excluded (#286)

2017-07-28 Thread Igor Gnatenko
@ignatenkobrain pushed 3 commits. e56ebda fixup! exclude respective debug files for files which are excluded 3b6043d store mapping for renamed files 7299900 reference proper debug files whenever RemovePathPostfixes is used -- You are receiving this because you are subscribed to this thread.

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Offer LMDB as an alternative engine to BDB for rpmdb (#128)

2017-07-29 Thread Igor Gnatenko
@Conan-Kudo time to learn russian ;) -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/128#issuecomment-318854552___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)

2017-08-02 Thread Igor Gnatenko
superseded by #295 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/283#issuecomment-319600646___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)

2017-08-02 Thread Igor Gnatenko
My personal preference is to keep $prefix/lib/rpm hardcoded. We do this in systemd, casync and a lot of other tools. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] add support for zstd compressed payload (#297)

2017-08-02 Thread Igor Gnatenko
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/297 -- Commit Summary -- * add support for zstd compressed payload * ci: Add libzstd-devel to CI Dockerfile -- File Changes -- M build/pack.c (6) M

Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (from @n3npq in #256) (#295)

2017-08-02 Thread Igor Gnatenko
Superseded by #297 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/295#issuecomment-319632547___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] add support for %{shrink:} (#296)

2017-08-02 Thread Igor Gnatenko
@pmatilai I think I fixed all nitpicks ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/296#issuecomment-319634624___

Re: [Rpm-maint] [rpm-software-management/rpm] add support for %{shrink:}, derived from rpm5.org (#234)

2017-08-02 Thread Igor Gnatenko
superseded by #296 which fixes some style issue in code + adds test -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default configuration and macros. (#298)

2017-08-02 Thread Igor Gnatenko
this will break existing distributions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/298#issuecomment-319643940___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add support for zstd compressed payload (#297)

2017-08-02 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -351,6 +351,9 @@ int rpmFileIsCompressed(const char * file, > rpmCompressedMagic * compressed) (magic[4] == 0x5a) && (magic[5] == 0x00)) { /* new style xz (lzma) with magic */ *compressed = COMPRESSED_XZ; +}

Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default configuration and macros. (#298)

2017-08-02 Thread Igor Gnatenko
@kanavin I still don't understand why $prefix/lib/rpm is a problem. This location is even described in FHS. so Yocto doesn't support FHS? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default configuration and macros. (#298)

2017-08-02 Thread Igor Gnatenko
> /usr/lib includes object files and libraries. [21] On some systems, it may > also include internal binaries that are not intended to be executed directly > by users or shell scripts. [22] > ... > [22] See below, in the /usr/libexec section, for a discussion of /usr/lib vs. > /usr/libexec for

Re: [Rpm-maint] [rpm-software-management/rpm] add support for zstd compressed payload (#297)

2017-08-02 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -8,7 +8,7 @@ Name: RPM Description: RPM Package Manager Version: @VERSION@ URL: http://rpm.org -# Requires: +Requires.private: @ZSTD_REQUIRES@ this is mostly if you would like to do `pkg-config --static --cflags --ldflags rpm` to link

Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default configuration and macros. (#298)

2017-08-03 Thread Igor Gnatenko
@kanavin so what's the deal with systemd, casync and others who use $prefix/lib/$name instead of $libexecdir/$name? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

  1   2   3   4   5   6   7   8   >