Hi Florian
Thank you.
I could build the source code on github by your script.
I missed to read "To compile RPM:" section in INSTALL file.
I did not run autogen.sh before configure script.
Kind regards,
Jun Aruga
- Original Message -
> From: "Florian Festi&q
near unexpected token `1.10'
./configure: line 2375: `AM_INIT_AUTOMAKE(1.10 foreign tar-ustar dist-bzip2
subdir-objects nostdinc)
```
Kind regards,
Jun Aruga
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm
Hi Florian
Thank you very much!!
I am going to try to use the script for build!
Jun Aruga
- Original Message -
> From: "Florian Festi" <ffe...@redhat.com>
> To: rpm-maint@lists.rpm.org
> Sent: Friday, August 5, 2016 3:21:40 PM
> Subject: Re: [Rpm-maint]
repoquery --tree-requires package_name
```
Thanks.
Best regards,
Jun Aruga
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Hello, @proyvind
I am not a maintainer of this project.
However this project started to use CI recently.
So, it might be good to rebase your branch for PR on top of master branch.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
junaruga commented on this pull request.
> @@ -354,5 +354,7 @@ int main(int argc, char *argv[])
rpmcliFini(optCon);
+rpmlog(RPMLOG_DEBUG, "exit code: %d\n", ec);
"Exit status" is better isn't it?
```
$ man ls
...
Exit status:
0 if OK,
1 if minor
Close this ticket, as I found how to run unit test.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I think that using CI environment is useful for contributors to send
pull-request.
So, I prepared the environment for test `rpm` on Fedora 24, 25, 26 and rawhide
container environment.
You can check the CI test for my repository.
https://travis-ci.org/junaruga/rpm
If you need to activate to
junaruga commented on this pull request.
> +language: c
+sudo: required
+dist: trusty
+services:
+ - docker
+env:
+# Fedora
+# https://hub.docker.com/r/_/fedora/
+- CONTAINER_IMAGE=fedora:24
+- CONTAINER_IMAGE=fedora:25
+- CONTAINER_IMAGE=fedora:26
+-
@junaruga pushed 1 commit.
378113d Update
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261/files/6f7d088740018557c2adce877d134113e7dd2b05..378113d64863b5eaf39f835cd7cb855c9966c5d7
> @junaruga What about Semaphore CI? I believe the Cockpit guys are already
> using it with some good success.
OK, I am fine for that.
I have never used the CI, so let me check it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
@ignatenkobrain in my understanding, on CircleCI (latest version 2.0 too), we
can not use for free to use 4 containers (Feodra 24, 25, 26, rawhide).
> I still don't think it is useful to build container every time.
Why do you think so?
The Travis running time is "3 min 20 sec".
--
You are
junaruga commented on this pull request.
> @@ -0,0 +1,49 @@
+FROM fedora
+
+ENV TEST_USER_ID 1000
Because I wanted to use variable `TEST_USER_ID` in below lines in `Dockerfile`.
How do you think?
```
RUN useradd -u $TEST_USER_ID tester
...
USER $TEST_USER_ID
```
--
You are receiving this
@junaruga pushed 2 commits.
914080c Fix for review.
6f7d088 Update
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@junaruga pushed 1 commit.
89f8f9a Update
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261/files/378113d64863b5eaf39f835cd7cb855c9966c5d7..89f8f9ac75cdfced0c633b35c782cf610c2030fe
junaruga commented on this pull request.
> + - |
+if [ "${CONTAINER_IMAGE}" != '' ]; then
+sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
+fi
+install:
+ - |
+docker build \
+-t rpm \
+.
+before_script:
+ - sudo chown -R 1000 .
+script:
+ - |
+
@junaruga pushed 1 commit.
a4a00b4 Update
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261/files/f31ce2eefb58c19b9519d421535ae8cb7b978893..a4a00b418cd74163409ceed2a16524f50e464558
@ignatenkobrain congratulations. Where is the RPM's URL in
https://semaphoreci.com ?
https://semaphoreci.com/rpm-software-management/rpm is 404 not found.
Does Semaphoreci have the configuration file such as `.travis.yml` or
`.circleci/config.yml`?
I want to see the logic to test `rpm` on 4
@Conan-Kudo it seems that "Semaphore CI" is not for free to use 4 containers.
https://semaphoreci.com/pricing
Also it seems that the setting can be only edited from GUI operation. But it is
good to manage the settings by configuration file, isn't it?
Cockpit project does not use docker for
junaruga commented on this pull request.
> @@ -0,0 +1,49 @@
+FROM fedora
+
+ENV TEST_USER_ID 1000
+
+RUN dnf -y install \
> Also I would add dnf update as previous step
OK, just moment. I am going to add it.
--
You are receiving this because you are subscribed to this thread.
Reply to this
Rebased!
https://travis-ci.org/junaruga/rpm/builds/255401154
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
junaruga commented on this pull request.
> +dist: trusty
+services:
+ - docker
+env:
+# Fedora
+# https://hub.docker.com/r/_/fedora/
+- CONTAINER_IMAGE=fedora:24
+- CONTAINER_IMAGE=fedora:25
+- CONTAINER_IMAGE=fedora:26
+- CONTAINER_IMAGE=fedora:rawhide
+before_install:
junaruga commented on this pull request.
> @@ -0,0 +1,32 @@
+language: c
OK. I will remove this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
junaruga commented on this pull request.
> @@ -0,0 +1,49 @@
+FROM fedora
+
+ENV TEST_USER_ID 1000
+
+RUN dnf -y install \
OK. I will add the options.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
junaruga commented on this pull request.
> +sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
+fi
+install:
+ - |
+docker build \
+-t rpm \
+.
+before_script:
+ - sudo chown -R 1000 .
+script:
+ - |
+DIR=$(pwd)
+docker run \
+-v
@junaruga pushed 1 commit.
c674791 Update
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261/files/89f8f9ac75cdfced0c633b35c782cf610c2030fe..c6747912009a7f0c298635cb7307fb400ca56be9
@ignatenkobrain Updated! How?
https://travis-ci.org/junaruga/rpm/builds/255363668
My concern is
if `language` is not specified, it looks running as `language: ruby`.
If we will set `language: generic`, it is displayed as "no language set"
instead of "Ruby".
But I do not know that it is right
@junaruga pushed 1 commit.
40f61d9 Update
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261/files/1a8b8dcd811f2f18c2ed1187e4a3de8788ac7799..40f61d9c21077c0d36ec0eac9e5d0fe91dd968f5
junaruga commented on this pull request.
> +readline-devel \
+redhat-rpm-config \
+rpm-build \
+which \
+xz-devel \
+zlib-devel
+
+RUN dnf clean all
+
+RUN useradd -u $TEST_USER_ID tester
+
+WORKDIR /builddir
+
+COPY . .
+
+RUN chown -R 1000 .
Ah sorry 1000 is hard
I would share a case I want you to upload the the rpm Python bindings to PyPI.
A python package `rebase-helper` [1] depends on the rpm Python bindings.
For this reason, `rebase-helper` can not add `install_requires` to `setup.py`
file.
If we want to install `rebase-helper` from source, I am
It looks better, isn't it?
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/272
-- Commit Summary --
* Update dnf options in Dockerfire for readability.
-- File Changes --
M ci/Dockerfile (6)
-- Patch Links --
Humm, just moment.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/272#issuecomment-317174918___
Rpm-maint mailing list
Here document does not work ;)
At least, it can be supported from Docker 2.0.
Ref: `https://github.com/moby/moby/issues/1554#issuecomment-196544146`
```
RUN cat <> /etc/dnf/dnf.conf
deltarpm=0
install_weak_deps=0
tsflags=nodocs
EOF
```
Brackets also does not work ;)
```
RUN (
echo deltarpm=0
I want to run unit tests under `tests/` directory.
I tried below way seeing `INSTALL` document
https://github.com/rpm-software-management/rpm/blob/master/INSTALL#L181-L186
```
$ make check
make check-recursive
make[1]: Entering directory '/home/jaruga/git/rpm'
Making check in po
make[2]:
Sorry I will take care of not using here as the support forum.
Thanks for the information! I will take a look of the fedora packaging.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Rename old `fakechrrot` URL in `INSTALL`.
This closes https://github.com/rpm-software-management/rpm/issues/243
http://pkgs.fedoraproject.org/cgit/rpms/fakechroot.git/tree/fakechroot.spec
> URL:https://github.com/dex4er/fakechroot
You can view, comment on, or merge this pull request
Right now `make check` returns success exit status: 0 when the tests are failed.
```
$ make check
...
## - ##
## Test results. ##
## - ##
ERROR: All 358 tests were run,
21 failed (2 expected failures).
## - ##
## rpmtests.log was created. ##
##
I want to add `make style-check` task for static code analysis as a dependency
task of `make check` in `Makefile`. Because it helps to maintain, keeping the
code clean.
Candidate tools
- C file: I do not know which tool is good.
- Python file: `flake8` [1].
- Shell (bash) file: `sh -n`,
I would close this PR to change the approach.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/303#issuecomment-323445795___
Closed #303.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/303#event-1212471133___
Rpm-maint mailing list
## Motivation
I want to add style (static code analysis) test and pytest for the python code.
When I did debug the python code for the issue related to library path:
https://github.com/rpm-software-management/rpm/issues/130 , I thought adding
those was useful.
## Detail
We have
> I usually find that "static analysis" on scripts is just too much work.
Well, if you do not like static analysis for scripts, I do not promote the
tools for the script files (*.sh, *.py) in this project.
Focusing to interest topics, not quoting and globing and etc.
That makes sense. I can
Is there the coding rule for this project (for C)?
It looks K style.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
This PR includes several factors. Sorry for that.
What I want to know is
1. Do we like starting style check?
1.1. Use `flake8`?
2. Do we like starting a unit test by `pytest`?
3. Do we use `tox`? (`tox` is a little bit magic.)
--
You are receiving this because you are subscribed to this
Thank you for that. But it seems that the CI test is not run for this PR..
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
This fixes the Python bindings ModuleNotFoundError for custom prefix.
http://lists.rpm.org/pipermail/rpm-maint/2017-September/006568.html
The reason is the Extension class libraries attribute does not accept library
file or directory path.
According to
Let me announce.
I developed a installer to install `rpm-python` or `rpm` (same version with
system RPM) on non-system Python.
People can install `rpm-python` by installing `rpm-py-installer` from PyPI.
https://pypi.python.org/pypi/rpm-py-installer
https://github.com/junaruga/rpm-py-installer
Sorry this modification becomes error on Python 2.7.
```
(venv2) $ pip list
PackageVersion
-- ---
pip9.0.1
rpm4.14.90
setuptools 36.4.0
wheel 0.29.0
(venv2) $ pip uninstall rpm
Uninstalling rpm-4.14.90:
OK. That makes sense. Feel free to close this ticket.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
___
> Rpm-maint mailing list
> Rpm-maint@lists.rpm.org
> http://lists.rpm.org/mailman/listinfo/rpm-maint
>
--
Jun Aruga jar...@redhat.com
IRC: jaruga, Office: TPB(Technology Park Brno) Building C 1F, Brno, Czech
Republic
___
Hello,
Though it might be basic thing,
when I built latest master branch's source with ./configure --prefix, then
I did import the Python bindings, I got ModuleNotFoundError.
Could you tell me how to import it?
Thanks.
Below steps are what I did.
$ pwd
/home/jaruga/git/rpm
$ ./autogen.sh
Hi Panu,
Thanks for the answer.
Um, "import rpm"?
> If that doesn't work then either it's not in your runtime environment
> paths, or there's something wrong with the build.
>
Yes, "import rpm".
> $ cd python/
>>
>> $ python3 -m venv ./venv
>>
>
> No idea what this does so hard to say.
>
It
OK.
By the way, we can do "import rpm" without `LD_LIBRARY_PATH` for custom prefix
by adding `runtime_library_dirs = pkgconfig('--libs-only-L')` to each
`Extension` class
Do you want to add this in this PR?
I thought an another PR was better after merging this PR, because we may need
more
Why don't you merge?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/327#issuecomment-332135262___
Rpm-maint mailing list
What is brp script's "brp"? Though it may be basic knowledge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> My previous comment was wrto adding static analysis instrumentation to
> rpmbuild for other packages.
Yeah, I knew that after reading your comment. `rpmbuild` and `rpmlint` are
doing the analysis.
My proposal is about for static analysis on RPM itself, as you mentioned.
> For static analysis
Previously we needed to set `LD_LIBRARY_PATH` to run the Python bindings for
custom prefix.
```
$ LD_LIBRARY_PATH=$HOME/git/rpm/dest/lib python3 -c 'import rpm;
print(rpm.__version__)'
4.14.90
```
This PR to do "import rpm" without LD_LIBRARY_PATH.
Below is the way to reproduce and test it.
@pmatilai thanks for your checking!
> but I don't see this helping #130 at least in the general case.
OK, perhaps, I may need to send additional PR for that.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> Is RPATH being removed on installation?
Where is `RPATH` on installation?
At least on latest current master branch, `import rpm` becomes the error
without `LD_LIBRARY_PATH`.
```
$ python3 -c 'import rpm; print(rpm.__version__)'
Traceback (most recent call last):
File "", line 1, in
File
@ignatenkobrain I agree with you.
I think showing the little or big endian information by rpm helps the debugging.
I did debug writing below code in a source directly.
I want to check it more casually.
```
+ /*
+ int n = 1;
+ if(*(char *) == 1) {
+printf("debug the system is little
Hi maintainers of the RPM!
Why this PR has not been merged yet?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/releases/tag/rpm-4.14.0-release
> RPM releases are tracked at http://rpm.org/timeline
> Official RPM source releases are available at http://ftp.rpm.org/releases/,
> do not use GitHub provided tarballs.
Is it no problem and better to use
I wanted to use `patch -T` option for %patch macro, to set fixed timestamp for
a patched file.
Because It is related to reproductive build. The timestamp is used as a gz
file's metadata modified date in a program.
Is it possible to support the option?
ruby.spec
```
-%patch20 -p1
+%patch20
Or I want an option for %patch to preserve the timestamp of the patched file
like `cp -p`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
It seems `-Z` is better than `-T`.
```
$ man patch
...
-T or --set-time
Set the modification and access times of patched files from time
stamps given in
context diff headers. Unless specified in the time stamps, assume
that the con‐
text diff headers
> The other question is whether this should be added to _default_patch_flags in
> the long run.
This is the best solution for me if we can add it to the _default_patch_flags.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
I tested `patch -Z` on my local using this repository's README file.
I created below 2 files based on a result of `diff -u`.
I expected the patched file is updated as fixed value.
But actually on below cases, it is updated as system date even when using
`patch -Z`.
Just implementing `patch -Z`
Thanks for the info. I understand it.
I simply like the behavior like `cp -p` just to preserve the timestamp.
Because it always update the file as fixed date.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Sorry for my multiple post about this topic.
Yesterday I posted below email to rpm-list mailing list, could you comment for
this?
http://lists.rpm.org/pipermail/rpm-list/2020-March/002013.html
Feel free to close this GitHub issue page, if you like.
Thanks for your help.
--
You are receiving
## Sumamry
`%define` macro is not evaluated, the value is not set when building a RPM spec
file with rpm-4.11.3-40 and `%bcond_without git` is executed.
## Context
I was trying to build a `ruby.spec` file on RHEL7, that is based on the Fedora
rawhide current latest `ruby.spec`
## How to reproduce this issue on your environment
1. Fork the repository: https://github.com/junaruga/report-rpm-macro-define
2. Enable Travis CI for the repository.
3. Check the Travis CI result modifying the `foo.spec` file.
--
You are receiving this because you are subscribed to this
@pmatilai Thanks for your info!
After changing the spec file to use `%if` like this, `%release_string` macro
value was set.
```
diff --git a/foo.spec b/foo.spec
index 47a0596..b19233b 100644
--- a/foo.spec
+++ b/foo.spec
@@ -1,5 +1,7 @@
%global release 2
-%{!?release_string:%define
Yeah, it's more readable. Thanks for sharing the tip.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I tried following code in the `ruby.spec`.
But is there a way to check if the `load` builtin macro exists?
The part `%{defined load}` in the following code fails with `error:
/home/jaruga/git/rh-packages/scl/rh-ruby27/ruby/ruby.spec: line 99: failed to
load macro file 0`.
```
if %{defined load}
Guys, thanks for your info! It's useful.
For the hacks, it looks working.
With the RPM 4.15.1.
```
$ rpm --version
RPM version 4.15.1
$ rpm -E '%{load:/dev/null}'
<= empty
```
With the RPM 4.11.3.
```
sh-4.2# rpm --version
RPM version 4.11.3
sh-4.2# rpm -E '%{load:/dev/null}'
Many thanks! As I could fixed the issue by the following way, I would close
this ticket.
```
# Call load builtin macro if it is defined, otherwise call own load macro
# to avoid an error by creating SRPM in RPM 4.15+
%if "%{load:/dev/null}" == ""
%{?load:%{SOURCE4}}
%{?load:%{SOURCE5}}
%else
Possibly here is a part of the logic causing the error.
https://github.com/rpm-software-management/rpm/blob/10127cdb2364de2c1408950a25b730920e665689/rpmio/macro.c#L638-L641
Here is the testing code to test the logic.
Yes, the bug in the rpmlint was fixed. For now the `%{load:foo}` is used in
`ruby.spec` on the Fedora rawhide (development version) branch instead of
`%{?load:foo}`.
We are asking here to understand more about the details and context.
* "If I am not mistaken, at that time, the question mark
@pmatilai ok thanks I will try it!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1669#issuecomment-833461866___
Rpm-maint
@pmatilai I am seeing `doc/manual/lua.md` and https://rpm.org/user_doc/lua.html
. Sorry could you tell me what's wrong in the following code?
```
%load_if_exists(path) %{lua:
if posix.access(arg.path, "r") then
print("Loading " .. arg.path .. "..")
load(arg.path)
end
}
> Sorry could you tell me what's wrong in the following code?
I was able to implement the own exists macro like this. I expect `rpmlint`
skips the load. But `rpmlint` still checks the load macro printing parsing
error. Now what we need to fix is rpmlint.
```
%global exists_file %{lua:
> I'd love to hear real explanation first, because I think that the report you
> have made was misunderstood
@voxik for your above comment on our chat about my report here, I think it's
better to explain it here. Dees the real explanation mean @pmatilai 's answer
about why the RPM project
Panu, is it possible to reopen this ticket until we find a fix of a friction
between us?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
This issue might be same with #1663 .
* OS: Fedora 35 (rawhide) Linux
* RPM version: 4.16.90-0.git15395.2
I see the following error started to happen when building ruby on Koji. It
seems that the error is related to `load`.
```
DEBUG util.py:444: error: line 116: Unknown tag:
I can try to create a minimal reproducer if you want.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Thanks for the info! Let me check it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1669#issuecomment-832605314___
Closed #1669.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1669#event-4688478118___
Rpm-maint mailing list
Thanks! I confirmed it works with `%{load: ...}`. I would close this ticket.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pmatilai when using `%{load:...}`, the rpmlint failed to part the spec file.
https://github.com/rpm-software-management/rpmlint/issues/632 . The rpmlint can
not detect the loaded file's existence.
I see the `%{exists...}` is still new in RPM 4.17.
http://rpm.org/user_doc/macros.html
Is there
Reopened #1669.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1669#event-4689242420___
Rpm-maint mailing list
@junaruga commented on this pull request.
> @@ -0,0 +1,11 @@
+Metadata-Version: 1.0
+Name: @PROJECT_NAME@
+Version: @PROJECT_VERSION@
+Summary: Python bindings for rpm
+Home-page: @PROJECT_HOMEPAGE_URL@
+Author: Rpm community
+Author-email: rpm-maint@lists.rpm.org
+License: GNU General Public
I am using the `setup.py.in` in the `rpm-py-installer` pip package that
installs the RPM Python binding pip package, and enables people to use the RPM
python binding on some Python environments.
https://github.com/junaruga/rpm-py-installer
--
Reply to this email directly or view it on GitHub:
OK. Is there a way to create a PIP package from the `*.egg-info` file
(`python/rpm.egg-info.in`)?
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2231#issuecomment-1282324947
You are receiving this because you are subscribed to this
Just note for someone including me who wants to know what RPM versions have
this change.
I can see the backported commit is on the rpm-4.18.x branch. And the RPM
version 4.18.1 includes the commit.
https://github.com/rpm-software-management/rpm/commit/c90144e2f899e4a5e053ecf899b1c4036be3e35c
94 matches
Mail list logo
