Re: [Rpm-maint] [rpm-software-management/rpm] Come up with replace_optflags (#814). (#815)
Closed #815. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/815#event-2556286671___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Come up with replace_optflags (#814). (#815)
Um, rpm macros have nothing to do with m4. I don't have any concrete proposals at this time, just asking for a rethink and pointing to the general direction that I would find acceptable. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/815#issuecomment-521208028___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Come up with replace_optflags (#814). (#815)
> I'm really reluctant to add one-trick-pony utility macros like this because > over time they tend to become liabilities one way or the other, and have > other issues. Good. > > Manipulating compiler flags is a very common need indeed and could use some > help from rpm, but that need is not limited to %optflags, there are various > other similar things as well and I certainly don't want separate macros for > updating %build_cflags, %build_cxxflags, %build_ldflags and so on. To be honest, I'm not much familiar with `m4` language and how `rpm` works. Can you please help me how should such macro look like? Should it take the variable name as a first argument? > > I'd be more inclined to consider a generic utility or macro primitive that > helps in these kind of tasks. Also, it's worth considering whether the flags > be stored in a more manipulation friendly manner in the first place. I'm open for a better-defined API. Can you help me with that as well? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/815#issuecomment-521206621___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Come up with replace_optflags (#814). (#815)
I'm really reluctant to add one-trick-pony utility macros like this because over time they tend to become liabilities one way or the other, and have other issues. Manipulating compiler flags is a very common need indeed and could use some help from rpm, but that need is not limited to %optflags, there are various other similar things as well and I certainly don't want separate macros for updating %build_cflags, %build_cxxflags, %build_ldflags and so on. I'd be more inclined to consider a generic utility or macro primitive. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/815#issuecomment-521185533___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Come up with replace_optflags (#814). (#815)
@marxin Why is this necessary? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/815#issuecomment-521185369___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Come up with replace_optflags (#814). (#815)
The macro function is intended for %{optflags} manipulation
(replacement, conditional addition).
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/815
-- Commit Summary --
* Come up with replace_optflags (#814).
-- File Changes --
M macros.in (7)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/815.patch
https://github.com/rpm-software-management/rpm/pull/815.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/815
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
