> Ok, documentation can go into
> https://rpm.org/user_doc/dependency_generators.html as soon as this is
> upstream/released.
Added:
https://rpm.org/user_doc/dependency_generators#parametric-macro-generators-rpm--416
--
You are receiving this because you are subscribed to this thread.
Reply
Merged #1053 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1053#event-3025934733___
Rpm-maint mailing list
pmatilai commented on this pull request.
> @@ -514,6 +514,22 @@ static ARGV_t runCmd(const char *cmd,
return output;
}
+static ARGV_t runCall(const char *cmd,
+const char *buildRoot, const char *fn)
+{
+
+ARGV_t output = NULL;
+char *fullcmd = rstrscat(NULL,
Updated to use rpmMacroIsParametric() as the API name, tweaks to commit
message(s).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pmatilai pushed 2 commits.
c2177646458ef20c6d3cfeeddc0fa7ca34c0d50b Add APIs for testing whether a macro
is defined and whether its parametric
fc98504d59603014edffa53439b96c793ac11f29 Add support for macro-only dependency
generators
--
You are receiving this because you are subscribed to
pmatilai commented on this pull request.
> @@ -1784,6 +1784,29 @@ rpmDefineMacro(rpmMacroContext mc, const char * macro,
> int level)
return rc;
}
+int rpmMacroIsDefined(rpmMacroContext mc, const char *n)
+{
+int defined = 0;
+if ((mc = rpmmctxAcquire(mc)) != NULL) {
+ if
mlschroe approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1053#pullrequestreview-356505622___
pmatilai commented on this pull request.
> @@ -1784,6 +1784,29 @@ rpmDefineMacro(rpmMacroContext mc, const char * macro,
> int level)
return rc;
}
+int rpmMacroIsDefined(rpmMacroContext mc, const char *n)
+{
+int defined = 0;
+if ((mc = rpmmctxAcquire(mc)) != NULL) {
+ if
mlschroe commented on this pull request.
> @@ -1784,6 +1784,29 @@ rpmDefineMacro(rpmMacroContext mc, const char * macro,
> int level)
return rc;
}
+int rpmMacroIsDefined(rpmMacroContext mc, const char *n)
+{
+int defined = 0;
+if ((mc = rpmmctxAcquire(mc)) != NULL) {
+ if
Okay, together with the new RPMMACRO_LITERAL and a whole pile of other
escaping-related changes, a path with percent signs can actually be passed
unharmed through this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pmatilai pushed 13 commits.
8b1ea52de31a428952a470225b153393489743fe Double the '%' chars when splitting
macro args
c886b359ba5f05eec6a8da34b55437834b7d80ee Fix pointer dereference before
testing for NULL in rpmtdGetNumber()
94623389ba61a3a93decc726ed63e52cca7b3d39 Fix buffer overflow in
Blocked until #1060 is merged and this PR updated to pass the argument as a
literal.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
pmatilai commented on this pull request.
> @@ -514,6 +514,22 @@ static ARGV_t runCmd(const char *cmd,
return output;
}
+static ARGV_t runCall(const char *cmd,
+const char *buildRoot, const char *fn)
+{
+
+ARGV_t output = NULL;
+char *fullcmd = rstrscat(NULL,
mlschroe commented on this pull request.
> @@ -514,6 +514,22 @@ static ARGV_t runCmd(const char *cmd,
return output;
}
+static ARGV_t runCall(const char *cmd,
+const char *buildRoot, const char *fn)
+{
+
+ARGV_t output = NULL;
+char *fullcmd = rstrscat(NULL,
pmatilai commented on this pull request.
> @@ -514,6 +514,22 @@ static ARGV_t runCmd(const char *cmd,
return output;
}
+static ARGV_t runCall(const char *cmd,
+const char *buildRoot, const char *fn)
+{
+
+ARGV_t output = NULL;
+char *fullcmd = rstrscat(NULL,
@pmatilai pushed 1 commit.
53fa6af7a59e307eee0468ad5a94e45906ea2b2f Add support for macro-only dependency
generators
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
pmatilai commented on this pull request.
> @@ -514,6 +514,22 @@ static ARGV_t runCmd(const char *cmd,
return output;
}
+static ARGV_t runCall(const char *cmd,
+const char *buildRoot, const char *fn)
+{
+
+ARGV_t output = NULL;
+char *fullcmd = rstrscat(NULL,
pmatilai commented on this pull request.
> @@ -514,6 +514,22 @@ static ARGV_t runCmd(const char *cmd,
return output;
}
+static ARGV_t runCall(const char *cmd,
+const char *buildRoot, const char *fn)
+{
+
+ARGV_t output = NULL;
+char *fullcmd = rstrscat(NULL,
pmatilai commented on this pull request.
> @@ -1784,6 +1784,29 @@ rpmDefineMacro(rpmMacroContext mc, const char * macro,
> int level)
return rc;
}
+int rpmMacroIsDefined(rpmMacroContext mc, const char *n)
+{
+int defined = 0;
+if ((mc = rpmmctxAcquire(mc)) != NULL) {
+ if
mlschroe commented on this pull request.
> @@ -514,6 +514,22 @@ static ARGV_t runCmd(const char *cmd,
return output;
}
+static ARGV_t runCall(const char *cmd,
+const char *buildRoot, const char *fn)
+{
+
+ARGV_t output = NULL;
+char *fullcmd = rstrscat(NULL,
mlschroe commented on this pull request.
> @@ -1784,6 +1784,29 @@ rpmDefineMacro(rpmMacroContext mc, const char * macro,
> int level)
return rc;
}
+int rpmMacroIsDefined(rpmMacroContext mc, const char *n)
+{
+int defined = 0;
+if ((mc = rpmmctxAcquire(mc)) != NULL) {
+ if
Testcase added.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1053#issuecomment-582828428___
Rpm-maint mailing list
@pmatilai pushed 1 commit.
4bca4dc8908e34c7d12b8378bda436210def4f0b Add support for macro-only dependency
generators
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Fixed rpmdeps case where buildroot is not defined.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pmatilai pushed 1 commit.
a3614643b55eaeabe28c1f23822602994d9d9582 Add support for macro-only dependency
generators
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
For an example, take a look at kmod.prov (which is actually what inspired this
whole thing): the core of it boils down to echoing the basename of the filename
back, stripped of suffix. For each, it spawns a shell and runs external
utilities. When you consider that the kernel has (tens of)
Just noticed this isn't working when called from rpmdeps, need to sort that out.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
This deserves both some documentation and a test case.
Ok, documentation can go into
https://rpm.org/user_doc/dependency_generators.html as soon as this is
upstream/released.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
Do you have some example how this could be used?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1053#issuecomment-582803014___
In some cases generators are remarkably simple, such as just echoing back the
basename of the file in some namespace such as foo(lib.so), and forking out a
shell to perform such a mundane task is both hideously slow and plain dumb,
when we have quite some string processing facilities and even a
30 matches
Mail list logo
