Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign: support EdDSA signatures (#1571)

2021-03-16 Thread ニール・ゴンパ
> I don’t particularly care which tag is used, so long as it works. Can we 
> eliminate the distinction in RPMv6?

We'd need _some_ way to tell what keys are what type, but there are certainly 
better ways to do it. Ideally, RPMv6 would also include fixing support for 
multiple signatures.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1571#issuecomment-800118109___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign: support EdDSA signatures (#1571)

2021-03-15 Thread Panu Matilainen
Merged #1571 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1571#event-4458259053___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign: support EdDSA signatures (#1571)

2021-03-15 Thread Panu Matilainen
Seems like a revised version of #1500 accidentally ended up in this PR. No 
matter, I far prefer this version and splitting this to yet more PR's wouldn't 
actually help anything. Also, @mlschroe seems to be busy but he did indicate 
the preference for existing tags in #1202 so...

Thanks for the patches!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1571#issuecomment-799362147___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign: support EdDSA signatures (#1571)

2021-03-13 Thread Demi Marie Obenour
@DemiMarie pushed 1 commit.

acfa8f488ae13ccf49f1b004fe0e44d420d93c04  rpmsign: support EdDSA signatures


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1571/files/e84d135305f8befd2426feaeed21969254c0360f..acfa8f488ae13ccf49f1b004fe0e44d420d93c04
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign: support EdDSA signatures (#1571)

2021-03-13 Thread Demi Marie Obenour
@DemiMarie pushed 2 commits.

aa963fa5121dfe270adad92038b064637a2db0b3  hdrblobInit() needs bounds checks too
e84d135305f8befd2426feaeed21969254c0360f  rpmsign: support EdDSA signatures


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1571/files/4b60d024b3894caf86e085b1fddcc725919a9e97..e84d135305f8befd2426feaeed21969254c0360f
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign: support EdDSA signatures (#1571)

2021-03-10 Thread Demi Marie Obenour
> It certainly is not an RSA signature. See the discussion in #1202 and related.
> As the multiple signature support work hasn't progressed anywhere (and it 
> wont anytime soon), perhaps we should consider just reusing the DSA tag for 
> this afterall. I guess that's what @mlschroe originally had in mind?

I don’t particularly care which tag is used, so long as it works.  Can we 
eliminate the distinction in RPMv6?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1571#issuecomment-795967692___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign: support EdDSA signatures (#1571)

2021-03-10 Thread Panu Matilainen
It certainly is not an RSA signature. See the discussion in #1202 and related.
As the multiple signature support work hasn't progressed anywhere (and it wont 
anytime soon), perhaps we should consider just reusing the DSA tag for this 
afterall. I guess that's what @mlschroe originally had in mind?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1571#issuecomment-795492178___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] rpmsign: support EdDSA signatures (#1571)

2021-03-06 Thread Demi Marie Obenour
They were previously rejected
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1571

-- Commit Summary --

  * rpmsign: support EdDSA signatures

-- File Changes --

M sign/rpmgensig.c (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1571.patch
https://github.com/rpm-software-management/rpm/pull/1571.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1571
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint